Attachment 357468 Details for Bug 192767 – Patch

[patch] Patch

bug-192767-20181217124410.patch (text/plain), 1.83 KB, created by Jeremy Jones on 2018-12-17 12:44:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-12-17 12:44:11 PST

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 238527
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 54d01d09ea083b1bb2bed8bd0d5ef25845e618dd..eb93c4ab6cb0e78aa22308a0630a06370cd05559 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-17  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Switch tabs before retuning PiP video to inline.
>+        https://bugs.webkit.org/show_bug.cgi?id=192767
>+        rdar://problem/46006046
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests because this code path only happens with a user action on system UI.
>+
>+        When exiting PiP, notify the fullscreen change observer so it can restore client UI state before exiting.
>+
>+        * platform/mac/VideoFullscreenInterfaceMac.mm:
>+        (-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]):
>+
> 2018-11-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         SVG use element inside a shadow tree cannot reference an element in the same tree
>diff --git a/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm b/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
>index 82e2e3650dcdde25f1d5c459a786a52a641337c9..1aa127e6b49cd5f4acd919e22c181f51200da30f 100644
>--- a/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
>+++ b/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
>@@ -272,8 +272,11 @@ - (BOOL)pipShouldClose:(PIPViewController *)pip
> {
>     ASSERT_UNUSED(pip, pip == _pipViewController);
> 
>-    if (!_videoFullscreenInterfaceMac || !_videoFullscreenInterfaceMac->videoFullscreenChangeObserver())
>+    if (!_videoFullscreenInterfaceMac)
>         return YES;
>+    
>+    if (_videoFullscreenInterfaceMac->videoFullscreenChangeObserver())
>+        _videoFullscreenInterfaceMac->videoFullscreenChangeObserver()->fullscreenMayReturnToInline();
> 
>     _videoFullscreenInterfaceMac->requestHideAndExitPiP();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192767: 357468