WebKit Bugzilla
Attachment 357449 Details for
Bug 192634
: Make DocumentMarker::allMarkers() constexpr
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192634-20181217104636.patch (text/plain), 1.87 KB, created by
Daniel Bates
on 2018-12-17 10:46:36 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-12-17 10:46:36 PST
Size:
1.87 KB
patch
obsolete
>Subversion Revision: 239270 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 0d239354a3065eb6debf92fc1b943ae1b0dbcade..9b625fc3c380df18e1d9dbba018f28100d836598 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-12-12 Daniel Bates <dabates@apple.com> >+ >+ Make DocumentMarker::allMarkers() constexpr >+ https://bugs.webkit.org/show_bug.cgi?id=192634 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The result of DocumentMarker::allMarkers() can be computed at compile time. We should annotate >+ it constexpr to do just that. >+ >+ * dom/DocumentMarker.h: >+ (WebCore::DocumentMarker::allMarkers): >+ > 2018-12-12 Daniel Bates <dabates@apple.com> > > [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:] >diff --git a/Source/WebCore/dom/DocumentMarker.h b/Source/WebCore/dom/DocumentMarker.h >index 994c39c03d6ee8a4f9c0942212bfce5cf1195091..49b0a15c1ef6529e698a341cd89ac8c57601affc 100644 >--- a/Source/WebCore/dom/DocumentMarker.h >+++ b/Source/WebCore/dom/DocumentMarker.h >@@ -82,7 +82,7 @@ public: > DraggedContent = 1 << 14 > }; > >- static OptionSet<MarkerType> allMarkers(); >+ static constexpr OptionSet<MarkerType> allMarkers(); > > using IsActiveMatchData = bool; > using DescriptionData = String; >@@ -141,9 +141,9 @@ private: > Data m_data; > }; > >-inline auto DocumentMarker::allMarkers() -> OptionSet<MarkerType> >+constexpr auto DocumentMarker::allMarkers() -> OptionSet<MarkerType> > { >- OptionSet<MarkerType> markers { >+ return { > AcceptedCandidate, > Autocorrected, > CorrectionIndicator, >@@ -164,7 +164,6 @@ inline auto DocumentMarker::allMarkers() -> OptionSet<MarkerType> > DictationResult, > #endif > }; >- return markers; > } > > inline DocumentMarker::DocumentMarker(unsigned startOffset, unsigned endOffset, bool isActiveMatch)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192634
:
357153
| 357449