WebKit Bugzilla
Attachment 357437 Details for
Bug 192754
: [MSE] Remove unused method: stopAskingForMoreSamples()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192754-20181217151739.patch (text/plain), 3.64 KB, created by
Alicia Boya García
on 2018-12-17 06:17:40 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alicia Boya García
Created:
2018-12-17 06:17:40 PST
Size:
3.64 KB
patch
obsolete
>Subversion Revision: 239229 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 854ee33b41e81f2b845a701004e4be25b79f5d2b..56b40352123186e2a4db2b187f92b58094076d78 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,21 @@ >+2018-12-17 Alicia Boya GarcÃa <aboya@igalia.com> >+ >+ [MSE] Remove unused method: stopAskingForMoreSamples() >+ https://bugs.webkit.org/show_bug.cgi?id=192754 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The stopAskingForMoreSamples() method from SourceBufferPrivate is not >+ being used by anyone. SourceBuffer is not calling it and no >+ SourceBufferPrivate is implementing it. Let's remove that noise. >+ >+ * platform/graphics/SourceBufferPrivate.h: >+ (WebCore::SourceBufferPrivate::setActive): >+ (WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted. >+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: >+ (WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted. >+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: >+ > 2018-12-14 Simon Fraser <simon.fraser@apple.com> > > REGRESSION (r233268): contents of an animated element inside overflow:hidden disappear >diff --git a/Source/WebCore/platform/graphics/SourceBufferPrivate.h b/Source/WebCore/platform/graphics/SourceBufferPrivate.h >index b267e55a40430b73a14fe46827b08a36e82286d2..3e1683f2f35c4a18a2324e9bffb803e532943eb6 100644 >--- a/Source/WebCore/platform/graphics/SourceBufferPrivate.h >+++ b/Source/WebCore/platform/graphics/SourceBufferPrivate.h >@@ -59,7 +59,6 @@ public: > virtual void allSamplesInTrackEnqueued(const AtomicString&) { } > virtual bool isReadyForMoreSamples(const AtomicString&) { return false; } > virtual void setActive(bool) { } >- virtual void stopAskingForMoreSamples(const AtomicString&) { } > virtual void notifyClientWhenReadyForMoreSamples(const AtomicString&) { } > > virtual Vector<String> enqueuedSamplesForTrackID(const AtomicString&) { return { }; } >diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp >index fa4f5616cd0144aca01adfcefd374ebdea577d80..4290edcc6ba788baa14c4e05870342bc6517ce01 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp >+++ b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp >@@ -148,11 +148,6 @@ void SourceBufferPrivateGStreamer::setActive(bool isActive) > m_mediaSource->sourceBufferPrivateDidChangeActiveState(this, isActive); > } > >-void SourceBufferPrivateGStreamer::stopAskingForMoreSamples(const AtomicString&) >-{ >- notImplemented(); >-} >- > void SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples(const AtomicString& trackId) > { > ASSERT(WTF::isMainThread()); >diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >index 18f1abd6d116871a6c4a82116a23b637c82e907d..ead1ac47ba346df41e1488212874ae96d2642edf 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >+++ b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >@@ -67,7 +67,6 @@ public: > void allSamplesInTrackEnqueued(const AtomicString&) final; > bool isReadyForMoreSamples(const AtomicString&) final; > void setActive(bool) final; >- void stopAskingForMoreSamples(const AtomicString&) final; > void notifyClientWhenReadyForMoreSamples(const AtomicString&) final; > > void setReadyForMoreSamples(bool);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192754
: 357437