Attachment 357408 Details for Bug 192744 – Patch

[patch] Patch

bug-192744-20181215155054.patch (text/plain), 1.68 KB, created by Alex Christensen on 2018-12-15 15:50:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-12-15 15:50:55 PST

Size: 1.68 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 239253)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-12-15  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame
>+        https://bugs.webkit.org/show_bug.cgi?id=192744
>+        <rdar://problem/45842668>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
>+        Things happen.  Navigations can be null.  If they are, we shouldn't dereference pointers to them.
>+
> 2018-12-14  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, fix the build with recent SDKs.
>Index: Source/WebKit/UIProcess/WebPageProxy.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebPageProxy.cpp	(revision 239222)
>+++ Source/WebKit/UIProcess/WebPageProxy.cpp	(working copy)
>@@ -3772,11 +3772,9 @@ void WebPageProxy::didReceiveServerRedir
>     MESSAGE_CHECK_URL(request.url());
> 
>     // FIXME: We should message check that navigationID is not zero here, but it's currently zero for some navigations through the page cache.
>-    RefPtr<API::Navigation> navigation;
>-    if (navigationID) {
>-        navigation = navigationState().navigation(navigationID);
>+    RefPtr<API::Navigation> navigation = navigationID ? navigationState().navigation(navigationID) : nullptr;
>+    if (navigation)
>         navigation->appendRedirectionURL(request.url());
>-    }
> 
>     auto transaction = m_pageLoadState.transaction();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192744: 357408