Attachment 357337 Details for Bug 192716 – Patch

[patch] Patch

bug-192716-20181214133647.patch (text/plain), 2.32 KB, created by youenn fablet on 2018-12-14 13:36:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-12-14 13:36:41 PST

Size: 2.32 KB

patch

obsolete

>Subversion Revision: 239205
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog
>index 75accfafdab88a038d109cc70c710fc71a5ccff1..a0975277b424276c0e6d1ab82269fb5e48945052 100644
>--- a/Source/ThirdParty/libwebrtc/ChangeLog
>+++ b/Source/ThirdParty/libwebrtc/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-14  Youenn Fablet  <youenn@apple.com>
>+
>+        kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=192716
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.
>+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
>+        (-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
>+
> 2018-12-14  Youenn Fablet  <youenn@apple.com>
> 
>         Set kVTVideoEncoderSpecification_Usage both when creating the compression session and once created
>diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
>index f82022604d4121c065f9fcae88476670c2351f9d..baec714a2963a11bddd48b0b87927d6682fbd1a8 100644
>--- a/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
>+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
>@@ -618,13 +618,13 @@ - (int)resetCompressionSessionWithPixelFormat:(OSType)framePixelFormat {
> #endif
>   CFDictionarySetValue(encoderSpecs, kVTCompressionPropertyKey_RealTime, kCFBooleanTrue);
> 
>-  if (auto key = getkVTVideoEncoderSpecification_Usage()) {
>-    int usageValue = 1;
>-    auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
>-    CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
>-    CFRelease(usage);
>-  }
>-
>+#if ENABLE_VCP_ENCODER
>+  auto key = getkVTVideoEncoderSpecification_Usage();
>+  int usageValue = 1;
>+  auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
>+  CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
>+  CFRelease(usage);
>+#endif
>   OSStatus status =
>       CompressionSessionCreate(nullptr,  // use default allocator
>                                  _width,

Actions: View | Formatted Diff | Diff

Attachments on bug 192716: 357337 | 357348