Attachment 357332 Details for Bug 192710 – Patch v1

[patch] Patch v1

bug-192710-20181214125807.patch (text/plain), 2.47 KB, created by David Kilzer (:ddkilzer) on 2018-12-14 12:58:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-12-14 12:58:07 PST

Size: 2.47 KB

patch

obsolete

>Subversion Revision: 239112
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index c0dcab5ed329c89dec40bcf311aa9af916a14a9f..c6721b159da817e1dfe81e0c396c10c9ea0b9224 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-14  David Kilzer  <ddkilzer@apple.com>
>+
>+        clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
>+        <https://webkit.org/b/192710>
>+        <rdar://problem/46738962>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Logger.h:
>+        (WTF::LogArgument::toString): Make argument a const reference to
>+        avoid the copy.
>+
> 2018-12-13  David Kilzer  <ddkilzer@apple.com>
> 
>         clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
>diff --git a/Source/WTF/wtf/Logger.h b/Source/WTF/wtf/Logger.h
>index 8f6e4d36f78cd814d7cdbe12fd15e2db44788c26..a8883e837e4ab2dc31b77315a36ff2278ff2d75c 100644
>--- a/Source/WTF/wtf/Logger.h
>+++ b/Source/WTF/wtf/Logger.h
>@@ -44,7 +44,7 @@ struct LogArgument {
>     template<typename U = T> static typename std::enable_if<std::is_same<U, long>::value, String>::type toString(long argument) { return String::number(argument); }
>     template<typename U = T> static typename std::enable_if<std::is_same<U, float>::value, String>::type toString(float argument) { return String::number(argument); }
>     template<typename U = T> static typename std::enable_if<std::is_same<U, double>::value, String>::type toString(double argument) { return String::number(argument); }
>-    template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(AtomicString argument) { return argument.string(); }
>+    template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(const AtomicString& argument) { return argument.string(); }
>     template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, String>::value, String>::type toString(String argument) { return argument; }
>     template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, StringBuilder*>::value, String>::type toString(StringBuilder* argument) { return argument->toString(); }
>     template<typename U = T> static typename std::enable_if<std::is_same<U, const char*>::value, String>::type toString(const char* argument) { return String(argument); }

Actions: View | Formatted Diff | Diff

Attachments on bug 192710: 357332