Attachment 357306 Details for Bug 183288 – Patch

[patch] Patch

bug-183288-20181214092129.patch (text/plain), 1.63 KB, created by Dominik Inführ on 2018-12-14 00:21:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-12-14 00:21:30 PST

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 239200
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9bd2412351e066bfba231f559cb5659773018316..44ae2f0c517a2159b93f160721fa3dd8ce447739 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-14  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        offlineasm: Use temporary file for generating assembly code
>+        https://bugs.webkit.org/show_bug.cgi?id=183288
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If offlineasm crashes, it leaves a broken file behind. Let offlineasm
>+        first write into a temporary file. When offlineasm finishes successfully
>+        copy the temporary file into the specified target file. This workaround
>+        prevents the build system from continuing with a broken file.
>+
>+        * offlineasm/asm.rb:
>+
> 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
>diff --git a/Source/JavaScriptCore/offlineasm/asm.rb b/Source/JavaScriptCore/offlineasm/asm.rb
>index ecf14cbb3ff2b27572d31d7c19ee9f0f95961a0d..0a8e5c69703808f5b496e32a82867f9631e11485 100644
>--- a/Source/JavaScriptCore/offlineasm/asm.rb
>+++ b/Source/JavaScriptCore/offlineasm/asm.rb
>@@ -373,7 +373,9 @@ if FileTest.exist? outputFlnm
>     }
> end
> 
>-File.open(outputFlnm, "w") {
>+tempOutputFlnm = "#{outputFlnm}.temp"
>+
>+File.open(tempOutputFlnm, "w") {
>     | outp |
>     $output = outp
>     $output.puts inputHash
>@@ -409,3 +411,5 @@ File.open(outputFlnm, "w") {
>         }
>     }
> }
>+
>+File.rename(tempOutputFlnm, outputFlnm)

Actions: View | Formatted Diff | Diff

Attachments on bug 183288: 334897 | 334988 | 357306