Attachment 357271 Details for Bug 192686 – proposed patch.

[patch] proposed patch.

bug-192686.patch (text/plain), 47.06 KB, created by Mark Lam on 2018-12-13 16:49:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-12-13 16:49:52 PST

Size: 47.06 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 239187)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,39 @@
>+2018-12-13  Mark Lam  <mark.lam@apple.com>
>+
>+        Ensure that StructureFlags initialization always starts with Base::StructureFlags.
>+        https://bugs.webkit.org/show_bug.cgi?id=192686
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is purely a refactoring effort to make the code consistently start all
>+        StructureFlags initialization with Base::StructureFlags.  Previously, sometimes
>+        Base::StructureFlags is appended at the end, and sometimes, it is expressed using
>+        the name of the superclass.  This patch makes the code all consistent and easier
>+        to do a quick eye scan audit on to verify that no StructureFlags are forgetting
>+        to inherit Base::StructureFlags.
>+
>+        Also added a static_assert in JSCallbackObject.h and JSBoundFunction.h.  Both of
>+        these implement a customHasInstance() method, and rely on ImplementsHasInstance
>+        being included in the StructureFlags, and conversely, ImplementsDefaultHasInstance
>+        has to be excluded.
>+
>+        JSBoundFunction.h is the only case where a bit (ImplementsDefaultHasInstance)
>+        needs to be masked out of the inherited Base::StructureFlags.
>+
>+        * API/JSCallbackObject.h:
>+        * runtime/ArrayConstructor.h:
>+        * runtime/ArrayIteratorPrototype.h:
>+        * runtime/Exception.h:
>+        * runtime/FunctionRareData.h:
>+        * runtime/InferredType.h:
>+        * runtime/InferredTypeTable.h:
>+        * runtime/InferredValue.h:
>+        * runtime/JSBoundFunction.h:
>+        * runtime/MapPrototype.h:
>+        * runtime/SetPrototype.h:
>+        * runtime/StringPrototype.h:
>+        * runtime/SymbolConstructor.h:
>+
> 2018-12-13  David Kilzer  <ddkilzer@apple.com>
> 
>         clang-tidy: Fix unnecessary object copies in JavaScriptCore
>Index: Source/JavaScriptCore/API/JSCallbackObject.h
>===================================================================
>--- Source/JavaScriptCore/API/JSCallbackObject.h	(revision 239079)
>+++ Source/JavaScriptCore/API/JSCallbackObject.h	(working copy)
>@@ -135,6 +135,7 @@ protected:
> public:
>     typedef Parent Base;
>     static const unsigned StructureFlags = Base::StructureFlags | ProhibitsPropertyCaching | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | ImplementsHasInstance | OverridesGetPropertyNames | OverridesGetCallData;
>+    static_assert(!(StructureFlags & ImplementsDefaultHasInstance), "using customHasInstance");
> 
>     ~JSCallbackObject();
> 
>Index: Source/JavaScriptCore/runtime/ArrayConstructor.h
>===================================================================
>--- Source/JavaScriptCore/runtime/ArrayConstructor.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/ArrayConstructor.h	(working copy)
>@@ -33,7 +33,7 @@ class GetterSetter;
> class ArrayConstructor final : public InternalFunction {
> public:
>     typedef InternalFunction Base;
>-    static const unsigned StructureFlags = HasStaticPropertyTable | InternalFunction::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static ArrayConstructor* create(VM& vm, JSGlobalObject* globalObject, Structure* structure, ArrayPrototype* arrayPrototype, GetterSetter* speciesSymbol)
>     {
>Index: Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h
>===================================================================
>--- Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h	(working copy)
>@@ -32,7 +32,7 @@ namespace JSC {
> class ArrayIteratorPrototype final : public JSNonFinalObject {
> public:
>     typedef JSNonFinalObject Base;
>-    static const unsigned StructureFlags = HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static ArrayIteratorPrototype* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
>     {
>Index: Source/JavaScriptCore/runtime/Exception.h
>===================================================================
>--- Source/JavaScriptCore/runtime/Exception.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/Exception.h	(working copy)
>@@ -34,7 +34,7 @@ namespace JSC {
> class Exception final : public JSDestructibleObject {
> public:
>     typedef JSDestructibleObject Base;
>-    static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
> 
>     enum StackCaptureAction {
>         CaptureStack,
>Index: Source/JavaScriptCore/runtime/FunctionRareData.h
>===================================================================
>--- Source/JavaScriptCore/runtime/FunctionRareData.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/FunctionRareData.h	(working copy)
>@@ -47,7 +47,7 @@ class FunctionRareData final : public JS
>     
> public:
>     typedef JSCell Base;
>-    static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
> 
>     static FunctionRareData* create(VM&);
> 
>Index: Source/JavaScriptCore/runtime/InferredType.h
>===================================================================
>--- Source/JavaScriptCore/runtime/InferredType.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/InferredType.h	(working copy)
>@@ -53,7 +53,7 @@ public:
>     static const bool needsDestruction = true;
>     static void destroy(JSCell*);
> 
>-    static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
>     
>     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
> 
>Index: Source/JavaScriptCore/runtime/InferredTypeTable.h
>===================================================================
>--- Source/JavaScriptCore/runtime/InferredTypeTable.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/InferredTypeTable.h	(working copy)
>@@ -47,7 +47,7 @@ public:
>     static const bool needsDestruction = true;
>     static void destroy(JSCell*);
> 
>-    static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
>     
>     static Structure* createStructure(VM&, JSGlobalObject*, JSValue prototype);
> 
>Index: Source/JavaScriptCore/runtime/InferredValue.h
>===================================================================
>--- Source/JavaScriptCore/runtime/InferredValue.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/InferredValue.h	(working copy)
>@@ -101,7 +101,7 @@ public:
>         m_set.invalidate(vm, detail);
>     }
>     
>-    static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
>     
>     void finalizeUnconditionally(VM&);
>     
>Index: Source/JavaScriptCore/runtime/JSBoundFunction.h
>===================================================================
>--- Source/JavaScriptCore/runtime/JSBoundFunction.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/JSBoundFunction.h	(working copy)
>@@ -39,7 +39,8 @@ EncodedJSValue JSC_HOST_CALL hasInstance
> class JSBoundFunction final : public JSFunction {
> public:
>     typedef JSFunction Base;
>-    const static unsigned StructureFlags = ~ImplementsDefaultHasInstance & Base::StructureFlags;
>+    const static unsigned StructureFlags = Base::StructureFlags & ~ImplementsDefaultHasInstance;
>+    static_assert(StructureFlags & ImplementsHasInstance, "");
> 
>     template<typename CellType>
>     static IsoSubspace* subspaceFor(VM& vm)
>Index: Source/JavaScriptCore/runtime/MapPrototype.h
>===================================================================
>--- Source/JavaScriptCore/runtime/MapPrototype.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/MapPrototype.h	(working copy)
>@@ -33,7 +33,7 @@ class MapPrototype final : public JSNonF
> public:
>     typedef JSNonFinalObject Base;
> 
>-    static const unsigned StructureFlags = HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static MapPrototype* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
>     {
>Index: Source/JavaScriptCore/runtime/SetPrototype.h
>===================================================================
>--- Source/JavaScriptCore/runtime/SetPrototype.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/SetPrototype.h	(working copy)
>@@ -33,7 +33,7 @@ class SetPrototype final : public JSNonF
> public:
>     typedef JSNonFinalObject Base;
> 
>-    static const unsigned StructureFlags = HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static SetPrototype* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
>     {
>Index: Source/JavaScriptCore/runtime/StringPrototype.h
>===================================================================
>--- Source/JavaScriptCore/runtime/StringPrototype.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/StringPrototype.h	(working copy)
>@@ -35,7 +35,7 @@ private:
> 
> public:
>     typedef StringObject Base;
>-    static const unsigned StructureFlags = HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static StringPrototype* create(VM&, JSGlobalObject*, Structure*);
> 
>Index: Source/JavaScriptCore/runtime/SymbolConstructor.h
>===================================================================
>--- Source/JavaScriptCore/runtime/SymbolConstructor.h	(revision 239079)
>+++ Source/JavaScriptCore/runtime/SymbolConstructor.h	(working copy)
>@@ -36,7 +36,7 @@ class GetterSetter;
> class SymbolConstructor final : public InternalFunction {
> public:
>     typedef InternalFunction Base;
>-    static const unsigned StructureFlags = HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | HasStaticPropertyTable;
> 
>     static SymbolConstructor* create(VM& vm, Structure* structure, SymbolPrototype* prototype, GetterSetter*)
>     {
>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 239079)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,46 @@
>+2018-12-13  Mark Lam  <mark.lam@apple.com>
>+
>+        Ensure that StructureFlags initialization always starts with Base::StructureFlags.
>+        https://bugs.webkit.org/show_bug.cgi?id=192686
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests needed because there's no new functionality.  Just refactoring.
>+
>+        * bindings/js/JSDOMWindowProperties.h:
>+        * bindings/scripts/CodeGeneratorJS.pm:
>+        (GenerateHeader):
>+        (GeneratePrototypeDeclaration):
>+        * bindings/scripts/test/JS/JSTestActiveDOMObject.h:
>+        * bindings/scripts/test/JS/JSTestEnabledBySetting.h:
>+        * bindings/scripts/test/JS/JSTestEventTarget.h:
>+        * bindings/scripts/test/JS/JSTestGlobalObject.h:
>+        * bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:
>+        * bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
>+        * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
>+        * bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
>+        * bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:
>+        * bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
>+        * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
>+        * bindings/scripts/test/JS/JSTestObj.h:
>+        * bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
>+        * bindings/scripts/test/JS/JSTestPluginInterface.h:
>+        * bindings/scripts/test/JS/JSTestTypedefs.h:
>+
> 2018-12-11  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: overlay bounds rulers don't match element when page is scrolled
>Index: Source/WebCore/bindings/js/JSDOMWindowProperties.h
>===================================================================
>--- Source/WebCore/bindings/js/JSDOMWindowProperties.h	(revision 239079)
>+++ Source/WebCore/bindings/js/JSDOMWindowProperties.h	(working copy)
>@@ -49,7 +49,7 @@ public:
>     static bool getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&);
>     static bool getOwnPropertySlotByIndex(JSC::JSObject*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);
> 
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::IsImmutablePrototypeExoticObject | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::IsImmutablePrototypeExoticObject;
> 
> protected:
>     JSDOMWindowProperties(JSC::Structure* structure, JSC::JSGlobalObject& globalObject)
>Index: Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
>===================================================================
>--- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	(revision 239079)
>+++ Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	(working copy)
>@@ -2835,11 +2835,11 @@ sub GenerateHeader
>     # structure flags
>     if (%structureFlags) {
>         push(@headerContent, "public:\n");
>-        push(@headerContent, "    static const unsigned StructureFlags = ");
>+        push(@headerContent, "    static const unsigned StructureFlags = Base::StructureFlags");
>         foreach my $structureFlag (sort (keys %structureFlags)) {
>-            push(@headerContent, $structureFlag . " | ");
>+            push(@headerContent, " | " . $structureFlag);
>         }
>-        push(@headerContent, "Base::StructureFlags;\n");
>+        push(@headerContent, ";\n");
>     }
> 
>     push(@headerContent, "protected:\n");
>@@ -7046,11 +7046,11 @@ sub GeneratePrototypeDeclaration
>     # structure flags
>     if (%structureFlags) {
>         push(@$outputArray, "public:\n");
>-        push(@$outputArray, "    static const unsigned StructureFlags = ");
>+        push(@$outputArray, "    static const unsigned StructureFlags = Base::StructureFlags");
>         foreach my $structureFlag (sort (keys %structureFlags)) {
>-            push(@$outputArray, $structureFlag . " | ");
>+            push(@$outputArray, " | " . $structureFlag);
>         }
>-        push(@$outputArray, "Base::StructureFlags;\n");
>+        push(@$outputArray, ";\n");
>     }
> 
>     push(@$outputArray, "};\n\n");
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h	(working copy)
>@@ -51,7 +51,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable;
> protected:
>     JSTestActiveDOMObject(JSC::Structure*, JSDOMGlobalObject&, Ref<TestActiveDOMObject>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.h	(working copy)
>@@ -51,7 +51,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable;
> protected:
>     JSTestEnabledBySetting(JSC::Structure*, JSDOMGlobalObject&, Ref<TestEnabledBySetting>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h	(working copy)
>@@ -59,7 +59,7 @@ public:
>         return static_cast<TestEventTarget&>(Base::wrapped());
>     }
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::MasqueradesAsUndefined | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::MasqueradesAsUndefined | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestEventTarget(JSC::Structure*, JSDOMGlobalObject&, Ref<TestEventTarget>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h	(working copy)
>@@ -53,7 +53,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable;
> protected:
>     JSTestGlobalObject(JSC::Structure*, JSDOMGlobalObject&, Ref<TestGlobalObject>&&);
> 
>@@ -104,7 +104,7 @@ private:
>     {
>     }
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable;
> };
> 
> template<> struct JSDOMWrapperConverterTraits<TestGlobalObject> {
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestIndexedSetterNoIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestIndexedSetterNoIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestIndexedSetterThrowingException(JSC::Structure*, JSDOMGlobalObject&, Ref<TestIndexedSetterThrowingException>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestIndexedSetterWithIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestIndexedSetterWithIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedAndIndexedSetterNoIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedAndIndexedSetterNoIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedAndIndexedSetterThrowingException(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedAndIndexedSetterThrowingException>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedAndIndexedSetterWithIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedAndIndexedSetterWithIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h	(working copy)
>@@ -56,7 +56,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedDeleterNoIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedDeleterNoIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h	(working copy)
>@@ -56,7 +56,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedDeleterThrowingException(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedDeleterThrowingException>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h	(working copy)
>@@ -56,7 +56,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedDeleterWithIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedDeleterWithIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h	(working copy)
>@@ -56,7 +56,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedDeleterWithIndexedGetter(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedDeleterWithIndexedGetter>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.h	(working copy)
>@@ -54,7 +54,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedGetterCallWith(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedGetterCallWith>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h	(working copy)
>@@ -54,7 +54,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedGetterNoIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedGetterNoIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h	(working copy)
>@@ -54,7 +54,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedGetterWithIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedGetterWithIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterNoIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterNoIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterThrowingException(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterThrowingException>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithIdentifier(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithIdentifier>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithIndexedGetter(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithIndexedGetter>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithIndexedGetterAndSetter(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithIndexedGetterAndSetter>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpure | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpure | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithOverrideBuiltins(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithOverrideBuiltins>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpureForPropertyAbsence | JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithUnforgableProperties(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithUnforgableProperties>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h	(working copy)
>@@ -57,7 +57,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpure | JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpure | JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins(JSC::Structure*, JSDOMGlobalObject&, Ref<TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	(working copy)
>@@ -76,7 +76,7 @@ public:
>     static JSC::JSValue testStaticCustomPromiseFunction(JSC::ExecState&, Ref<DeferredPromise>&&);
>     JSC::JSValue testCustomReturnsOwnPromiseFunction(JSC::ExecState&);
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetCallData | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetCallData | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestObj(JSC::Structure*, JSDOMGlobalObject&, Ref<TestObj>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.h	(working copy)
>@@ -54,7 +54,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::GetOwnPropertySlotIsImpure | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::GetOwnPropertySlotIsImpure | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | JSC::OverridesGetPropertyNames;
> protected:
>     JSTestOverrideBuiltins(JSC::Structure*, JSDOMGlobalObject&, Ref<TestOverrideBuiltins>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.h	(working copy)
>@@ -58,7 +58,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetCallData | JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetCallData | JSC::OverridesGetOwnPropertySlot;
> protected:
>     JSTestPluginInterface(JSC::Structure*, JSDOMGlobalObject&, Ref<TestPluginInterface>&&);
> 
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h	(revision 239079)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h	(working copy)
>@@ -51,7 +51,7 @@ public:
>     static JSC::JSValue getConstructor(JSC::VM&, const JSC::JSGlobalObject*);
>     static void heapSnapshot(JSCell*, JSC::HeapSnapshotBuilder&);
> public:
>-    static const unsigned StructureFlags = JSC::HasStaticPropertyTable | Base::StructureFlags;
>+    static const unsigned StructureFlags = Base::StructureFlags | JSC::HasStaticPropertyTable;
> protected:
>     JSTestTypedefs(JSC::Structure*, JSDOMGlobalObject&, Ref<TestTypedefs>&&);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192686: 357271