Attachment 357262 Details for Bug 192682 – proposed patch.

[patch] proposed patch.

bug-192682.patch (text/plain), 1.71 KB, created by Mark Lam on 2018-12-13 15:08:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-12-13 15:08:49 PST

Size: 1.71 KB

patch

obsolete

>Index: Source/bmalloc/ChangeLog
>===================================================================
>--- Source/bmalloc/ChangeLog	(revision 239180)
>+++ Source/bmalloc/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-12-13  Mark Lam  <mark.lam@apple.com>
>+
>+        Verify that tryLargeZeroedMemalignVirtual()'s aligned size and alignment values are valid.
>+        https://bugs.webkit.org/show_bug.cgi?id=192682
>+        <rdar://problem/37751522>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * bmalloc/bmalloc.cpp:
>+        (bmalloc::api::tryLargeZeroedMemalignVirtual):
>+
> 2018-11-21  Dominik Infuehr  <dinfuehr@igalia.com>
> 
>         Enable JIT on ARM/Linux
>Index: Source/bmalloc/bmalloc/bmalloc.cpp
>===================================================================
>--- Source/bmalloc/bmalloc/bmalloc.cpp	(revision 239079)
>+++ Source/bmalloc/bmalloc/bmalloc.cpp	(working copy)
>@@ -39,13 +39,15 @@ void freeOutOfLine(void* object, HeapKin
>     free(object, kind);
> }
> 
>-void* tryLargeZeroedMemalignVirtual(size_t alignment, size_t size, HeapKind kind)
>+void* tryLargeZeroedMemalignVirtual(size_t requiredAlignment, size_t requestedSize, HeapKind kind)
> {
>-    BASSERT(isPowerOfTwo(alignment));
>+    RELEASE_BASSERT(isPowerOfTwo(requiredAlignment));
> 
>     size_t pageSize = vmPageSize();
>-    alignment = roundUpToMultipleOf(pageSize, alignment);
>-    size = roundUpToMultipleOf(pageSize, size);
>+    size_t alignment = roundUpToMultipleOf(pageSize, requiredAlignment);
>+    size_t size = roundUpToMultipleOf(pageSize, requestedSize);
>+    RELEASE_BASSERT(alignment >= requiredAlignment);
>+    RELEASE_BASSERT(size >= requestedSize);
> 
>     kind = mapToActiveHeapKind(kind);
>     Heap& heap = PerProcess<PerHeapKind<Heap>>::get()->at(kind);

Actions: View | Formatted Diff | Diff

Attachments on bug 192682: 357262