Attachment 357246 Details for Bug 192674 – Patch

[patch] Patch

bug-192674-20181213130223.patch (text/plain), 1.80 KB, created by Jer Noble on 2018-12-13 13:02:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-12-13 13:02:23 PST

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 238907
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 18d2418fd2b8668dc9df432171a753b27481144b..fbd64e45e3fb9d3330689a443d9ff7bd659d4f07 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-13  Jer Noble  <jer.noble@apple.com>
>+
>+        Fix leak of AVPlayer boundaryTimeObserver object.
>+        https://bugs.webkit.org/show_bug.cgi?id=192674
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
>+        (WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):
>+
> 2018-12-11  Jer Noble  <jer.noble@apple.com>
> 
>         Globally namespaced objects shouldn't use framework-prefixed names
>diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>index 2a0560b43843bfe54dbee723a1154b8cc89bede9..75c48e526d813876cf72940af3c71a4066cc9674 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>@@ -3301,7 +3301,10 @@ bool MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime(WTF::Function<vo
> 
>     __block WTF::Function<void()> taskIn = WTFMove(task);
> 
>-    [m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
>+    if (m_timeObserver)
>+        [m_avPlayer removeTimeObserver:m_timeObserver.get()];
>+
>+    m_timeObserver = [m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
>         taskIn();
>     }];
>     return true;

Actions: View | Formatted Diff | Diff

Attachments on bug 192674: 357246