Attachment 357234 Details for Bug 192632 – Follow up fix

[patch] Follow up fix

bug-192632-20181213085611.patch (text/plain), 1.57 KB, created by Eric Carlson on 2018-12-13 08:56:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-12-13 08:56:11 PST

Size: 1.57 KB

patch

obsolete

>Subversion Revision: 239163
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 203064a3760256fc925c9e3198fee35c9f4272d2..69355fb970d2f1dd02c872f120b8dafc9984291f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-13  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [MediaStream] Calculate width or height when constraints contain only the other
>+        https://bugs.webkit.org/show_bug.cgi?id=192632
>+        <rdar://problem/46665734>
>+
>+        Unreviewed, remove an unneeded assert.
>+
>+        * platform/mediastream/RealtimeVideoSource.cpp:
>+        (WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers):
>+
> 2018-12-13  Eric Carlson  <eric.carlson@apple.com>
> 
>         [MediaStream] Calculate width or height when constraints contain only the other
>diff --git a/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp b/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
>index 3028ca4a8ce0b81adea92dcfa8c3ba499dfbbf1d..90ac7dc6b609a309ce016a398f727249ee57990b 100644
>--- a/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
>+++ b/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
>@@ -392,7 +392,6 @@ void RealtimeVideoSource::dispatchMediaSampleToObservers(MediaSample& sample)
> #if PLATFORM(COCOA)
>     if (!isRemote()) {
>         auto size = this->size();
>-        ASSERT(!size.isEmpty());
>         if (!size.isEmpty() && size != expandedIntSize(sample.presentationSize())) {
> 
>             if (!m_imageTransferSession || m_imageTransferSession->pixelFormat() != sample.videoPixelFormat())

Actions: View | Formatted Diff | Diff

Attachments on bug 192632: 357150 | 357157 | 357159 | 357174 | 357228 | 357234