Attachment 357233 Details for Bug 192666 – Patch v1

[patch] Patch v1

bug-192666-20181213084641.patch (text/plain), 4.11 KB, created by David Kilzer (:ddkilzer) on 2018-12-13 08:46:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-12-13 08:46:41 PST

Size: 4.11 KB

patch

obsolete

>Subversion Revision: 239112
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index cd73df0b2f8a44997c43c3de5a920a13d9bddaa3..91a67828e6ab5aad58defbe9047a05599684e60b 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-12-13  David Kilzer  <ddkilzer@apple.com>
>+
>+        clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
>+        <https://webkit.org/b/192666>
>+        <rdar://problem/46697952>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/ParallelHelperPool.cpp:
>+        (WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
>+        reference and WTFMove().
>+        (WTF::ParallelHelperClient::setTask): Ditto.
>+        (WTF::ParallelHelperClient::runTaskInParallel): Use rvalue
>+        reference to pass the parameter to setTask().
>+        (WTF::ParallelHelperClient::runTask): Use const reference.
>+        * wtf/ParallelHelperPool.h: Update declarations to match
>+        implementations.
>+
> 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [Win][Clang] Fix compilation warnings of WTF
>diff --git a/Source/WTF/wtf/ParallelHelperPool.cpp b/Source/WTF/wtf/ParallelHelperPool.cpp
>index 006e468d900c3c7b7c903cc5cb3fcd1c2b24a4f4..03484e598f40104212dd3833e50539da53b73a1e 100644
>--- a/Source/WTF/wtf/ParallelHelperPool.cpp
>+++ b/Source/WTF/wtf/ParallelHelperPool.cpp
>@@ -32,8 +32,8 @@
> 
> namespace WTF {
> 
>-ParallelHelperClient::ParallelHelperClient(RefPtr<ParallelHelperPool> pool)
>-    : m_pool(pool)
>+ParallelHelperClient::ParallelHelperClient(RefPtr<ParallelHelperPool>&& pool)
>+    : m_pool(WTFMove(pool))
> {
>     LockHolder locker(*m_pool->m_lock);
>     RELEASE_ASSERT(!m_pool->m_isDying);
>@@ -54,11 +54,11 @@ ParallelHelperClient::~ParallelHelperClient()
>     }
> }
> 
>-void ParallelHelperClient::setTask(RefPtr<SharedTask<void ()>> task)
>+void ParallelHelperClient::setTask(RefPtr<SharedTask<void ()>>&& task)
> {
>     LockHolder locker(*m_pool->m_lock);
>     RELEASE_ASSERT(!m_task);
>-    m_task = task;
>+    m_task = WTFMove(task);
>     m_pool->didMakeWorkAvailable(locker);
> }
> 
>@@ -81,7 +81,7 @@ void ParallelHelperClient::doSomeHelping()
>     runTask(task);
> }
> 
>-void ParallelHelperClient::runTaskInParallel(RefPtr<SharedTask<void ()>> task)
>+void ParallelHelperClient::runTaskInParallel(RefPtr<SharedTask<void ()>>&& task)
> {
>     setTask(task);
>     doSomeHelping();
>@@ -104,7 +104,7 @@ RefPtr<SharedTask<void ()>> ParallelHelperClient::claimTask(const AbstractLocker
>     return m_task;
> }
> 
>-void ParallelHelperClient::runTask(RefPtr<SharedTask<void ()>> task)
>+void ParallelHelperClient::runTask(const RefPtr<SharedTask<void ()>>& task)
> {
>     RELEASE_ASSERT(m_numActive);
>     RELEASE_ASSERT(task);
>diff --git a/Source/WTF/wtf/ParallelHelperPool.h b/Source/WTF/wtf/ParallelHelperPool.h
>index 77780f85b0a5af142fefdd5199888221e6c87fd6..1e7599c83d67121c7e6bfe87cca91ef6ce86e407 100644
>--- a/Source/WTF/wtf/ParallelHelperPool.h
>+++ b/Source/WTF/wtf/ParallelHelperPool.h
>@@ -131,10 +131,10 @@ class ParallelHelperClient {
>     WTF_MAKE_NONCOPYABLE(ParallelHelperClient);
>     WTF_MAKE_FAST_ALLOCATED;
> public:
>-    WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr<ParallelHelperPool>);
>+    WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr<ParallelHelperPool>&&);
>     WTF_EXPORT_PRIVATE ~ParallelHelperClient();
> 
>-    WTF_EXPORT_PRIVATE void setTask(RefPtr<SharedTask<void ()>>);
>+    WTF_EXPORT_PRIVATE void setTask(RefPtr<SharedTask<void ()>>&&);
> 
>     template<typename Functor>
>     void setFunction(const Functor& functor)
>@@ -150,7 +150,7 @@ public:
>     // client->setTask(task);
>     // client->doSomeHelping();
>     // client->finish();
>-    WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr<SharedTask<void ()>>);
>+    WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr<SharedTask<void ()>>&&);
> 
>     // Equivalent to:
>     // client->setFunction(functor);
>@@ -170,7 +170,7 @@ private:
> 
>     void finish(const AbstractLocker&);
>     RefPtr<SharedTask<void ()>> claimTask(const AbstractLocker&);
>-    void runTask(RefPtr<SharedTask<void ()>>);
>+    void runTask(const RefPtr<SharedTask<void ()>>&);
>     
>     RefPtr<ParallelHelperPool> m_pool;
>     RefPtr<SharedTask<void ()>> m_task;

Actions: View | Formatted Diff | Diff

Attachments on bug 192666: 357233 | 357235