Attachment 357188 Details for Bug 192645 – Patch

[patch] Patch

bug-192645-20181212161541.patch (text/plain), 4.07 KB, created by Devin Rousso on 2018-12-12 16:15:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-12 16:15:42 PST

Size: 4.07 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 183e7ff832d5336d5233b2490a732875cf557e71..4f5f439b9d09c3c578052820afba173303381021 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-12  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: experimental settings reload button disappears after changing more than one setting
>+        https://bugs.webkit.org/show_bug.cgi?id=192645
>+        <rdar://problem/46626204>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView.listenForChange):
>+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
>+
> 2018-12-10  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION (r238599): unable to select specific timeline
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 8a740216ab38d0477f52d788fa35eafb9d23a4c6..e4d56f2fc7d8756ccf150d7397fd41117a5a8331 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -242,19 +242,19 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
> 
>         let experimentalSettingsView = new WI.SettingsView("experimental", WI.UIString("Experimental"));
> 
>+        let initialValues = new Map;
>+
>         if (window.CSSAgent) {
>             let group = experimentalSettingsView.addGroup(WI.UIString("Styles Sidebar:"));
>             group.addSetting(WI.settings.experimentalEnableComputedStyleCascades, WI.UIString("Enable Computed Style Cascades"));
>             experimentalSettingsView.addSeparator();
>         }
> 
>-        let layerTabEnabled = window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value;
>         if (window.LayerTreeAgent) {
>             experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
>             experimentalSettingsView.addSeparator();
>         }
> 
>-        let auditTabEnabled = WI.settings.experimentalEnableAuditTab.value;
>         experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab"));
>         experimentalSettingsView.addSeparator();
> 
>@@ -266,9 +266,9 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
>         reloadInspectorButton.addEventListener("click", (event) => {
>             // Force a copy so that WI.Setting sees it as a new value.
>             let newTabs = WI._openTabsSetting.value.slice();
>-            if (!layerTabEnabled && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
>+            if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
>                 newTabs.push(WI.LayersTabContentView.Type);
>-            if (!auditTabEnabled && WI.settings.experimentalEnableAuditTab.value)
>+            if (!initialValues.get(WI.settings.experimentalEnableAuditTab) && WI.settings.experimentalEnableAuditTab.value)
>                 newTabs.push(WI.AuditTabContentView.Type);
>             WI._openTabsSetting.value = newTabs;
> 
>@@ -279,9 +279,9 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
>         reloadInspectorContainerElement.classList.add("hidden");
> 
>         function listenForChange(setting) {
>-            let initialValue = setting.value;
>+            initialValues.set(setting, setting.value);
>             setting.addEventListener(WI.Setting.Event.Changed, () => {
>-                reloadInspectorContainerElement.classList.toggle("hidden", initialValue === setting.value);
>+                reloadInspectorContainerElement.classList.toggle("hidden", Array.from(initialValues).every(([setting, initialValue]) => setting.value === initialValue));
>             });
>         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192645: 357188