Attachment 357153 Details for Bug 192634 – Patch

[patch] Patch

bug-192634-20181212112600.patch (text/plain), 1.66 KB, created by Daniel Bates on 2018-12-12 11:26:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-12-12 11:26:01 PST

Size: 1.66 KB

patch

obsolete

>Subversion Revision: 239114
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 19a48196b850208acd1879b923b3ccc132729a50..94d428ee1ec9fa2f3026c8bf4d87c87afb33bdf1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-12  Daniel Bates  <dabates@apple.com>
>+
>+        Make DocumentMarker::allMarkers() constexpr
>+        https://bugs.webkit.org/show_bug.cgi?id=192634
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The result of DocumentMarker::allMarkers() can be computed at compile time. We should annotate
>+        it constexpr to do just that.
>+
>+        * dom/DocumentMarker.h:
>+        (WebCore::DocumentMarker::allMarkers):
>+
> 2018-12-12  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
>diff --git a/Source/WebCore/dom/DocumentMarker.h b/Source/WebCore/dom/DocumentMarker.h
>index 994c39c03d6ee8a4f9c0942212bfce5cf1195091..841aa2fc410d9a0ad73b0c9ff41e344021b7664f 100644
>--- a/Source/WebCore/dom/DocumentMarker.h
>+++ b/Source/WebCore/dom/DocumentMarker.h
>@@ -82,7 +82,7 @@ public:
>         DraggedContent = 1 << 14
>     };
> 
>-    static OptionSet<MarkerType> allMarkers();
>+    constexpr static OptionSet<MarkerType> allMarkers();
> 
>     using IsActiveMatchData = bool;
>     using DescriptionData = String;
>@@ -141,9 +141,9 @@ private:
>     Data m_data;
> };
> 
>-inline auto DocumentMarker::allMarkers() -> OptionSet<MarkerType>
>+constexpr auto DocumentMarker::allMarkers() -> OptionSet<MarkerType>
> {
>-    OptionSet<MarkerType> markers {
>+    constexpr OptionSet<MarkerType> markers {
>         AcceptedCandidate,
>         Autocorrected,
>         CorrectionIndicator,

Actions: View | Formatted Diff | Diff

Attachments on bug 192634: 357153 | 357449