Attachment 357113 Details for Bug 192618 – Patch

[patch] Patch

bug-192618-20181212180402.patch (text/plain), 41.31 KB, created by Fujii Hironori on 2018-12-12 01:04:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-12-12 01:04:03 PST

Size: 41.31 KB

patch

obsolete

>Subversion Revision: 239098
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 74894db0f9c523424b12a709793683ce67610b4c..bfbf17be4b6317fe15b1135b421404408d3033ca 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>+        https://bugs.webkit.org/show_bug.cgi?id=192618
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, no behavior changes.
>+
>+        * platform/win/PopupMenuWin.h:
>+        * platform/win/WCDataObject.cpp:
>+        * platform/win/WCDataObject.h:
>+
> 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
> 
>         Implement feature flag for CSS Typed OM
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index ee6523c3ad49680f3b45794db94d86c03051ef15..2e04591df794824deb69d33cfbef61e02b745cca 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,70 @@
>+2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>+        https://bugs.webkit.org/show_bug.cgi?id=192618
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Classes which implement COM interface usually doesn't need the
>+        virtual destructor because it has Release() virtual method to
>+        destruct itself.
>+
>+        Marked 'final' such classes to suppress clang-cl's compilation
>+        warnings.
>+
>+        * COMEnumVariant.h:
>+        * COMPropertyBag.h:
>+        * DefaultDownloadDelegate.h:
>+        * DefaultPolicyDelegate.h:
>+        * MemoryStream.h:
>+        * WebActionPropertyBag.h:
>+        * WebApplicationCache.h:
>+        * WebArchive.h:
>+        * WebBackForwardList.h:
>+        * WebCache.h:
>+        * WebCoreStatistics.h:
>+        * WebCoreSupport/WebEditorClient.cpp:
>+        * WebCoreSupport/WebInspectorDelegate.h:
>+        * WebDataSource.h:
>+        * WebDatabaseManager.cpp:
>+        * WebDatabaseManager.h:
>+        * WebDownload.h:
>+        * WebDropSource.h:
>+        * WebElementPropertyBag.h:
>+        * WebError.h:
>+        * WebFrame.cpp:
>+        * WebFrame.h:
>+        * WebFramePolicyListener.h:
>+        * WebGeolocationPolicyListener.h:
>+        * WebGeolocationPosition.h:
>+        * WebHTMLRepresentation.h:
>+        * WebHistory.h:
>+        * WebHistoryItem.h:
>+        * WebInspector.h:
>+        * WebJavaScriptCollector.h:
>+        * WebKitClassFactory.h:
>+        * WebKitMessageLoop.h:
>+        * WebKitStatistics.h:
>+        * WebMutableURLRequest.h:
>+        * WebNavigationData.h:
>+        * WebNotification.h:
>+        * WebNotificationCenter.h:
>+        * WebPreferences.h:
>+        * WebResource.h:
>+        * WebScriptWorld.h:
>+        * WebSecurityOrigin.h:
>+        * WebSerializedJSValue.h:
>+        * WebTextRenderer.h:
>+        * WebURLAuthenticationChallenge.h:
>+        * WebURLAuthenticationChallengeSender.h:
>+        * WebURLCredential.h:
>+        * WebURLProtectionSpace.h:
>+        * WebURLResponse.h:
>+        * WebUserContentURLPattern.h:
>+        * WebView.cpp:
>+        * WebView.h:
>+        * WebWorkersPrivate.h:
>+
> 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [Win][Clang] Fix warning -Wmissing-field-initializers
>diff --git a/Source/WebCore/platform/win/PopupMenuWin.h b/Source/WebCore/platform/win/PopupMenuWin.h
>index a08176eb57820083406e8f6ec56b4d89e2b6f479..efd8ff86f026ba35e973c4b00725c5b3722bec38 100644
>--- a/Source/WebCore/platform/win/PopupMenuWin.h
>+++ b/Source/WebCore/platform/win/PopupMenuWin.h
>@@ -140,7 +140,7 @@ private:
>     friend class AccessiblePopupMenu;
> };
> 
>-class AccessiblePopupMenu : public IAccessible {
>+class AccessiblePopupMenu final : public IAccessible {
> public:
>     AccessiblePopupMenu(const PopupMenuWin&);
>     ~AccessiblePopupMenu();
>diff --git a/Source/WebCore/platform/win/WCDataObject.cpp b/Source/WebCore/platform/win/WCDataObject.cpp
>index acdcef4628eba831214c1c03ee32937293d8b2b3..dbf99a45ce703a9d857a0e6019d6806dd11fa17b 100644
>--- a/Source/WebCore/platform/win/WCDataObject.cpp
>+++ b/Source/WebCore/platform/win/WCDataObject.cpp
>@@ -32,7 +32,7 @@
> 
> namespace WebCore {
> 
>-class WCEnumFormatEtc : public IEnumFORMATETC
>+class WCEnumFormatEtc final : public IEnumFORMATETC
> {
> public:
>     WCEnumFormatEtc(const Vector<FORMATETC>& formats);
>diff --git a/Source/WebCore/platform/win/WCDataObject.h b/Source/WebCore/platform/win/WCDataObject.h
>index 835ff36df8b0e83ab4960f29be85ebc3a39e9eff..d5e7d63f89e5f26d7b30f9fdcfa67b4d8e91749b 100644
>--- a/Source/WebCore/platform/win/WCDataObject.h
>+++ b/Source/WebCore/platform/win/WCDataObject.h
>@@ -41,7 +41,7 @@ struct StgMediumDeleter {
>     }
> };
> 
>-class WCDataObject : public IDataObject {
>+class WCDataObject final : public IDataObject {
> public:
>     void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
> 
>diff --git a/Source/WebKitLegacy/win/COMEnumVariant.h b/Source/WebKitLegacy/win/COMEnumVariant.h
>index 2fe0f107d45bc5571fb9576cc5acecddc4e7f836..6d978e4b80aba6ee5290d0ae88275a51519da775 100644
>--- a/Source/WebKitLegacy/win/COMEnumVariant.h
>+++ b/Source/WebKitLegacy/win/COMEnumVariant.h
>@@ -31,7 +31,7 @@
> #include "COMVariantSetter.h"
> 
> template<typename ContainerType>
>-class COMEnumVariant : public IEnumVARIANT {
>+class COMEnumVariant final : public IEnumVARIANT {
>     WTF_MAKE_NONCOPYABLE(COMEnumVariant);
> public:
>     static COMEnumVariant* adopt(ContainerType&);
>diff --git a/Source/WebKitLegacy/win/COMPropertyBag.h b/Source/WebKitLegacy/win/COMPropertyBag.h
>index 7181f2b44af8bc67062b50dee9a21811efe90198..b0d21f45eb51cf0f586844a01fbaecd172affc6a 100644
>--- a/Source/WebKitLegacy/win/COMPropertyBag.h
>+++ b/Source/WebKitLegacy/win/COMPropertyBag.h
>@@ -35,7 +35,7 @@
> #include "COMVariantSetter.h"
> 
> template<typename ValueType, typename KeyType = typename WTF::String, typename HashType = typename WTF::StringHash>
>-class COMPropertyBag : public IPropertyBag, public IPropertyBag2 {
>+class COMPropertyBag final : public IPropertyBag, public IPropertyBag2 {
>     WTF_MAKE_NONCOPYABLE(COMPropertyBag);
> public:
>     typedef HashMap<KeyType, ValueType, HashType> HashMapType;
>diff --git a/Source/WebKitLegacy/win/DefaultDownloadDelegate.h b/Source/WebKitLegacy/win/DefaultDownloadDelegate.h
>index 729b6e61c49581e11ba614cf2bd656e000f3b719..8855b7cd1466325d378b1d408824dfc77fb9d83d 100644
>--- a/Source/WebKitLegacy/win/DefaultDownloadDelegate.h
>+++ b/Source/WebKitLegacy/win/DefaultDownloadDelegate.h
>@@ -32,7 +32,7 @@
> #include <CFNetwork/CFURLDownloadPriv.h>
> #endif
> 
>-class DefaultDownloadDelegate : public IWebDownloadDelegate
>+class DefaultDownloadDelegate final : public IWebDownloadDelegate
> {
> public:
>     static DefaultDownloadDelegate* sharedInstance();
>diff --git a/Source/WebKitLegacy/win/DefaultPolicyDelegate.h b/Source/WebKitLegacy/win/DefaultPolicyDelegate.h
>index ade3c52c3f04f9fb9ca3c68845634d3e0f704feb..a2b666412f84fb364ef20dec282fc4eea7ff0028 100644
>--- a/Source/WebKitLegacy/win/DefaultPolicyDelegate.h
>+++ b/Source/WebKitLegacy/win/DefaultPolicyDelegate.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class DefaultPolicyDelegate : public IWebPolicyDelegate {
>+class DefaultPolicyDelegate final : public IWebPolicyDelegate {
> public:
>     static DefaultPolicyDelegate* sharedInstance();
>     static DefaultPolicyDelegate* createInstance();
>diff --git a/Source/WebKitLegacy/win/MemoryStream.h b/Source/WebKitLegacy/win/MemoryStream.h
>index 97f1c9750308c26f9c3a1a6d4448573b69bb9b55..19f8248b0277639e695c650d79612ac309f7630f 100644
>--- a/Source/WebKitLegacy/win/MemoryStream.h
>+++ b/Source/WebKitLegacy/win/MemoryStream.h
>@@ -32,7 +32,7 @@
> #include <WebCore/SharedBuffer.h>
> #include <WTF/RefPtr.h>
> 
>-class MemoryStream : public IStream
>+class MemoryStream final : public IStream
> {
> public:
>     static COMPtr<MemoryStream> createInstance(RefPtr<WebCore::SharedBuffer>&&);
>diff --git a/Source/WebKitLegacy/win/WebActionPropertyBag.h b/Source/WebKitLegacy/win/WebActionPropertyBag.h
>index 0f9f015226dcaed3f277d49c7e874643a55f9fe2..0c5a1ae5049d8905aa2d33d117b2e018c35f27b3 100644
>--- a/Source/WebKitLegacy/win/WebActionPropertyBag.h
>+++ b/Source/WebKitLegacy/win/WebActionPropertyBag.h
>@@ -31,7 +31,7 @@
> #include <WebCore/HTMLFormElement.h>
> #include <WebCore/NavigationAction.h>
> 
>-class WebActionPropertyBag : public IPropertyBag {
>+class WebActionPropertyBag final : public IPropertyBag {
> public:
>     static WebActionPropertyBag* createInstance(const WebCore::NavigationAction&, RefPtr<WebCore::HTMLFormElement>&&, RefPtr<WebCore::Frame>&&);
> 
>diff --git a/Source/WebKitLegacy/win/WebApplicationCache.h b/Source/WebKitLegacy/win/WebApplicationCache.h
>index eadbf96eccb4fbc7c9edcdc176801c974607650c..8e56d05544ebe4bbda69b0d310d8c5db49d3628f 100644
>--- a/Source/WebKitLegacy/win/WebApplicationCache.h
>+++ b/Source/WebKitLegacy/win/WebApplicationCache.h
>@@ -32,7 +32,7 @@ namespace WebCore {
> class ApplicationCacheStorage;
> }
> 
>-class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache : public IWebApplicationCache {
>+class DECLSPEC_UUID("1119E970-4B13-4B9A-A049-41096104B689") WebApplicationCache final : public IWebApplicationCache {
> public:
>     static WebApplicationCache* createInstance();
> 
>diff --git a/Source/WebKitLegacy/win/WebArchive.h b/Source/WebKitLegacy/win/WebArchive.h
>index e1acaffd2827a9ccecd81b8053632e70fb49bf50..2612267f01d020e5b30a224c3749c8b87f6ec752 100644
>--- a/Source/WebKitLegacy/win/WebArchive.h
>+++ b/Source/WebKitLegacy/win/WebArchive.h
>@@ -34,7 +34,7 @@ namespace WebCore {
>     class LegacyWebArchive;
> }
> 
>-class WebArchive : public IWebArchive
>+class WebArchive final : public IWebArchive
> {
> public:
>     static WebArchive* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebBackForwardList.h b/Source/WebKitLegacy/win/WebBackForwardList.h
>index bfa2516749fda48fda5b1238b19d641439b6d022..7bc7c41c9e5f0df92a40395d23451239d11586ee 100644
>--- a/Source/WebKitLegacy/win/WebBackForwardList.h
>+++ b/Source/WebKitLegacy/win/WebBackForwardList.h
>@@ -33,7 +33,7 @@
> 
> class BackForwardList;
> 
>-class WebBackForwardList : public IWebBackForwardList, IWebBackForwardListPrivate
>+class WebBackForwardList final : public IWebBackForwardList, IWebBackForwardListPrivate
> {
> public:
>     static WebBackForwardList* createInstance(RefPtr<BackForwardList>&&);
>diff --git a/Source/WebKitLegacy/win/WebCache.h b/Source/WebKitLegacy/win/WebCache.h
>index 4877dc1810f3b51efb768cb42028356b841f0790..393f83cc9fe8bd9e19d2a48c896dc6b3cacca114 100644
>--- a/Source/WebKitLegacy/win/WebCache.h
>+++ b/Source/WebKitLegacy/win/WebCache.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class WebCache : public IWebCache
>+class WebCache final : public IWebCache
> {
> public:
>     static WebCache* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebCoreStatistics.h b/Source/WebKitLegacy/win/WebCoreStatistics.h
>index 4a3f08a4cfec0a5caa2a5814c6a51137519709b6..0d6e88806e5b0515777b51167d56c8fa7fcf6f90 100644
>--- a/Source/WebKitLegacy/win/WebCoreStatistics.h
>+++ b/Source/WebKitLegacy/win/WebCoreStatistics.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class WebCoreStatistics : public IWebCoreStatistics {
>+class WebCoreStatistics final : public IWebCoreStatistics {
> public:
>     static WebCoreStatistics* createInstance();
> protected:
>diff --git a/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp b/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp
>index b58de5b138c2cfc70590577a281af95b10308186..2e7ea5819432ad557caf788fd139674b1b67417f 100644
>--- a/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp
>+++ b/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp
>@@ -63,7 +63,7 @@ public:
> 
> // WebEditorUndoTarget -------------------------------------------------------------
> 
>-class WebEditorUndoTarget : public IWebUndoTarget
>+class WebEditorUndoTarget final : public IWebUndoTarget
> {
> public:
>     WebEditorUndoTarget();
>@@ -508,7 +508,7 @@ void WebEditorClient::textDidChangeInTextArea(Element* e)
>     }
> }
> 
>-class WebEditorUndoCommand : public IWebUndoCommand
>+class WebEditorUndoCommand final : public IWebUndoCommand
> {
> public:
>     WebEditorUndoCommand(UndoStep&, bool isUndo);
>diff --git a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h
>index 96fc90dd2fff53be76f49d4ec831f503cacfa62e..ab77af568ee1811f0cee625fdf770b54aa68a2b9 100644
>--- a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h
>+++ b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorDelegate.h
>@@ -32,7 +32,7 @@
> 
> #include "WebKit.h"
> 
>-class WebInspectorDelegate : public IWebUIDelegate {
>+class WebInspectorDelegate final : public IWebUIDelegate {
> public:
>     static WebInspectorDelegate* createInstance();
> 
>diff --git a/Source/WebKitLegacy/win/WebDataSource.h b/Source/WebKitLegacy/win/WebDataSource.h
>index 6144b965a00a5be88f4dcfe65eea72b61ff0f811..70a7f454b23283df6f91ecc3a9ff5a36394ae48c 100644
>--- a/Source/WebKitLegacy/win/WebDataSource.h
>+++ b/Source/WebKitLegacy/win/WebDataSource.h
>@@ -35,7 +35,7 @@ class WebMutableURLRequest;
> 
> extern const GUID IID_WebDataSource;
> 
>-class WebDataSource : public IWebDataSource, public IWebDataSourcePrivate
>+class WebDataSource final : public IWebDataSource, public IWebDataSourcePrivate
> {
> public:
>     static WebDataSource* createInstance(WebDocumentLoader*);
>diff --git a/Source/WebKitLegacy/win/WebDatabaseManager.cpp b/Source/WebKitLegacy/win/WebDatabaseManager.cpp
>index a9693a1b0f072350afacf8be58ae0f03310875df..3f6c38b0628db4bacf9c41357b591a7dec9acd41 100644
>--- a/Source/WebKitLegacy/win/WebDatabaseManager.cpp
>+++ b/Source/WebKitLegacy/win/WebDatabaseManager.cpp
>@@ -57,7 +57,7 @@ static inline bool isEqual(LPCWSTR s1, LPCWSTR s2)
>     return !wcscmp(s1, s2);
> }
> 
>-class DatabaseDetailsPropertyBag : public IPropertyBag {
>+class DatabaseDetailsPropertyBag final : public IPropertyBag {
>     WTF_MAKE_NONCOPYABLE(DatabaseDetailsPropertyBag);
> public:
>     static DatabaseDetailsPropertyBag* createInstance(const DatabaseDetails&);
>diff --git a/Source/WebKitLegacy/win/WebDatabaseManager.h b/Source/WebKitLegacy/win/WebDatabaseManager.h
>index 492921925ae8bd6c493f63a3a7b7bfe80135d5c5..e0fe3e3b881b613e8b0f976a85cad849bb727477 100644
>--- a/Source/WebKitLegacy/win/WebDatabaseManager.h
>+++ b/Source/WebKitLegacy/win/WebDatabaseManager.h
>@@ -35,7 +35,7 @@ namespace WebCore {
> struct SecurityOriginData;
> }
> 
>-class WebDatabaseManager : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
>+class WebDatabaseManager final : public IWebDatabaseManager2, private WebCore::DatabaseManagerClient {
> public:
>     static WebDatabaseManager* createInstance();
> 
>diff --git a/Source/WebKitLegacy/win/WebDownload.h b/Source/WebKitLegacy/win/WebDownload.h
>index 4f6111e23b2c2e07e0ae4afad58ea50ed1a32c7d..bff80f739a20dda71a5e413b5bf9e596b2bdca1b 100644
>--- a/Source/WebKitLegacy/win/WebDownload.h
>+++ b/Source/WebKitLegacy/win/WebDownload.h
>@@ -43,7 +43,7 @@ namespace WebCore {
>     class ResourceResponse;
> }
> 
>-class WebDownload
>+class WebDownload final
> : public IWebDownload
> , public IWebURLAuthenticationChallengeSender
> #if USE(CURL)
>diff --git a/Source/WebKitLegacy/win/WebDropSource.h b/Source/WebKitLegacy/win/WebDropSource.h
>index f507fec4df2db1e53ed55845ad6bf6b4dc20ecfc..9506dd31731e5048c1ad68c838f75b3c7a262914 100644
>--- a/Source/WebKitLegacy/win/WebDropSource.h
>+++ b/Source/WebKitLegacy/win/WebDropSource.h
>@@ -38,7 +38,7 @@ namespace WebCore {
> 
> WebCore::PlatformMouseEvent generateMouseEvent(WebView*, bool isDrag);
> 
>-class WebDropSource : public IDropSource
>+class WebDropSource final : public IDropSource
> {
> public:
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);        
>diff --git a/Source/WebKitLegacy/win/WebElementPropertyBag.h b/Source/WebKitLegacy/win/WebElementPropertyBag.h
>index 8c54ff624545b3f6f6ad6bb63e15d91a70441b55..2dfaa9134af6d7816557eb94cc1dbe020e290edb 100644
>--- a/Source/WebKitLegacy/win/WebElementPropertyBag.h
>+++ b/Source/WebKitLegacy/win/WebElementPropertyBag.h
>@@ -32,7 +32,7 @@ namespace WebCore {
>     class HitTestResult;
> }
> 
>-class WebElementPropertyBag : public IPropertyBag
>+class WebElementPropertyBag final : public IPropertyBag
> {
> public:
>     static WebElementPropertyBag* createInstance(const WebCore::HitTestResult&);
>diff --git a/Source/WebKitLegacy/win/WebError.h b/Source/WebKitLegacy/win/WebError.h
>index 21f449a14aaf4aa8300c69d4d0f05fc3d31453c0..f7c67ebffd798848482152b44838294f2591967f 100644
>--- a/Source/WebKitLegacy/win/WebError.h
>+++ b/Source/WebKitLegacy/win/WebError.h
>@@ -30,7 +30,7 @@
> #include <WebCore/ResourceError.h>
> #include <wtf/RetainPtr.h>
> 
>-class WebError : public IWebError, IWebErrorPrivate {
>+class WebError final : public IWebError, IWebErrorPrivate {
> public:
>     static WebError* createInstance(const WebCore::ResourceError&, IPropertyBag* userInfo = 0);
>     static WebError* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebFrame.cpp b/Source/WebKitLegacy/win/WebFrame.cpp
>index 8866515f1a4d6969ed994c2535ce98062bf45fcb..c03242c7d6b62d8fc635d9a0d7bd6e5d7c259fed 100644
>--- a/Source/WebKitLegacy/win/WebFrame.cpp
>+++ b/Source/WebKitLegacy/win/WebFrame.cpp
>@@ -758,7 +758,7 @@ HRESULT WebFrame::parentFrame(_COM_Outptr_opt_ IWebFrame** frame)
>     return hr;
> }
> 
>-class EnumChildFrames : public IEnumVARIANT
>+class EnumChildFrames final : public IEnumVARIANT
> {
> public:
>     EnumChildFrames(Frame* f)
>diff --git a/Source/WebKitLegacy/win/WebFrame.h b/Source/WebKitLegacy/win/WebFrame.h
>index c4d08362dad5e8393e8dff831c25981a2c77fffa..1badd01c3a7640ccf11304a435a7b1e245115fde 100644
>--- a/Source/WebKitLegacy/win/WebFrame.h
>+++ b/Source/WebKitLegacy/win/WebFrame.h
>@@ -75,7 +75,7 @@ interface IWebHistoryItemPrivate;
> WebFrame* kit(WebCore::Frame*);
> WEBKIT_API WebCore::Frame* core(WebFrame*);
> 
>-class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame : public IWebFrame2, IWebFramePrivate, IWebDocumentText
>+class DECLSPEC_UUID("{A3676398-4485-4a9d-87DC-CB5A40E6351D}") WebFrame final : public IWebFrame2, IWebFramePrivate, IWebDocumentText
> {
> public:
>     static WebFrame* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebFramePolicyListener.h b/Source/WebKitLegacy/win/WebFramePolicyListener.h
>index 02bc4caab659e2998668cd8123438636916bf320..170de9557117cb795020e4386a4294aa43983285 100644
>--- a/Source/WebKitLegacy/win/WebFramePolicyListener.h
>+++ b/Source/WebKitLegacy/win/WebFramePolicyListener.h
>@@ -35,7 +35,7 @@ namespace WebCore {
>     class Frame;
> }
> 
>-class WebFramePolicyListener : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
>+class WebFramePolicyListener final : public IWebPolicyDecisionListener, public IWebFormSubmissionListener {
> public:
>     static WebFramePolicyListener* createInstance(RefPtr<WebCore::Frame>&&);
> protected:
>diff --git a/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h b/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h
>index 2a499b1b9b982a919103b0f15feed1246c650d72..5e7864b528fb4f8c83a052f1dd32620e6817b75f 100644
>--- a/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h
>+++ b/Source/WebKitLegacy/win/WebGeolocationPolicyListener.h
>@@ -33,7 +33,7 @@ namespace WebCore {
>     class Geolocation;
> }
> 
>-class WebGeolocationPolicyListener : public IWebGeolocationPolicyListener {
>+class WebGeolocationPolicyListener final : public IWebGeolocationPolicyListener {
> public:
>     static COMPtr<WebGeolocationPolicyListener> createInstance(RefPtr<WebCore::Geolocation>&&);
> 
>diff --git a/Source/WebKitLegacy/win/WebGeolocationPosition.h b/Source/WebKitLegacy/win/WebGeolocationPosition.h
>index 6cd15c89cbb90174f4308a53f72b6135fcbc03eb..0e4468e62b2b04300bab357a33d69548346d23fe 100644
>--- a/Source/WebKitLegacy/win/WebGeolocationPosition.h
>+++ b/Source/WebKitLegacy/win/WebGeolocationPosition.h
>@@ -29,7 +29,7 @@
> #include <WebCore/COMPtr.h>
> #include <WebCore/GeolocationPosition.h>
> 
>-class WebGeolocationPosition : public IWebGeolocationPosition {
>+class WebGeolocationPosition final : public IWebGeolocationPosition {
> public:
>     static COMPtr<WebGeolocationPosition> createInstance();
> private:
>diff --git a/Source/WebKitLegacy/win/WebHTMLRepresentation.h b/Source/WebKitLegacy/win/WebHTMLRepresentation.h
>index 869aa3108ed31849bda2c8a17cf133cd20823ac1..cb9e4d7aa29b7fa5edf3c92252fed1e41c67589c 100644
>--- a/Source/WebKitLegacy/win/WebHTMLRepresentation.h
>+++ b/Source/WebKitLegacy/win/WebHTMLRepresentation.h
>@@ -30,7 +30,7 @@
> 
> class WebFrame;
> 
>-class WebHTMLRepresentation : public IWebHTMLRepresentation, IWebDocumentRepresentation
>+class WebHTMLRepresentation final : public IWebHTMLRepresentation, IWebDocumentRepresentation
> {
> public:
>     static WebHTMLRepresentation* createInstance(WebFrame* frame);
>diff --git a/Source/WebKitLegacy/win/WebHistory.h b/Source/WebKitLegacy/win/WebHistory.h
>index b9d170a36e1199aa3711e9690604dc2a95052998..17f80927246adb6d4571df96b12e696a945858fe 100644
>--- a/Source/WebKitLegacy/win/WebHistory.h
>+++ b/Source/WebKitLegacy/win/WebHistory.h
>@@ -41,7 +41,7 @@ class PageGroup;
> class WebPreferences;
> class WebVisitedLinkStore;
> 
>-class WebHistory : public IWebHistory, public IWebHistoryPrivate {
>+class WebHistory final : public IWebHistory, public IWebHistoryPrivate {
> public:
>     static WebHistory* createInstance();
> private:
>diff --git a/Source/WebKitLegacy/win/WebHistoryItem.h b/Source/WebKitLegacy/win/WebHistoryItem.h
>index b3865703edcc1a9ca7f3dffd6ae3183d62d13087..920b34c85be7daf81b99dbb72bc8f4cb4239c7db 100644
>--- a/Source/WebKitLegacy/win/WebHistoryItem.h
>+++ b/Source/WebKitLegacy/win/WebHistoryItem.h
>@@ -38,7 +38,7 @@ namespace WebCore {
> 
> //-----------------------------------------------------------------------------
> 
>-class WebHistoryItem : public IWebHistoryItem, IWebHistoryItemPrivate
>+class WebHistoryItem final : public IWebHistoryItem, IWebHistoryItemPrivate
> {
> public:
>     static WebHistoryItem* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebInspector.h b/Source/WebKitLegacy/win/WebInspector.h
>index 2794f71a3324ec03eb08034ca318a4af3b688cd3..cac6513d659bc0a064d3311b3b766e7f2ebfe37d 100644
>--- a/Source/WebKitLegacy/win/WebInspector.h
>+++ b/Source/WebKitLegacy/win/WebInspector.h
>@@ -36,7 +36,7 @@ class WebInspectorClient;
> class WebInspectorFrontendClient;
> class WebView;
> 
>-class WebInspector : public IWebInspector, public IWebInspectorPrivate {
>+class WebInspector final : public IWebInspector, public IWebInspectorPrivate {
>     WTF_MAKE_NONCOPYABLE(WebInspector);
> public:
>     static WebInspector* createInstance(WebView* inspectedWebView, WebInspectorClient*);
>diff --git a/Source/WebKitLegacy/win/WebJavaScriptCollector.h b/Source/WebKitLegacy/win/WebJavaScriptCollector.h
>index 012bf0d173728d42d605cf1931764b766fb65d71..300c856363e6c4d23b49a24321fcf933dd7aa629 100644
>--- a/Source/WebKitLegacy/win/WebJavaScriptCollector.h
>+++ b/Source/WebKitLegacy/win/WebJavaScriptCollector.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class WebJavaScriptCollector : public IWebJavaScriptCollector
>+class WebJavaScriptCollector final : public IWebJavaScriptCollector
> {
> public:
>     static WebJavaScriptCollector* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebKitClassFactory.h b/Source/WebKitLegacy/win/WebKitClassFactory.h
>index 3c907e3eee0a8c1f8c90486946373b02efe2ea83..77230f69704714c6f14193a89d56d52666091e8b 100644
>--- a/Source/WebKitLegacy/win/WebKitClassFactory.h
>+++ b/Source/WebKitLegacy/win/WebKitClassFactory.h
>@@ -28,7 +28,7 @@
> 
> #include <unknwn.h>
> 
>-class WebKitClassFactory : public IClassFactory
>+class WebKitClassFactory final : public IClassFactory
> {
> public:
>     WebKitClassFactory(CLSID targetClass);
>diff --git a/Source/WebKitLegacy/win/WebKitMessageLoop.h b/Source/WebKitLegacy/win/WebKitMessageLoop.h
>index 1b0e17f48b9fe2d9d3cbbf9b81763fc293090fc4..c69d3bfc50c8f77fadc48a9c5d00baf1cfe7e483 100644
>--- a/Source/WebKitLegacy/win/WebKitMessageLoop.h
>+++ b/Source/WebKitLegacy/win/WebKitMessageLoop.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class WebKitMessageLoop : public IWebKitMessageLoop {
>+class WebKitMessageLoop final : public IWebKitMessageLoop {
> public:
>     WebKitMessageLoop();
>     ~WebKitMessageLoop();
>diff --git a/Source/WebKitLegacy/win/WebKitStatistics.h b/Source/WebKitLegacy/win/WebKitStatistics.h
>index b2df2065fb723514a8ae027e0495aa391220dbd5..889bb1a24ca0535b3abb0d28d16b232da2df36e2 100644
>--- a/Source/WebKitLegacy/win/WebKitStatistics.h
>+++ b/Source/WebKitLegacy/win/WebKitStatistics.h
>@@ -31,7 +31,7 @@
> 
> #include "WebKit.h"
> 
>-class WebKitStatistics : public IWebKitStatistics {
>+class WebKitStatistics final : public IWebKitStatistics {
> public:
>     static WebKitStatistics* createInstance();
> protected:
>diff --git a/Source/WebKitLegacy/win/WebMutableURLRequest.h b/Source/WebKitLegacy/win/WebMutableURLRequest.h
>index 041c9092184bc4c65c7fb133e10617fb8982b386..94cd2b4c24fc710fa911498e94990f932716fa08 100644
>--- a/Source/WebKitLegacy/win/WebMutableURLRequest.h
>+++ b/Source/WebKitLegacy/win/WebMutableURLRequest.h
>@@ -44,7 +44,7 @@ inline WebURLRequestCachePolicy kit(WebCore::ResourceRequestCachePolicy policy)
>     return static_cast<WebURLRequestCachePolicy>(policy);
> }
> 
>-class WebMutableURLRequest : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
>+class WebMutableURLRequest final : public IWebMutableURLRequest, IWebMutableURLRequestPrivate
> {
> public:
>     static WebMutableURLRequest* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebNavigationData.h b/Source/WebKitLegacy/win/WebNavigationData.h
>index e368d83ac459ed83e67e9de877e940207442187f..4bc99569ca02ff35402869c36bd6ae3fd0bdc54b 100644
>--- a/Source/WebKitLegacy/win/WebNavigationData.h
>+++ b/Source/WebKitLegacy/win/WebNavigationData.h
>@@ -31,7 +31,7 @@
> #include <WebCore/BString.h>
> #include <WebCore/COMPtr.h>
> 
>-class WebNavigationData : public IWebNavigationData {
>+class WebNavigationData final : public IWebNavigationData {
> public:
>     static WebNavigationData* createInstance(const WTF::String& url, const WTF::String& title, IWebURLRequest*, IWebURLResponse*, bool hasSubstituteData, const WTF::String& clientRedirectSource);
> private:
>diff --git a/Source/WebKitLegacy/win/WebNotification.h b/Source/WebKitLegacy/win/WebNotification.h
>index 843e3d98c9caa7b0e423b5f26cec9d77e200324b..930db8af2a3d13c0df4a270d24c5e8fb119ab20c 100644
>--- a/Source/WebKitLegacy/win/WebNotification.h
>+++ b/Source/WebKitLegacy/win/WebNotification.h
>@@ -28,7 +28,7 @@
> 
> #include "WebKit.h"
> 
>-class WebNotification : public IWebNotification
>+class WebNotification final : public IWebNotification
> {
> public:
>     static WebNotification* createInstance(BSTR name = 0, IUnknown* anObject = 0, IPropertyBag* userInfo = 0);
>diff --git a/Source/WebKitLegacy/win/WebNotificationCenter.h b/Source/WebKitLegacy/win/WebNotificationCenter.h
>index 0ea057ebc6a17b3f389a35811e7084305dbf3028..389e98c7d9fdca30316014f9f1d1f620a349ef2f 100644
>--- a/Source/WebKitLegacy/win/WebNotificationCenter.h
>+++ b/Source/WebKitLegacy/win/WebNotificationCenter.h
>@@ -30,7 +30,7 @@
> 
> struct WebNotificationCenterPrivate;
> 
>-class WebNotificationCenter : public IWebNotificationCenter {
>+class WebNotificationCenter final : public IWebNotificationCenter {
> public:
>     static WebNotificationCenter* createInstance();
> 
>diff --git a/Source/WebKitLegacy/win/WebPreferences.h b/Source/WebKitLegacy/win/WebPreferences.h
>index 3ce4485b8a0170f5efed7982fbdf58608a162a4b..2906b36b188c9d892294bcdedf2a6c251de8bb46 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.h
>+++ b/Source/WebKitLegacy/win/WebPreferences.h
>@@ -30,7 +30,7 @@
> #include <WebCore/BString.h>
> #include <wtf/RetainPtr.h>
> 
>-class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 {
>+class WebPreferences final : public IWebPreferences, public IWebPreferencesPrivate7 {
> public:
>     static WebPreferences* createInstance();
> protected:
>diff --git a/Source/WebKitLegacy/win/WebResource.h b/Source/WebKitLegacy/win/WebResource.h
>index 4df3e0c11504650a9f2b01c2171e21fc21a0b98d..055b5e8b20bb3c2a768d7d2d61e247150c7dbeda 100644
>--- a/Source/WebKitLegacy/win/WebResource.h
>+++ b/Source/WebKitLegacy/win/WebResource.h
>@@ -34,7 +34,7 @@
> #include <wtf/URL.h>
> #include <wtf/text/WTFString.h>
> 
>-class WebResource : public IWebResource {
>+class WebResource final : public IWebResource {
> public:
>     static WebResource* createInstance(RefPtr<WebCore::SharedBuffer>&&, const WebCore::ResourceResponse&);
> protected:
>diff --git a/Source/WebKitLegacy/win/WebScriptWorld.h b/Source/WebKitLegacy/win/WebScriptWorld.h
>index 9caba2e0c0f278017c271377f7321768c88dbcf6..0dd63b7ba02f7c74feaa3bf366039750fe961ce1 100644
>--- a/Source/WebKitLegacy/win/WebScriptWorld.h
>+++ b/Source/WebKitLegacy/win/WebScriptWorld.h
>@@ -32,7 +32,7 @@ namespace WebCore {
>     class DOMWrapperWorld;
> }
> 
>-class WebScriptWorld : public IWebScriptWorld {
>+class WebScriptWorld final : public IWebScriptWorld {
>     WTF_MAKE_NONCOPYABLE(WebScriptWorld);
> public:
>     static WebScriptWorld* standardWorld();
>diff --git a/Source/WebKitLegacy/win/WebSecurityOrigin.h b/Source/WebKitLegacy/win/WebSecurityOrigin.h
>index 05059c58202a71b91fe05face4d62baeb038d5ab..f798ce3028bc41de52854f31e121afedf2b76a28 100644
>--- a/Source/WebKitLegacy/win/WebSecurityOrigin.h
>+++ b/Source/WebKitLegacy/win/WebSecurityOrigin.h
>@@ -31,7 +31,7 @@
> #include "WebKit.h"
> #include <WebCore/SecurityOrigin.h>
> 
>-class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin : public IWebSecurityOrigin2 {
>+class DECLSPEC_UUID("6EB8D98F-2723-4472-88D3-5936F9D6E631") WebSecurityOrigin final : public IWebSecurityOrigin2 {
> public:
>     // WebSecurityOrigin
>     static WebSecurityOrigin* createInstance(WebCore::SecurityOrigin* origin);
>diff --git a/Source/WebKitLegacy/win/WebSerializedJSValue.h b/Source/WebKitLegacy/win/WebSerializedJSValue.h
>index 99a5c152102786305c2d13a47250519cca9377a6..3c61321e6c8012b8a326600aadb75df2b7d29c9c 100644
>--- a/Source/WebKitLegacy/win/WebSerializedJSValue.h
>+++ b/Source/WebKitLegacy/win/WebSerializedJSValue.h
>@@ -35,7 +35,7 @@ namespace WebCore {
>     class SerializedScriptValue;
> }
> 
>-class WebSerializedJSValue : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
>+class WebSerializedJSValue final : public IWebSerializedJSValue, public IWebSerializedJSValuePrivate {
>     WTF_MAKE_NONCOPYABLE(WebSerializedJSValue);
> public:
>     static COMPtr<WebSerializedJSValue> createInstance();
>diff --git a/Source/WebKitLegacy/win/WebTextRenderer.h b/Source/WebKitLegacy/win/WebTextRenderer.h
>index 68e5c521d9436f30e38dfa1d32d8841eecaab8ad..34f607681d64b3c8176af8aa995e53ce1934f61b 100644
>--- a/Source/WebKitLegacy/win/WebTextRenderer.h
>+++ b/Source/WebKitLegacy/win/WebTextRenderer.h
>@@ -31,7 +31,7 @@
> 
> #include "WebKit.h"
> 
>-class WebTextRenderer : public IWebTextRenderer {
>+class WebTextRenderer final : public IWebTextRenderer {
> public:
>     static WebTextRenderer* createInstance();
> 
>diff --git a/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h b/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h
>index 5242ba74f3999fa4c0c163a307dbdefcd01f3d52..9133bdbd0e2e1a3ab9ce7ba0a6886a4db5bcf071 100644
>--- a/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h
>+++ b/Source/WebKitLegacy/win/WebURLAuthenticationChallenge.h
>@@ -30,7 +30,7 @@
> #include <WebCore/AuthenticationChallenge.h>
> #include <WebCore/COMPtr.h>
> 
>-class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge : public IWebURLAuthenticationChallenge {
>+class DECLSPEC_UUID("FD3B2381-0BB6-4B59-AF09-0E599C8901CF") WebURLAuthenticationChallenge final : public IWebURLAuthenticationChallenge {
> public:
>     static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&);
>     static WebURLAuthenticationChallenge* createInstance(const WebCore::AuthenticationChallenge&, IWebURLAuthenticationChallengeSender*);
>diff --git a/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h b/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h
>index db30b654ea666074280fb3fbab504380e4312f5f..944bfabff441524b41567c9d7f5ac235cc80beee 100644
>--- a/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h
>+++ b/Source/WebKitLegacy/win/WebURLAuthenticationChallengeSender.h
>@@ -35,7 +35,7 @@ namespace WebCore {
>     class AuthenticationClient;
> }
> 
>-class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender
>+class DECLSPEC_UUID("5CACD637-F82F-491F-947A-5DCA38AA0FEA") WebURLAuthenticationChallengeSender final
>     : public IWebURLAuthenticationChallengeSender
> {
> public:
>diff --git a/Source/WebKitLegacy/win/WebURLCredential.h b/Source/WebKitLegacy/win/WebURLCredential.h
>index 6ccb61190d569be5268a1b9815d817be81b1a8e3..33bd05150d82ebf04b8050c9d144dfcd2f458f1a 100644
>--- a/Source/WebKitLegacy/win/WebURLCredential.h
>+++ b/Source/WebKitLegacy/win/WebURLCredential.h
>@@ -29,7 +29,7 @@
> #include "WebKit.h"
> #include <WebCore/Credential.h>
> 
>-class WebURLCredential : public IWebURLCredential
>+class WebURLCredential final : public IWebURLCredential
> {
> public:
>     static WebURLCredential* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebURLProtectionSpace.h b/Source/WebKitLegacy/win/WebURLProtectionSpace.h
>index 2dab3c1ededbb4949bdb25e6c12baf02ae7ef5f7..e2ac83f19cc038e06d3925dc0767179038644b5c 100644
>--- a/Source/WebKitLegacy/win/WebURLProtectionSpace.h
>+++ b/Source/WebKitLegacy/win/WebURLProtectionSpace.h
>@@ -29,7 +29,7 @@
> #include "WebKit.h"
> #include <WebCore/ProtectionSpace.h>
> 
>-class WebURLProtectionSpace : public IWebURLProtectionSpace
>+class WebURLProtectionSpace final : public IWebURLProtectionSpace
> {
> public:
>     static WebURLProtectionSpace* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebURLResponse.h b/Source/WebKitLegacy/win/WebURLResponse.h
>index 0991792b9f0e52799ce6324b7a164578bc998f04..93410cd9f444f89470236fd68d89a6e83c1a9095 100644
>--- a/Source/WebKitLegacy/win/WebURLResponse.h
>+++ b/Source/WebKitLegacy/win/WebURLResponse.h
>@@ -28,7 +28,7 @@
> #include "WebKit.h"
> #include <WebCore/ResourceResponse.h>
> 
>-class WebURLResponse : public IWebHTTPURLResponse, IWebURLResponsePrivate
>+class WebURLResponse final : public IWebHTTPURLResponse, IWebURLResponsePrivate
> {
> public:
>     static WebURLResponse* createInstance();
>diff --git a/Source/WebKitLegacy/win/WebUserContentURLPattern.h b/Source/WebKitLegacy/win/WebUserContentURLPattern.h
>index f9f473eecc099b75ad2538f95a715d52018cbb44..85c531d6d774dd93a839b4a0b4fd7769264862f1 100644
>--- a/Source/WebKitLegacy/win/WebUserContentURLPattern.h
>+++ b/Source/WebKitLegacy/win/WebUserContentURLPattern.h
>@@ -33,7 +33,7 @@ namespace WebCore {
>     class UserContentURLPattern;
> }
> 
>-class WebUserContentURLPattern : public IWebUserContentURLPattern {
>+class WebUserContentURLPattern final : public IWebUserContentURLPattern {
>     WTF_MAKE_NONCOPYABLE(WebUserContentURLPattern);
> public:
>     static COMPtr<WebUserContentURLPattern> createInstance();
>diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
>index 6ae21ecfb1d89d7d69806cccca3ee57b2b73ee37..e8bddebf2626f5ccad8d4aced5733e72722aeeb7 100644
>--- a/Source/WebKitLegacy/win/WebView.cpp
>+++ b/Source/WebKitLegacy/win/WebView.cpp
>@@ -282,7 +282,7 @@ static String localStorageDatabasePath(WebPreferences* preferences)
>     return toString(localStorageDatabasePath);
> }
> 
>-class PreferencesChangedOrRemovedObserver : public IWebNotificationObserver {
>+class PreferencesChangedOrRemovedObserver final : public IWebNotificationObserver {
> public:
>     static PreferencesChangedOrRemovedObserver* sharedInstance();
> 
>@@ -7385,7 +7385,7 @@ void WebView::flushPendingGraphicsLayerChanges()
> }
> #endif
> 
>-class EnumTextMatches : public IEnumTextMatches
>+class EnumTextMatches final : public IEnumTextMatches
> {
>     long m_ref;
>     UINT m_index;
>diff --git a/Source/WebKitLegacy/win/WebView.h b/Source/WebKitLegacy/win/WebView.h
>index 1617f10a4dad2471629a012b0498c6733b914b4a..c3eb08c428892792cdb3a86d6df951e5a108ee6b 100644
>--- a/Source/WebKitLegacy/win/WebView.h
>+++ b/Source/WebKitLegacy/win/WebView.h
>@@ -85,7 +85,7 @@ interface ID2D1HwndRenderTarget;
> interface ID2D1RenderTarget;
> #endif
> 
>-class WebView 
>+class WebView final
>     : public IWebView
>     , public IWebViewPrivate5
>     , public IWebIBActions
>diff --git a/Source/WebKitLegacy/win/WebWorkersPrivate.h b/Source/WebKitLegacy/win/WebWorkersPrivate.h
>index 87c4c89348ec2e393f3b4aac931fe8ebb0c3f095..ae620c2c74930543417f091d8545bed4c39c2184 100644
>--- a/Source/WebKitLegacy/win/WebWorkersPrivate.h
>+++ b/Source/WebKitLegacy/win/WebWorkersPrivate.h
>@@ -33,7 +33,7 @@
> 
> #include "WebKit.h"
> 
>-class WebWorkersPrivate : public IWebWorkersPrivate {
>+class WebWorkersPrivate final : public IWebWorkersPrivate {
> public:
>     static WebWorkersPrivate* createInstance();
> private:
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 367c36cf462b4ac1b72fe35ee4b0fce9332979ab..ddfdbc7cf2bb9d9a163176c0567e0e5f2082b5d8 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>+        https://bugs.webkit.org/show_bug.cgi?id=192618
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/win/DRTDataObject.cpp:
>+        * DumpRenderTree/win/DRTDataObject.h:
>+        * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
>+        * DumpRenderTree/win/DRTDropSource.h:
>+        * DumpRenderTree/win/EditingDelegate.h:
>+        * DumpRenderTree/win/PolicyDelegate.h:
>+        * DumpRenderTree/win/UIDelegate.h:
>+
> 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
> 
>         Implement feature flag for CSS Typed OM
>diff --git a/Tools/DumpRenderTree/win/DRTDataObject.cpp b/Tools/DumpRenderTree/win/DRTDataObject.cpp
>index 87461c12e0421ab31129a55714106385b97349e5..ef2d2efb859f4b8a22f30c467ace1f8aad157a4d 100644
>--- a/Tools/DumpRenderTree/win/DRTDataObject.cpp
>+++ b/Tools/DumpRenderTree/win/DRTDataObject.cpp
>@@ -47,7 +47,7 @@ FORMATETC* cfUrlWFormat()
>     return &urlFormat;
> }
> 
>-class WCEnumFormatEtc : public IEnumFORMATETC {
>+class WCEnumFormatEtc final : public IEnumFORMATETC {
> public:
>     explicit WCEnumFormatEtc(const Vector<FORMATETC>& formats);
>     explicit WCEnumFormatEtc(const Vector<std::unique_ptr<FORMATETC>>& formats);
>diff --git a/Tools/DumpRenderTree/win/DRTDataObject.h b/Tools/DumpRenderTree/win/DRTDataObject.h
>index 15c7f1553b49c8894911d19a7338ac8f6181866e..b952b081afeaa391927ad2cab7dd18e879337421 100644
>--- a/Tools/DumpRenderTree/win/DRTDataObject.h
>+++ b/Tools/DumpRenderTree/win/DRTDataObject.h
>@@ -44,7 +44,7 @@ struct StgMediumDeleter {
>     }
> };
> 
>-class DRTDataObject : public IDataObject {
>+class DRTDataObject final : public IDataObject {
> public:
>     void CopyMedium(STGMEDIUM* pMedDest, STGMEDIUM* pMedSrc, FORMATETC* pFmtSrc);
> 
>diff --git a/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h b/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h
>index eb2ce490a430e18411a05c635e8920f5ddb4e7d5..70bd470e3dcc0e630f6d51c2eca8b423dd3f93d7 100644
>--- a/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h
>+++ b/Tools/DumpRenderTree/win/DRTDesktopNotificationPresenter.h
>@@ -32,7 +32,7 @@
> #include <WebKitLegacy/WebKit.h>
> #include <windef.h>
> 
>-class DRTDesktopNotificationPresenter : public IWebDesktopNotificationsDelegate {
>+class DRTDesktopNotificationPresenter final : public IWebDesktopNotificationsDelegate {
> public:
>     DRTDesktopNotificationPresenter();
> 
>diff --git a/Tools/DumpRenderTree/win/DRTDropSource.h b/Tools/DumpRenderTree/win/DRTDropSource.h
>index 662c7d650244be2e0034da105bc5956efaa2dfff..d9ee7d01965636e13316877ce934bc4c6d7021cc 100644
>--- a/Tools/DumpRenderTree/win/DRTDropSource.h
>+++ b/Tools/DumpRenderTree/win/DRTDropSource.h
>@@ -30,7 +30,7 @@
> #include <ShlObj.h>
> #include <windows.h>
> 
>-class DRTDropSource : public IDropSource {
>+class DRTDropSource final : public IDropSource {
> public:
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);        
>     virtual ULONG STDMETHODCALLTYPE AddRef();
>diff --git a/Tools/DumpRenderTree/win/EditingDelegate.h b/Tools/DumpRenderTree/win/EditingDelegate.h
>index 8110ffa460d56cdead6a9aca0c10455162fd316f..4f1767c6ee4b252b888e90a5bf9f606878e1cdef 100644
>--- a/Tools/DumpRenderTree/win/EditingDelegate.h
>+++ b/Tools/DumpRenderTree/win/EditingDelegate.h
>@@ -31,7 +31,7 @@
> 
> #include <WebKitLegacy/WebKit.h>
> 
>-class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate : public IWebEditingDelegate2, public IWebNotificationObserver {
>+class __declspec(uuid("265DCD4B-79C3-44a2-84BC-511C3EDABD6F")) EditingDelegate final : public IWebEditingDelegate2, public IWebNotificationObserver {
> public:
>     EditingDelegate();
> 
>diff --git a/Tools/DumpRenderTree/win/PolicyDelegate.h b/Tools/DumpRenderTree/win/PolicyDelegate.h
>index a27a1e3226280b466f141810c3c3f5727587b0be..e9838650765220eff21bc1089487abd93bfa06a0 100644
>--- a/Tools/DumpRenderTree/win/PolicyDelegate.h
>+++ b/Tools/DumpRenderTree/win/PolicyDelegate.h
>@@ -33,7 +33,7 @@
> 
> class TestRunner;
> 
>-class PolicyDelegate : public IWebPolicyDelegate {
>+class PolicyDelegate final : public IWebPolicyDelegate {
> public:
>     PolicyDelegate();
> 
>diff --git a/Tools/DumpRenderTree/win/UIDelegate.h b/Tools/DumpRenderTree/win/UIDelegate.h
>index fa4edbb5e661685302e2ae1222d4d75559f1b5a2..78258903770055ac92466191a5eb8deff42514bb 100644
>--- a/Tools/DumpRenderTree/win/UIDelegate.h
>+++ b/Tools/DumpRenderTree/win/UIDelegate.h
>@@ -36,7 +36,7 @@
> class DRTUndoManager;
> class DRTDesktopNotificationPresenter;
> 
>-class UIDelegate : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
>+class UIDelegate final : public IWebUIDelegate2, IWebUIDelegatePrivate3 {
> public:
>     UIDelegate();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192618: 357113