WebKit Bugzilla
Attachment 357068 Details for
Bug 192600
: Globally namespaced objects shouldn't use framework-prefixed names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192600-20181211121224.patch (text/plain), 2.66 KB, created by
Jer Noble
on 2018-12-11 12:12:25 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jer Noble
Created:
2018-12-11 12:12:25 PST
Size:
2.66 KB
patch
obsolete
>Subversion Revision: 238907 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index f881ee703d36ea117c7d5b285720500f97b97409..18d2418fd2b8668dc9df432171a753b27481144b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,19 @@ >+2018-12-11 Jer Noble <jer.noble@apple.com> >+ >+ Globally namespaced objects shouldn't use framework-prefixed names >+ https://bugs.webkit.org/show_bug.cgi?id=192600 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Rename CMSampleBufferIs... -> isCMSampleBuffer... >+ >+ * platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: >+ (WebCore::isCMSampleBufferRandomAccess): >+ (WebCore::isCMSampleBufferNonDisplaying): >+ (WebCore::MediaSampleAVFObjC::flags const): >+ (WebCore::CMSampleBufferIsRandomAccess): Deleted. >+ (WebCore::CMSampleBufferIsNonDisplaying): Deleted. >+ > 2018-11-30 Jer Noble <jer.noble@apple.com> > > Web Content process main thread blocked beneath ImageDecoderAVFObjC::readSamples for many seconds on imgur.com >diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm >index 67bb4c6dfe33049dbe19228b50f7ca876714c7ee..0ef943c4dd2bf43ceaf5ba5fe3345ba28c52b2e6 100644 >--- a/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm >+++ b/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm >@@ -119,7 +119,7 @@ uint32_t MediaSampleAVFObjC::videoPixelFormat() const > return CVPixelBufferGetPixelFormatType(pixelBuffer); > } > >-static bool CMSampleBufferIsRandomAccess(CMSampleBufferRef sample) >+static bool isCMSampleBufferRandomAccess(CMSampleBufferRef sample) > { > CFArrayRef attachments = CMSampleBufferGetSampleAttachmentsArray(sample, false); > if (!attachments) >@@ -133,7 +133,7 @@ static bool CMSampleBufferIsRandomAccess(CMSampleBufferRef sample) > return true; > } > >-static bool CMSampleBufferIsNonDisplaying(CMSampleBufferRef sample) >+static bool isCMSampleBufferNonDisplaying(CMSampleBufferRef sample) > { > CFArrayRef attachments = CMSampleBufferGetSampleAttachmentsArray(sample, false); > if (!attachments) >@@ -152,10 +152,10 @@ MediaSample::SampleFlags MediaSampleAVFObjC::flags() const > { > int returnValue = MediaSample::None; > >- if (CMSampleBufferIsRandomAccess(m_sample.get())) >+ if (isCMSampleBufferRandomAccess(m_sample.get())) > returnValue |= MediaSample::IsSync; > >- if (CMSampleBufferIsNonDisplaying(m_sample.get())) >+ if (isCMSampleBufferNonDisplaying(m_sample.get())) > returnValue |= MediaSample::IsNonDisplaying; > > return SampleFlags(returnValue);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192600
: 357068