WebKit Bugzilla
Attachment 357053 Details for
Bug 192590
: [WebAudio] Release the AudioDestination when uninitializing DefaultAudioDestinationNode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192590-20181211181641.patch (text/plain), 1.71 KB, created by
Yacine Bandou
on 2018-12-11 09:16:48 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yacine Bandou
Created:
2018-12-11 09:16:48 PST
Size:
1.71 KB
patch
obsolete
>Subversion Revision: 238446 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index b452098ffaf366d2a089dbbea44f4bebd9c5c56e..e38e4e3118d94eefa564ba83f0f04ac90baa792a 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,18 @@ >+2018-12-11 Yacine Bandou <yacine.bandou@softathome.com> >+ >+ [WebAudio] Release the AudioDestination when uninitializing DefaultAudioDestinationNode >+ https://bugs.webkit.org/show_bug.cgi?id=192590 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ When we uninitialize DefaultAudioDestinationNode, the AudioDestination is stopped but not destroyed. >+ >+ On some platforms the resources are allocated and released with the AudioDestination, thus when we uninitialize >+ DefaultAudioDestinationNode we don't release resources because the AudioDestination is not destroyed. >+ >+ * Modules/webaudio/DefaultAudioDestinationNode.cpp: >+ (WebCore::DefaultAudioDestinationNode::uninitialize): >+ > 2018-12-11 Yacine Bandou <yacine.bandou@softathome.com> > > [WebAudio] Call AudioContext::uninitialize() immediately when the AudioContext is stopped >diff --git a/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp b/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp >index 17ad87173ef5aaee206f4ac07a8edb69ea80b54d..7ace7e73618413f03b42bf56c0647cf204082d08 100644 >--- a/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp >+++ b/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp >@@ -69,6 +69,7 @@ void DefaultAudioDestinationNode::uninitialize() > return; > > m_destination->stop(); >+ m_destination = nullptr; > m_numberOfInputChannels = 0; > > AudioNode::uninitialize();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192590
: 357053