Attachment 357052 Details for Bug 192591 – Patch

[patch] Patch

bug-192591-20181211090700.patch (text/plain), 2.38 KB, created by Brent Fulgham on 2018-12-11 09:07:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-12-11 09:07:01 PST

Size: 2.38 KB

patch

obsolete

>Subversion Revision: 239073
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6bc33384e05e35cfba4b62827b51ac87e0f8d606..8ec8873bfae9e9c3e6758281a4c19fc1b6f88f92 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-11  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Don't attempt to compute animated values when there is no relevant animation
>+        https://bugs.webkit.org/show_bug.cgi?id=192591
>+        <rdar://problem/34336946>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Check if the property is supposed to be animated, or has animatable features, before
>+        attempting to calculate the current animated value.
>+
>+        * svg/SVGAnimateElementBase.cpp:
>+        (WebCore::SVGAnimateElementBase::calculateAnimatedValue):
>+
> 2018-12-10  Brent Fulgham  <bfulgham@apple.com>
> 
>         SVGViewSpec objects should mark relevant SVG elements
>diff --git a/Source/WebCore/svg/SVGAnimateElementBase.cpp b/Source/WebCore/svg/SVGAnimateElementBase.cpp
>index 2a7e079755fe22f1bffd9109d71df07d50d20df0..a4a24faf871504c1d73c3bf20ffd3edc6b6de84d 100644
>--- a/Source/WebCore/svg/SVGAnimateElementBase.cpp
>+++ b/Source/WebCore/svg/SVGAnimateElementBase.cpp
>@@ -91,6 +91,12 @@ void SVGAnimateElementBase::calculateAnimatedValue(float percentage, unsigned re
>     if (!targetElement)
>         return;
> 
>+    const QualifiedName& attributeName = this->attributeName();
>+    ShouldApplyAnimation shouldApply = shouldApplyAnimation(targetElement.get(), attributeName);
>+    
>+    if (shouldApply == DontApplyAnimation)
>+        return;
>+
>     ASSERT(m_animatedPropertyType == determineAnimatedPropertyType(*targetElement));
> 
>     ASSERT(percentage >= 0 && percentage <= 1);
>@@ -102,6 +108,12 @@ void SVGAnimateElementBase::calculateAnimatedValue(float percentage, unsigned re
>     ASSERT(m_fromType->type() == m_animatedPropertyType);
>     ASSERT(m_toType);
> 
>+    if (shouldApply == ApplyXMLAnimation || shouldApply == ApplyXMLandCSSAnimation) {
>+        // SVG DOM animVal animation code-path.
>+        if (m_animator->findAnimatedPropertiesForAttributeName(*targetElement, attributeName).isEmpty())
>+            return;
>+    }
>+
>     SVGAnimateElementBase& resultAnimationElement = downcast<SVGAnimateElementBase>(*resultElement);
>     ASSERT(resultAnimationElement.m_animatedType);
>     ASSERT(resultAnimationElement.m_animatedPropertyType == m_animatedPropertyType);

Actions: View | Formatted Diff | Diff

Attachments on bug 192591: 357052 | 357072