Attachment 357046 Details for Bug 192586 – Patch

[patch] Patch

bug-192586-20181211153203.patch (text/plain), 2.54 KB, created by Yacine Bandou on 2018-12-11 06:32:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yacine Bandou

Created: 2018-12-11 06:32:10 PST

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 238446
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b6d4dff63cbdbc284e9a1bae4c552ccf487338e9..bb4954f22f4d9846a206dfefcdd546d00d10b9fe 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2018-12-11  Yacine Bandou  <yacine.bandou@softathome.com>
>+
>+        [WebAudio] Call AudioContext::uninitialize() immediately when the AudioContext is stopped
>+        https://bugs.webkit.org/show_bug.cgi?id=192586
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When WebProcess is killed, AudioContext::uninitialize() is not called immediately in the stop so
>+        the AudioDestinationNode is not destroyed.
>+
>+         In my case, I have a resource device manager, the output audio device is reserved when AudioDestinationNode
>+         is instantiated and it is released when AudioDestinationNode is destroyed, thus when the webprocess is killed,
>+         the resources leak.
>+
>+         AudioContext::uninitialize() is not called immediately since commit baa073da82c04c74a501c8c8a513a2d50195dff8.
>+         This modification can now be reverted without regression in WebAudio tests.
>+
>+        Test: webaudio/mediaelementaudiosourcenode-gc.html
>+
>+        * Modules/webaudio/AudioContext.cpp:
>+        (WebCore::AudioContext::stop):
>+
> 2018-11-22  Javier Fernandez  <jfernandez@igalia.com>
> 
>         Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
>diff --git a/Source/WebCore/Modules/webaudio/AudioContext.cpp b/Source/WebCore/Modules/webaudio/AudioContext.cpp
>index c54282ff53484d99cac38aa815aaa82ca53ca539..d940dc0f7b59a11841e115306860ecbd832017b0 100644
>--- a/Source/WebCore/Modules/webaudio/AudioContext.cpp
>+++ b/Source/WebCore/Modules/webaudio/AudioContext.cpp
>@@ -314,16 +314,8 @@ void AudioContext::stop()
> 
>     m_eventQueue->close();
> 
>-    // Don't call uninitialize() immediately here because the ScriptExecutionContext is in the middle
>-    // of dealing with all of its ActiveDOMObjects at this point. uninitialize() can de-reference other
>-    // ActiveDOMObjects so let's schedule uninitialize() to be called later.
>-    // FIXME: see if there's a more direct way to handle this issue.
>-    // FIXME: This sounds very wrong. The whole idea of stop() is that it stops everything, and if we
>-    // schedule some observable work for later, the work likely happens at an inappropriate time.
>-    callOnMainThread([this] {
>-        uninitialize();
>-        clear();
>-    });
>+    uninitialize();
>+    clear();
> }
> 
> bool AudioContext::canSuspendForDocumentSuspension() const

Actions: View | Formatted Diff | Diff

Attachments on bug 192586: 357046 | 357049 | 357059