Attachment 357044 Details for Bug 192584 – Patch

[patch] Patch

bug-192584-20181211184914.patch (text/plain), 28.33 KB, created by Fujii Hironori on 2018-12-11 01:49:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-12-11 01:49:15 PST

Size: 28.33 KB

patch

obsolete

>Subversion Revision: 239061
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 477c69df84175ebba3059b89a92aec96ae63eee2..6d509aca3edd742ea938162db42c8cd55b682f61 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,42 @@
>+2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] Fix warning -Wmissing-field-initializers
>+        https://bugs.webkit.org/show_bug.cgi?id=192584
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Initialize a struct with '{ }' instead of '= {0}'.
>+
>+        No new tests, no behavior changes.
>+
>+        * platform/graphics/win/FontCacheWin.cpp:
>+        (WebCore::FontCache::lastResortFallbackFont):
>+        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
>+        (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):
>+        * platform/win/ClipboardUtilitiesWin.cpp:
>+        (WebCore::setFileDescriptorData):
>+        (WebCore::setFileContentData):
>+        (WebCore::setUCharData):
>+        (WebCore::setUtf8Data):
>+        (WebCore::setCFData):
>+        * platform/win/CursorWin.cpp:
>+        (WebCore::createSharedCursor):
>+        * platform/win/DefWndProcWindowClass.cpp:
>+        (WebCore::registerClass):
>+        * platform/win/DragImageWin.cpp:
>+        (WebCore::createDragImageIconForCachedImageFilename):
>+        * platform/win/PasteboardWin.cpp:
>+        (WebCore::writeURL):
>+        (WebCore::Pasteboard::writeString):
>+        (WebCore::Pasteboard::writeRangeToDataObject):
>+        (WebCore::Pasteboard::writePlainTextToDataObject):
>+        (WebCore::writeFileToDataObject):
>+        (WebCore::Pasteboard::writeMarkup):
>+        * platform/win/PopupMenuWin.cpp:
>+        (WebCore::PopupMenuWin::show):
>+        * platform/win/SSLKeyGeneratorWin.cpp:
>+        (WebCore::WebCore::signedPublicKeyAndChallengeString):
>+
> 2018-12-10  Antti Koivisto  <antti@apple.com>
> 
>         Rename "forced style recalc" to "full style rebuild"
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0dc71457dc022e32dfe19ca268c180b8e20aafd3..a8212d2f79d080c391d863f8e2189c5e2b4a31ef 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] Fix warning -Wmissing-field-initializers
>+        https://bugs.webkit.org/show_bug.cgi?id=192584
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Initialize a struct with '{ }' instead of '= {0}'.
>+
>+        * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
>+        (WebKit::ProcessLauncher::launchProcess):
>+        * UIProcess/win/WebPopupMenuProxyWin.cpp:
>+        (WebKit::WebPopupMenuProxyWin::showPopupMenu):
>+        * UIProcess/win/WebView.cpp:
>+        (WebKit::WebView::initializeToolTipWindow):
>+        (WebKit::WebView::setToolTip):
>+
> 2018-12-10  Tim Horton  <timothy_horton@apple.com>
> 
>         Animated scrolling on Google Maps scrolls the page in addition to moving the map
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index f013f52d27b7c00ae8f77e7e3473cc31f79f27d3..8b6942ab49baeaae6350d17647e15bb47a865dbb 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] Fix warning -Wmissing-field-initializers
>+        https://bugs.webkit.org/show_bug.cgi?id=192584
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Initialize a struct with '{ }' instead of '= {0}'.
>+
>+        * WebKitMessageLoop.cpp:
>+        (WebKitMessageLoop::run):
>+        * WebView.cpp:
>+        (WebView::onMenuCommand):
>+        (WebView::gesture):
>+        (WebView::setShouldInvertColors):
>+        (WebView::initializeToolTipWindow):
>+        (WebView::setToolTip):
>+        (WebView::fullScreenClientForceRepaint):
>+
> 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Turn WritingDirection into an enum class
>diff --git a/Source/WebCore/platform/graphics/win/FontCacheWin.cpp b/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
>index 796287698173ab443c4478ea495b8af691323caa..f2d660da9fbf9459b9a55c3a56f5433f41ec952d 100644
>--- a/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
>+++ b/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
>@@ -374,7 +374,7 @@ Ref<Font> FontCache::lastResortFallbackFont(const FontDescription& fontDescripti
>     }
> 
>     // Fall back to Non-client metrics fonts.
>-    NONCLIENTMETRICS nonClientMetrics = {0};
>+    NONCLIENTMETRICS nonClientMetrics { };
>     nonClientMetrics.cbSize = sizeof(nonClientMetrics);
>     if (SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(nonClientMetrics), &nonClientMetrics, 0)) {
>         if (simpleFont = fontFromDescriptionAndLogFont(fontDescription, nonClientMetrics.lfMessageFont, fallbackFontName))
>diff --git a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp
>index 16b6b5dff8005c4fa4b8722385d29733484b2cd2..f246858af500d8e45e7ce5c85906b0909947b70b 100644
>--- a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp
>+++ b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp
>@@ -61,7 +61,7 @@ void MediaPlayerPrivateFullscreenWindow::createWindow(HWND parentHwnd)
>     static ATOM windowAtom;
>     static LPCWSTR windowClassName = L"MediaPlayerPrivateFullscreenWindowClass";
>     if (!windowAtom) {
>-        WNDCLASSEX wcex = {0};
>+        WNDCLASSEX wcex { };
>         wcex.cbSize = sizeof(wcex);
>         wcex.style = CS_HREDRAW | CS_VREDRAW;
>         wcex.lpfnWndProc = staticWndProc;
>@@ -72,7 +72,7 @@ void MediaPlayerPrivateFullscreenWindow::createWindow(HWND parentHwnd)
> 
>     ASSERT(!m_hwnd);
> 
>-    MONITORINFO mi = {0};
>+    MONITORINFO mi { };
>     mi.cbSize = sizeof(MONITORINFO);
>     if (!GetMonitorInfo(MonitorFromWindow(parentHwnd, MONITOR_DEFAULTTONEAREST), &mi))
>         return;
>diff --git a/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp b/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp
>index 790a82f8b671100a162e53ed89797cd9078efff5..4c52bc0fe915c5256d6b502a967b8246018164cd 100644
>--- a/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp
>+++ b/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp
>@@ -424,7 +424,7 @@ void setFileDescriptorData(IDataObject* dataObject, int size, const String& pass
> {
>     String pathname = passedPathname;
> 
>-    STGMEDIUM medium = { 0 };
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     medium.hGlobal = ::GlobalAlloc(GPTR, sizeof(FILEGROUPDESCRIPTOR));
>@@ -446,7 +446,7 @@ void setFileDescriptorData(IDataObject* dataObject, int size, const String& pass
> 
> void setFileContentData(IDataObject* dataObject, int size, void* dataBlob)
> {
>-    STGMEDIUM medium = { 0 };
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     medium.hGlobal = ::GlobalAlloc(GPTR, size);
>@@ -754,7 +754,7 @@ void getCFData(IDataObject* data, FORMATETC* format, Vector<String>& dataStrings
> 
> void setUCharData(IDataObject* data, FORMATETC* format, const Vector<String>& dataStrings)
> {
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     medium.hGlobal = createGlobalData(dataStrings.first());
>@@ -766,7 +766,7 @@ void setUCharData(IDataObject* data, FORMATETC* format, const Vector<String>& da
> 
> void setUtf8Data(IDataObject* data, FORMATETC* format, const Vector<String>& dataStrings)
> {
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     CString charString = dataStrings.first().utf8();
>@@ -785,7 +785,7 @@ void setUtf8Data(IDataObject* data, FORMATETC* format, const Vector<String>& dat
> #if USE(CF)
> void setCFData(IDataObject* data, FORMATETC* format, const Vector<String>& dataStrings)
> {
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     SIZE_T dropFilesSize = sizeof(DROPFILES) + (sizeof(WCHAR) * (dataStrings.first().length() + 2));
>diff --git a/Source/WebCore/platform/win/CursorWin.cpp b/Source/WebCore/platform/win/CursorWin.cpp
>index b4ffbc5cf78909e0f3e33ff4f21c090853e47e8a..d5c1f3fce664e17976f23b4ce7ebc5f5ee4bcd84 100644
>--- a/Source/WebCore/platform/win/CursorWin.cpp
>+++ b/Source/WebCore/platform/win/CursorWin.cpp
>@@ -111,7 +111,7 @@ static Ref<SharedCursor> createSharedCursor(Image* img, const IntPoint& hotSpot)
>         SelectObject(andMaskDC.get(), oldAndMask);
>         SelectObject(xorMaskDC.get(), oldXorMask);
> 
>-        ICONINFO icon = {0};
>+        ICONINFO icon { };
>         icon.fIcon = FALSE;
>         icon.xHotspot = effectiveHotSpot.x();
>         icon.yHotspot = effectiveHotSpot.y();
>diff --git a/Source/WebCore/platform/win/DefWndProcWindowClass.cpp b/Source/WebCore/platform/win/DefWndProcWindowClass.cpp
>index b07a6dee35ade99420e8244f943a86947a503ed4..faeb6697596725bcf777497fb12cdd6c96bc8250 100644
>--- a/Source/WebCore/platform/win/DefWndProcWindowClass.cpp
>+++ b/Source/WebCore/platform/win/DefWndProcWindowClass.cpp
>@@ -35,7 +35,7 @@ static const wchar_t className[] = L"DefWndProcWindowClass";
> 
> static ATOM registerClass()
> {
>-    WNDCLASSW wndClass = {0};
>+    WNDCLASSW wndClass { };
>     wndClass.lpszClassName = className;
>     wndClass.lpfnWndProc = ::DefWindowProcW;
>     wndClass.hInstance = instanceHandle();
>diff --git a/Source/WebCore/platform/win/DragImageWin.cpp b/Source/WebCore/platform/win/DragImageWin.cpp
>index a6b672fc727fe8379a2d0f7e0460716960cfbb87..8363e1773a0a5f3b118080387896aaf6efbc4145 100644
>--- a/Source/WebCore/platform/win/DragImageWin.cpp
>+++ b/Source/WebCore/platform/win/DragImageWin.cpp
>@@ -73,7 +73,7 @@ DragImageRef dissolveDragImageToFraction(DragImageRef image, float)
>         
> DragImageRef createDragImageIconForCachedImageFilename(const String& filename)
> {
>-    SHFILEINFO shfi = {0};
>+    SHFILEINFO shfi { };
>     String fname = filename;
>     if (FAILED(SHGetFileInfo(stringToNullTerminatedWChar(fname).data(), FILE_ATTRIBUTE_NORMAL, &shfi, sizeof(shfi), SHGFI_ICON | SHGFI_USEFILEATTRIBUTES)))
>         return 0;
>diff --git a/Source/WebCore/platform/win/PasteboardWin.cpp b/Source/WebCore/platform/win/PasteboardWin.cpp
>index d5967a5820c97ae28c625a50d8038e00ee25dd2a..f4565ce05f68c86572e68b09e53d5bb10073c07f 100644
>--- a/Source/WebCore/platform/win/PasteboardWin.cpp
>+++ b/Source/WebCore/platform/win/PasteboardWin.cpp
>@@ -373,7 +373,7 @@ static bool writeURL(WCDataObject *data, const URL& url, String title, bool with
>             title = url.host().toString();
>     }
> 
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     medium.hGlobal = createGlobalData(url, title);
>@@ -417,7 +417,7 @@ void Pasteboard::writeString(const String& type, const String& data)
>     }
> 
>     if (winType == ClipboardDataTypeText) {
>-        STGMEDIUM medium = {0};
>+        STGMEDIUM medium { };
>         medium.tymed = TYMED_HGLOBAL;
>         medium.hGlobal = createGlobalData(data);
>         if (!medium.hGlobal)
>@@ -440,7 +440,7 @@ void Pasteboard::writeRangeToDataObject(Range& selectedRange, Frame& frame)
>     if (!m_writableDataObject)
>         return;
> 
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     Vector<char> data;
>@@ -505,7 +505,7 @@ void Pasteboard::writePlainTextToDataObject(const String& text, SmartReplaceOpti
>     if (!m_writableDataObject)
>         return;
> 
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     String str = text;
>@@ -606,7 +606,7 @@ static HRESULT writeFileToDataObject(IDataObject* dataObject, HGLOBAL fileDescri
> {
>     HRESULT hr = S_OK;
>     FORMATETC* fe;
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     if (!fileDescriptor || !fileContent)
>@@ -1063,7 +1063,7 @@ void Pasteboard::writeMarkup(const String& markup)
>     Vector<char> data;
>     markupToCFHTML(markup, "", data);
> 
>-    STGMEDIUM medium = {0};
>+    STGMEDIUM medium { };
>     medium.tymed = TYMED_HGLOBAL;
> 
>     medium.hGlobal = createGlobalData(data);
>diff --git a/Source/WebCore/platform/win/PopupMenuWin.cpp b/Source/WebCore/platform/win/PopupMenuWin.cpp
>index 1bb17457c490121c4de1d911549761bc3d71635d..35bc4e79bf96539976344e724827a0562a625c6d 100644
>--- a/Source/WebCore/platform/win/PopupMenuWin.cpp
>+++ b/Source/WebCore/platform/win/PopupMenuWin.cpp
>@@ -161,7 +161,7 @@ void PopupMenuWin::show(const IntRect& r, FrameView* view, int index)
>         shouldAnimate = FALSE;
> 
>     if (shouldAnimate) {
>-        RECT viewRect = {0};
>+        RECT viewRect { };
>         ::GetWindowRect(hostWindow, &viewRect);
>         if (!::IsRectEmpty(&viewRect))
>             ::AnimateWindow(m_popup, defaultAnimationDuration, AW_BLEND);
>diff --git a/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp b/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp
>index de20b8d09ac50b172e5d37b6066e17b4674af886..df35353a6cb80dd648dfd27f56b06a57cc8be1e8 100644
>--- a/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp
>+++ b/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp
>@@ -60,7 +60,7 @@ String WebCore::signedPublicKeyAndChallengeString(unsigned index, const String&
>         if (!CryptExportPublicKeyInfo(hContext, AT_KEYEXCHANGE, X509_ASN_ENCODING, pPubInfo, &dwPubInfoLength))
>             break;
> 
>-        CERT_KEYGEN_REQUEST_INFO requestInfo = { 0 };
>+        CERT_KEYGEN_REQUEST_INFO requestInfo { };
>         requestInfo.dwVersion = CERT_KEYGEN_REQUEST_V1;
>         requestInfo.pwszChallengeString = L"";
>         requestInfo.SubjectPublicKeyInfo = *pPubInfo;
>@@ -71,7 +71,7 @@ String WebCore::signedPublicKeyAndChallengeString(unsigned index, const String&
>         auto localChallengeWide = stringToNullTerminatedWChar(localChallenge);
>         requestInfo.pwszChallengeString = const_cast<wchar_t*>(localChallengeWide.data());
> 
>-        CRYPT_ALGORITHM_IDENTIFIER signAlgo = { 0 };
>+        CRYPT_ALGORITHM_IDENTIFIER signAlgo { };
>         signAlgo.pszObjId = szOID_RSA_SHA1RSA;
> 
>         DWORD dwEncodedLength;
>diff --git a/Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp b/Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp
>index 8fdf717777f0a86272780a4e8d2c9519666ce608..0f7607b5d15b5860e81277b183947274648f48bd 100644
>--- a/Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp
>+++ b/Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp
>@@ -87,11 +87,11 @@ void ProcessLauncher::launchProcess()
> 
>     auto commandLine = stringToNullTerminatedWChar(commandLineBuilder.toString());
> 
>-    STARTUPINFO startupInfo = { 0 };
>+    STARTUPINFO startupInfo { };
>     startupInfo.cb = sizeof(startupInfo);
>     startupInfo.dwFlags = STARTF_USESHOWWINDOW;
>     startupInfo.wShowWindow = SW_HIDE;
>-    PROCESS_INFORMATION processInformation = { 0 };
>+    PROCESS_INFORMATION processInformation { };
>     BOOL result = ::CreateProcess(0, commandLine.data(), 0, 0, true, 0, 0, 0, &startupInfo, &processInformation);
> 
>     // We can now close the client identifier handle.
>diff --git a/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp b/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp
>index 2243dfde62c0a84355ada9a60e3628c79cc8f70e..a0f963d3774319968e9f4f65544bdb6404f11fde 100644
>--- a/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp
>+++ b/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp
>@@ -218,7 +218,7 @@ void WebPopupMenuProxyWin::showPopupMenu(const IntRect& rect, TextDirection, dou
>         shouldAnimate = FALSE;
> 
>     if (shouldAnimate) {
>-        RECT viewRect = {0};
>+        RECT viewRect { };
>         ::GetWindowRect(hostWindow, &viewRect);
> 
>         if (!::IsRectEmpty(&viewRect)) {
>diff --git a/Source/WebKit/UIProcess/win/WebView.cpp b/Source/WebKit/UIProcess/win/WebView.cpp
>index ed1d4ec32217926c6b6c929ae0bfc140332616d3..f9b885dc1e2352883b4f6a22ed875f362ee85035 100644
>--- a/Source/WebKit/UIProcess/win/WebView.cpp
>+++ b/Source/WebKit/UIProcess/win/WebView.cpp
>@@ -653,7 +653,7 @@ void WebView::initializeToolTipWindow()
>     if (!m_toolTipWindow)
>         return;
> 
>-    TOOLINFO info = { 0 };
>+    TOOLINFO info { };
>     info.cbSize = sizeof(info);
>     info.uFlags = TTF_IDISHWND | TTF_SUBCLASS;
>     info.uId = reinterpret_cast<UINT_PTR>(m_window);
>@@ -871,7 +871,7 @@ void WebView::setToolTip(const String& toolTip)
>         return;
> 
>     if (!toolTip.isEmpty()) {
>-        TOOLINFO info = { 0 };
>+        TOOLINFO info { };
>         info.cbSize = sizeof(info);
>         info.uFlags = TTF_IDISHWND;
>         info.uId = reinterpret_cast<UINT_PTR>(nativeWindow());
>diff --git a/Source/WebKitLegacy/win/WebKitMessageLoop.cpp b/Source/WebKitLegacy/win/WebKitMessageLoop.cpp
>index f76a66cd42801745009ac397e9702b2dd39086ea..937a6669e908fee607bc41d5b9277c7a601ded69 100644
>--- a/Source/WebKitLegacy/win/WebKitMessageLoop.cpp
>+++ b/Source/WebKitLegacy/win/WebKitMessageLoop.cpp
>@@ -84,7 +84,7 @@ ULONG WebKitMessageLoop::Release()
> 
> HRESULT WebKitMessageLoop::run(_In_ HACCEL hAccelTable)
> {
>-    MSG msg = { 0 };
>+    MSG msg { };
> 
>     while (GetMessage(&msg, 0, 0, 0)) {
>         performMessageLoopTasks();
>diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
>index e4b2e5f5c57503d25edf27b1bf79eaa9da404a16..6ae21ecfb1d89d7d69806cccca3ee57b2b73ee37 100644
>--- a/Source/WebKitLegacy/win/WebView.cpp
>+++ b/Source/WebKitLegacy/win/WebView.cpp
>@@ -1785,7 +1785,7 @@ void WebView::onMenuCommand(WPARAM wParam, LPARAM lParam)
>     HMENU hMenu = reinterpret_cast<HMENU>(lParam);
>     unsigned index = static_cast<unsigned>(wParam);
> 
>-    MENUITEMINFO menuItemInfo = { 0 };
>+    MENUITEMINFO menuItemInfo { };
>     menuItemInfo.cbSize = sizeof(menuItemInfo);
>     menuItemInfo.fMask = MIIM_STRING;
>     ::GetMenuItemInfo(hMenu, index, true, &menuItemInfo);
>@@ -1997,7 +1997,7 @@ bool WebView::gesture(WPARAM wParam, LPARAM lParam)
> 
>     HGESTUREINFO gestureHandle = reinterpret_cast<HGESTUREINFO>(lParam);
>     
>-    GESTUREINFO gi = {0};
>+    GESTUREINFO gi { };
>     gi.cbSize = sizeof(GESTUREINFO);
> 
>     if (!GetGestureInfoPtr()(gestureHandle, reinterpret_cast<PGESTUREINFO>(&gi)))
>@@ -2484,7 +2484,7 @@ void WebView::setShouldInvertColors(bool shouldInvertColors)
>         m_layerTreeHost->setShouldInvertColors(shouldInvertColors);
> #endif
> 
>-    RECT windowRect = {0};
>+    RECT windowRect { };
>     frameRect(&windowRect);
> 
>     // repaint expects logical pixels, so rescale here.
>@@ -3191,7 +3191,7 @@ void WebView::initializeToolTipWindow()
>     if (!m_toolTipHwnd)
>         return;
> 
>-    TOOLINFO info = {0};
>+    TOOLINFO info { };
>     info.cbSize = sizeof(info);
>     info.uFlags = TTF_IDISHWND | TTF_SUBCLASS ;
>     info.uId = reinterpret_cast<UINT_PTR>(m_viewWindow);
>@@ -3213,7 +3213,7 @@ void WebView::setToolTip(const String& toolTip)
>     m_toolTip = toolTip;
> 
>     if (!m_toolTip.isEmpty()) {
>-        TOOLINFO info = {0};
>+        TOOLINFO info { };
>         info.cbSize = sizeof(info);
>         info.uFlags = TTF_IDISHWND;
>         info.uId = reinterpret_cast<UINT_PTR>(m_viewWindow);
>@@ -7576,7 +7576,7 @@ void WebView::fullScreenClientDidExitFullScreen()
> void WebView::fullScreenClientForceRepaint()
> {
>     ASSERT(m_fullscreenController);
>-    RECT windowRect = {0};
>+    RECT windowRect { };
>     frameRect(&windowRect);
>     repaint(windowRect, true /*contentChanged*/, true /*immediate*/, false /*contentOnly*/);
>     m_fullscreenController->repaintCompleted();
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c3ecd73e1c8c91b60992950203416e02ff03712c..85c124fdc7895951ee7a2e366dcadaeaf7196b71 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,34 @@
>+2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] Fix warning -Wmissing-field-initializers
>+        https://bugs.webkit.org/show_bug.cgi?id=192584
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Initialize a struct with '{ }' instead of '= {0}'.
>+
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (runTest):
>+        * DumpRenderTree/win/EventSender.cpp:
>+        (makeMsg):
>+        (replaySavedEvents):
>+        (beginDragWithFilesCallback):
>+        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
>+        (createBitmapContextFromWebView):
>+        * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
>+        (updateMenuItemForHistoryItem):
>+        * MiniBrowser/win/WinMain.cpp:
>+        (wWinMain):
>+        * TestWebKitAPI/win/HostWindow.cpp:
>+        (TestWebKitAPI::HostWindow::clientRect const):
>+        (TestWebKitAPI::HostWindow::registerWindowClass):
>+        * TestWebKitAPI/win/PlatformWebViewWin.cpp:
>+        (TestWebKitAPI::PlatformWebView::registerWindowClass):
>+        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
>+        (WTR::registerWindowClass):
>+        (WTR::PlatformWebView::windowFrame):
>+        (WTR::PlatformWebView::windowSnapshotImage):
>+
> 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index 9f91a2cba3701abfab0b86e6dbb71ff33497fb94..8e0929a2f7a77147d1dc6eeccc2f5097044e27ef 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -1231,7 +1231,7 @@ static void runTest(const string& inputLine)
>     workQueue.clear();
>     workQueue.setFrozen(false);
> 
>-    MSG msg = { 0 };
>+    MSG msg { };
>     HWND hostWindow;
>     webView->hostWindow(&hostWindow);
> 
>diff --git a/Tools/DumpRenderTree/win/EventSender.cpp b/Tools/DumpRenderTree/win/EventSender.cpp
>index c9080075dc78c56643c12ff9cc7980499a0015e3..4a3c63b9402ae44d1697eb1e07c2b5584bcb8dc9 100644
>--- a/Tools/DumpRenderTree/win/EventSender.cpp
>+++ b/Tools/DumpRenderTree/win/EventSender.cpp
>@@ -120,7 +120,7 @@ static DWORD currentEventTime()
> 
> static MSG makeMsg(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
> {
>-    MSG result = {0};
>+    MSG result { };
>     result.hwnd = hwnd;
>     result.message = message;
>     result.wParam = wParam;
>@@ -362,7 +362,7 @@ void replaySavedEvents(HRESULT* oleDragAndDropReturnValue)
> {
>     replayingSavedEvents = true;
>   
>-    MSG msg = { 0 };
>+    MSG msg { };
> 
>     while (startOfQueue < endOfQueue && !msgQueue[startOfQueue].delay) {
>         msg = msgQueue[startOfQueue++].msg;
>@@ -696,7 +696,7 @@ static JSValueRef beginDragWithFilesCallback(JSContextRef context, JSObjectRef f
>     // We should append "0" in the end of |files| so that |DragQueryFileW| retrieved the number of files correctly from Ole Clipboard.
>     files.append(0);
> 
>-    STGMEDIUM hDropMedium = {0};
>+    STGMEDIUM hDropMedium { };
>     hDropMedium.tymed = TYMED_HGLOBAL;
>     SIZE_T dropFilesSize = sizeof(DROPFILES) + (sizeof(WCHAR) * files.size());
>     hDropMedium.hGlobal = GlobalAlloc(GMEM_MOVEABLE | GMEM_DDESHARE, dropFilesSize);
>@@ -713,7 +713,7 @@ static JSValueRef beginDragWithFilesCallback(JSContextRef context, JSObjectRef f
>         data[i] = files[i];
>     GlobalUnlock(hDropMedium.hGlobal); 
> 
>-    STGMEDIUM hFileNameMedium = {0};
>+    STGMEDIUM hFileNameMedium { };
>     hFileNameMedium.tymed = TYMED_HGLOBAL;
>     SIZE_T hFileNameSize = sizeof(WCHAR) * files.size();
>     hFileNameMedium.hGlobal = GlobalAlloc(GMEM_MOVEABLE | GMEM_DDESHARE, hFileNameSize);
>@@ -925,7 +925,7 @@ static JSClassRef getClass(JSContextRef context)
>     static JSClassRef eventSenderClass = 0;
> 
>     if (!eventSenderClass) {
>-        JSClassDefinition classDefinition = {0};
>+        JSClassDefinition classDefinition { };
>         classDefinition.staticFunctions = staticFunctions;
>         classDefinition.staticValues = staticValues;
> 
>diff --git a/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp b/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp
>index 4495b74674af407276a5681d3eac9fb76eeaae79..a9ba69183118bb8323c8d49b1fd339a51f539b60 100644
>--- a/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp
>+++ b/Tools/DumpRenderTree/win/PixelDumpSupportWin.cpp
>@@ -62,7 +62,7 @@ RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool increme
>     if (!GetWindowRect(webViewWindow, &frame))
>         return nullptr;
> 
>-    BITMAPINFO bmp = {0};
>+    BITMAPINFO bmp { };
>     bmp.bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
>     bmp.bmiHeader.biWidth = frame.right - frame.left;
>     bmp.bmiHeader.biHeight = -(frame.bottom - frame.top);
>@@ -79,7 +79,7 @@ RefPtr<BitmapContext> createBitmapContextFromWebView(bool onscreen, bool increme
>     ::SelectObject(memoryDC.get(), bitmap);
>     SendMessage(webViewWindow, WM_PRINT, reinterpret_cast<WPARAM>(memoryDC.get()), PRF_CLIENT | PRF_CHILDREN | PRF_OWNED);
> 
>-    BITMAP info = {0};
>+    BITMAP info { };
>     GetObject(bitmap, sizeof(info), &info);
>     ASSERT(info.bmBitsPixel == 32);
> 
>diff --git a/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp b/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp
>index f6fcd5794f79f692abe772a8273b71a8470dd338..d6430b44021f2175c1cfc8269ce49054ac9af16b 100644
>--- a/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp
>+++ b/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp
>@@ -329,7 +329,7 @@ static void updateMenuItemForHistoryItem(HMENU menu, IWebHistoryItem& historyIte
> {
>     UINT menuID = IDM_HISTORY_LINK0 + currentHistoryItem;
> 
>-    MENUITEMINFO menuItemInfo = { 0 };
>+    MENUITEMINFO menuItemInfo { };
>     menuItemInfo.cbSize = sizeof(MENUITEMINFO);
>     menuItemInfo.fMask = MIIM_TYPE;
>     menuItemInfo.fType = MFT_STRING;
>diff --git a/Tools/MiniBrowser/win/WinMain.cpp b/Tools/MiniBrowser/win/WinMain.cpp
>index 426a09eb0e6ecc785801a77b2007851ac4700af4..e92cb49c4844f1a6bfea3cdfb611173e39f2792c 100644
>--- a/Tools/MiniBrowser/win/WinMain.cpp
>+++ b/Tools/MiniBrowser/win/WinMain.cpp
>@@ -41,7 +41,7 @@ int WINAPI wWinMain(_In_ HINSTANCE hInstance, _In_opt_ HINSTANCE hPrevInstance,
>     _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);
> #endif
> 
>-    MSG msg = {0};
>+    MSG msg { };
>     HACCEL hAccelTable;
> 
>     INITCOMMONCONTROLSEX InitCtrlEx;
>diff --git a/Tools/TestWebKitAPI/win/HostWindow.cpp b/Tools/TestWebKitAPI/win/HostWindow.cpp
>index 74c947d9eb015e9f8847abbab41e6cb551fafcef..406b9c522625789a67a8c997d1e41f1bd65dbb10 100644
>--- a/Tools/TestWebKitAPI/win/HostWindow.cpp
>+++ b/Tools/TestWebKitAPI/win/HostWindow.cpp
>@@ -50,9 +50,9 @@ HostWindow::~HostWindow()
> 
> RECT HostWindow::clientRect() const
> {
>-    RECT rect = {0};
>+    RECT rect { };
>     if (!::GetClientRect(m_window, &rect)) {
>-        RECT emptyRect = {0};
>+        RECT emptyRect { };
>         return emptyRect;
>     }
>     return rect;
>@@ -65,7 +65,7 @@ void HostWindow::registerWindowClass()
>         return;
>     initialized = true;
> 
>-    WNDCLASSEXW wndClass = {0};
>+    WNDCLASSEXW wndClass { };
>     wndClass.cbSize = sizeof(wndClass);
>     wndClass.style = CS_HREDRAW | CS_VREDRAW;
>     wndClass.lpfnWndProc = wndProc;
>diff --git a/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp b/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>index 1c0c689e1615b91147bce09be7c7647d57abba27..3eb6d5c8366529e86ec93e495863d2ed7dc99b4b 100644
>--- a/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>+++ b/Tools/TestWebKitAPI/win/PlatformWebViewWin.cpp
>@@ -47,7 +47,7 @@ void PlatformWebView::registerWindowClass()
>         return;
>     initialized = true;
> 
>-    WNDCLASSEXW wndClass = {0};
>+    WNDCLASSEXW wndClass { };
>     wndClass.cbSize = sizeof(wndClass);
>     wndClass.style = CS_HREDRAW | CS_VREDRAW;
>     wndClass.lpfnWndProc = wndProc;
>diff --git a/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp b/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>index dc9d3a1efdfb75f60e51273fe60b0d4cfe41e05f..f80c26e5a648d7e7ac3e87d71565af63b56589ab 100644
>--- a/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>+++ b/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
>@@ -49,7 +49,7 @@ static void registerWindowClass()
>         return;
>     initialized = true;
> 
>-    WNDCLASSEXW wndClass = {0};
>+    WNDCLASSEXW wndClass { };
>     wndClass.cbSize = sizeof(wndClass);
>     wndClass.style = CS_HREDRAW | CS_VREDRAW;
>     wndClass.lpfnWndProc = DefWindowProc;
>@@ -117,7 +117,7 @@ void PlatformWebView::focus()
> 
> WKRect PlatformWebView::windowFrame()
> {
>-    WKRect wkFrame = {0};
>+    WKRect wkFrame { };
>     RECT r;
> 
>     if (::GetWindowRect(m_window, &r)) {
>@@ -203,7 +203,7 @@ cairo_surface_t* PlatformWebView::windowSnapshotImage()
>     WebCore::HWndDC windowDC(m_window);
>     auto memoryDC = adoptGDIObject(::CreateCompatibleDC(windowDC));
> 
>-    BITMAPINFO bitmapInfo = {0};
>+    BITMAPINFO bitmapInfo { };
>     WKRect wkFrame = windowFrame();
>     bitmapInfo.bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
>     bitmapInfo.bmiHeader.biWidth = width;
>@@ -230,7 +230,7 @@ cairo_surface_t* PlatformWebView::windowSnapshotImage()
>         0,
>         SRCCOPY);
> 
>-    BITMAP bitmapTag = {0};
>+    BITMAP bitmapTag { };
>     GetObject(bitmap.get(), sizeof(bitmapTag), &bitmapTag);
>     ASSERT(bitmapTag.bmBitsPixel == 32);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192584: 357042 | 357044