WebKit Bugzilla
Attachment 357039 Details for
Bug 192581
: [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192581-20181211163951.patch (text/plain), 1.76 KB, created by
Fujii Hironori
on 2018-12-10 23:39:52 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2018-12-10 23:39:52 PST
Size:
1.76 KB
patch
obsolete
>Subversion Revision: 239061 >diff --git a/Source/WebKitLegacy/ChangeLog b/Source/WebKitLegacy/ChangeLog >index 83eaff30abbb6ff852ea1f66c6d260edc39616e0..4bc1acab9df9d00d9a6209fcbd94ccb550607266 100644 >--- a/Source/WebKitLegacy/ChangeLog >+++ b/Source/WebKitLegacy/ChangeLog >@@ -1,3 +1,20 @@ >+2018-12-10 Fujii Hironori <Hironori.Fujii@sony.com> >+ >+ [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual] >+ https://bugs.webkit.org/show_bug.cgi?id=192581 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Conventionally, WebKit COM interface adds a new interface with >+ same name methods with the old interface. For example, both >+ IWebEditingDelegate and IWebEditingDelegate2 interfaces has >+ shouldInsertNode method. >+ >+ This is a part of public API, can't be renamed. >+ >+ * PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option >+ for WebKitLegacy >+ > 2018-12-06 Alex Christensen <achristensen@webkit.org> > > Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code >diff --git a/Source/WebKitLegacy/PlatformWin.cmake b/Source/WebKitLegacy/PlatformWin.cmake >index 02a0b0feb08c6198c774e267ec13cec2a01eabdb..c8dab369692fff122c6f075ddbf2a68243d844f9 100644 >--- a/Source/WebKitLegacy/PlatformWin.cmake >+++ b/Source/WebKitLegacy/PlatformWin.cmake >@@ -277,6 +277,10 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8) > endif () > endif () > >+if (COMPILER_IS_GCC_OR_CLANG) >+ WEBKIT_ADD_TARGET_CXX_FLAGS(WebKitLegacy -Wno-overloaded-virtual) >+endif () >+ > list(APPEND WebKitLegacy_SOURCES ${WebKitLegacy_INCLUDES} ${WebKitLegacy_SOURCES_Classes} ${WebKitLegacy_SOURCES_WebCoreSupport}) > > source_group(Includes FILES ${WebKitLegacy_INCLUDES})
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192581
:
357039
|
378531
|
378533