Attachment 357020 Details for Bug 192443 – Patch

[patch] Patch

bug-192443-20181210170107.patch (text/plain), 2.52 KB, created by Matt Baker on 2018-12-10 17:01:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-12-10 17:01:20 PST

Size: 2.52 KB

patch

obsolete

>Subversion Revision: 239050
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5937cafd2dedf7feeb075fe23a2a71c00280eb4b..28143ac69ad6aea9bb4862a2313d7891e8176fdd 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-10  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION (r238599): unable to select specific timeline
>+        https://bugs.webkit.org/show_bug.cgi?id=192443
>+        <rdar://problem/46608087>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When determining the trailing horizontal edge for TreeElement mouse
>+        events, TreeOutline should not assume that its containing DOM element
>+        is only as wide as its <ol> element.
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype.treeElementFromEvent):
>+
> 2018-12-10  Dean Jackson  <dino@apple.com>
> 
>         Use text/javascript as recommended by the HTML specification
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 72f2cfdaf17e6266b475ae9d417054d30edb33dc..baea55ddfbb58a0b41051a3265235f4ecd6d2713 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -888,12 +888,18 @@ WI.TreeOutline = class TreeOutline extends WI.Object
> 
>     treeElementFromEvent(event)
>     {
>-        let scrollContainer = this.element.parentElement;
>-
>+        // We can't take event.pageX to be our X coordinate, since the TreeElement
>+        // could be indented, in which case we can't rely on its DOM element to be
>+        // under the mouse.
>         // We choose this X coordinate based on the knowledge that our list
>         // items extend at least to the trailing edge of the outer <ol> container.
>         // In the no-word-wrap mode the outer <ol> may be wider than the tree container
>-        // (and partially hidden), in which case we are left to use only its trailing boundary.
>+        // (and partially hidden), in which case we use the edge of its container.
>+
>+        let scrollContainer = this.element.parentElement;
>+        if (scrollContainer.offsetWidth > this.element.offsetWidth)
>+            scrollContainer = this.element;
>+
>         // This adjustment is useful in order to find the inner-most tree element that
>         // lines up horizontally with the location of the event. If the mouse event
>         // happened in the space preceding a nested tree element (in the leading indentated

Actions: View | Formatted Diff | Diff

Attachments on bug 192443: 357005 | 357020