Attachment 356974 Details for Bug 191695 – patch

[patch] patch

style-recalc-throttle-ignore-force.patch (text/plain), 1.99 KB, created by Antti Koivisto on 2018-12-10 11:41:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2018-12-10 11:41:00 PST

Size: 1.99 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 239035)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,21 @@
>+2018-12-10  Antti Koivisto  <antti@apple.com>
>+
>+        Document should throttle style recalc even when m_pendingStyleRecalcShouldForce is true.
>+        https://bugs.webkit.org/show_bug.cgi?id=191695
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dom/Document.cpp:
>+        (WebCore::Document::scheduleStyleRecalc):
>+
>+        Don't test for m_pendingStyleRecalcShouldForce.
>+
>+        (WebCore::Document::hasPendingStyleRecalc const):
>+        (WebCore::Document::hasPendingForcedStyleRecalc const):
>+
>+        Don't base the pending status of these function on whether the timer is running.
>+        Instead check if the style is invalid.
>+
> 2018-12-10  Truitt Savell  <tsavell@apple.com>
> 
>         Unreviewed, rolling out r238965.
>Index: Source/WebCore/dom/Document.cpp
>===================================================================
>--- Source/WebCore/dom/Document.cpp	(revision 238995)
>+++ Source/WebCore/dom/Document.cpp	(working copy)
>@@ -1806,8 +1806,6 @@ void Document::scheduleStyleRecalc()
>     invalidateAccessKeyMap();
> 
>     auto shouldThrottleStyleRecalc = [&] {
>-        if (m_pendingStyleRecalcShouldForce)
>-            return false;
>         if (!view() || !view()->isVisuallyNonEmpty())
>             return false;
>         if (!page() || !page()->chrome().client().layerFlushThrottlingIsActive())
>@@ -1833,12 +1831,12 @@ void Document::unscheduleStyleRecalc()
> 
> bool Document::hasPendingStyleRecalc() const
> {
>-    return m_styleRecalcTimer.isActive() && !m_inStyleRecalc;
>+    return needsStyleRecalc() && !m_inStyleRecalc;
> }
> 
> bool Document::hasPendingForcedStyleRecalc() const
> {
>-    return m_styleRecalcTimer.isActive() && m_pendingStyleRecalcShouldForce;
>+    return hasPendingStyleRecalc() && m_pendingStyleRecalcShouldForce;
> }
> 
> void Document::resolveStyle(ResolveStyleType type)

Actions: View | Formatted Diff | Diff

Attachments on bug 191695: 354942 | 354953 | 355000 | 356974