Attachment 356912 Details for Bug 192538 – Patch

[patch] Patch

bug-192538-20181209002405.patch (text/plain), 1.56 KB, created by Wenson Hsieh on 2018-12-09 00:24:05 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-12-09 00:24:05 PST

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 239006
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 187fa779e3c2dd12d229fdc7feb472466065d30f..9920830a3fb9960864a5c420527270d4114e6ec8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS device] Crash when attempting to call -[_WKAttachment info] for an editable image
>+        https://bugs.webkit.org/show_bug.cgi?id=192538
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the crash by ensuring that the result of `-renderedDrawing` survives long enough to be wrapped by a
>+        `RetainPtr` in `-PNGRepresentation`. This isn't currently testable, since this codepath isn't supported on the
>+        iOS simulator; instead, I manually verified using MobileAttachments.app.
>+
>+        * UIProcess/ios/WKDrawingView.mm:
>+        (-[WKDrawingView renderedDrawing]):
>+
> 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Caret is obscured by finger when dragging over an editable element
>diff --git a/Source/WebKit/UIProcess/ios/WKDrawingView.mm b/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>index d0d903dea7279366be38b07c9e45cb95dad2b60f..d914b8cada430ed8c6e9a8d8bfcbdaa217963f6c 100644
>--- a/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>@@ -120,7 +120,7 @@ - (UIImage *)renderedDrawing
>     // an NSFileWrapper to be available synchronously.
>     dispatch_sync(_renderQueue.get(), ^{ });
> 
>-    return resultImage.get();
>+    return resultImage.autorelease();
> #endif
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192538: 356912