WebKit Bugzilla
Attachment 356894 Details for
Bug 192531
: Don't programmatically capitalize safe browsing warning buttons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192531-20181208174940.patch (text/plain), 3.06 KB, created by
Alex Christensen
on 2018-12-08 17:49:41 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2018-12-08 17:49:41 PST
Size:
3.06 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 239012) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2018-12-08 Alex Christensen <achristensen@webkit.org> >+ >+ Don't programmatically capitalize safe browsing warning buttons >+ https://bugs.webkit.org/show_bug.cgi?id=192531 >+ <rdar://problem/46417791> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This doesn't work so well in other languages. >+ Capitalize the source strings in English instead. >+ >+ * en.lproj/Localizable.strings: >+ > 2018-12-08 Frederic Wang <fwang@igalia.com> > > Allow control over child order when adding nodes to the scrolling tree >Index: Source/WebCore/en.lproj/Localizable.strings >=================================================================== >--- Source/WebCore/en.lproj/Localizable.strings (revision 239012) >+++ Source/WebCore/en.lproj/Localizable.strings (working copy) >@@ -317,7 +317,7 @@ > "Go" = "Go"; > > /* Action from safe browsing warning */ >-"Go back" = "Go back"; >+"Go Back" = "Go Back"; > > /* Google Safe Browsing */ > "Google Safe Browsing" = "Google Safe Browsing"; >@@ -656,7 +656,7 @@ > "Show Substitutions" = "Show Substitutions"; > > /* Action from safe browsing warning */ >-"Show details" = "Show details"; >+"Show Details" = "Show Details"; > > /* Title of the context menu item to show when PDFPlugin was used instead of a blocked plugin */ > "Show in blocked plug-in" = "Show in blocked plug-in"; >Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 239013) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2018-12-08 Alex Christensen <achristensen@webkit.org> >+ >+ Don't programmatically capitalize safe browsing warning buttons >+ https://bugs.webkit.org/show_bug.cgi?id=192531 >+ <rdar://problem/46417791> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/Cocoa/WKSafeBrowsingWarning.mm: >+ (makeButton): >+ > 2018-12-08 Frederic Wang <fwang@igalia.com> > > Allow control over child order when adding nodes to the scrolling tree >Index: Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm >=================================================================== >--- Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm (revision 239012) >+++ Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm (working copy) >@@ -177,10 +177,9 @@ static ButtonType *makeButton(WarningIte > { > NSString *title = nil; > if (item == WarningItem::ShowDetailsButton) >- title = WEB_UI_NSSTRING(@"Show details", "Action from safe browsing warning"); >+ title = WEB_UI_NSSTRING(@"Show Details", "Action from safe browsing warning"); > else >- title = WEB_UI_NSSTRING(@"Go back", "Action from safe browsing warning"); >- title = [title capitalizedString]; >+ title = WEB_UI_NSSTRING(@"Go Back", "Action from safe browsing warning"); > #if PLATFORM(MAC) > return [NSButton buttonWithTitle:title target:warning action:action]; > #else
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
darin
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192531
: 356894