Attachment 356853 Details for Bug 192524 – Patch

[patch] Patch

bug-192524-20181207164841.patch (text/plain), 2.18 KB, created by Wenson Hsieh on 2018-12-07 16:48:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-12-07 16:48:43 PST

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 238944
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f2b8e8c4640c871732713c8e3380109b8fd94724..882c9ae27ee24f42a8293e7ce580bf1d4e976857 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=192524
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
>+        (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
>+        (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
>+        first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
>+        wide selection rect and increases the width of the document; revealing this selection causes the web view to
>+        scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
>+        these window coordinates no longer correspond to the drop destination element in the document.
>+
>+        To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
>+        scroll horizontally after the first drop.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
>+
> 2018-12-06  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Attachment Support] Cloned attachment elements lose their unique identifiers
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html b/Tools/TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html
>index 7fc2bc3dfcc197ef269952b4ba5813a090213620..bf452c9ff9222153481d8e0490cc4002edda0025 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html
>@@ -14,7 +14,7 @@
>             white-space: nowrap;
>         }
> 
>-        #source {
>+        #source, #editor {
>             overflow: hidden;
>         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192524: 356853