WebKit Bugzilla
Attachment 356846 Details for
Bug 192521
: Animated scrolling on Google Maps scrolls the page in addition to moving the map
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192521-20181207154547.patch (text/plain), 2.64 KB, created by
Tim Horton
on 2018-12-07 15:45:48 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tim Horton
Created:
2018-12-07 15:45:48 PST
Size:
2.64 KB
patch
obsolete
>Subversion Revision: 238961 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 0d0e15c1c2e571d34c4d39d83e15c6a01107042a..9506ac7b4ace6f6a0cfff9b6a97093f84d9649a9 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,18 @@ >+2018-12-07 Tim Horton <timothy_horton@apple.com> >+ >+ Animated scrolling on Google Maps scrolls the page in addition to moving the map >+ https://bugs.webkit.org/show_bug.cgi?id=192521 >+ <rdar://problem/46382007> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Platform/spi/ios/UIKitSPI.h: >+ * UIProcess/ios/WKKeyboardScrollingAnimator.mm: >+ (-[WKKeyboardScrollViewAnimator rubberbandableDirections]): >+ Only do keyboard-based rubber-banding in directions that we can actually >+ scroll, not directions we can only finger-rubber-band in. This effectively >+ means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}". >+ > 2018-12-07 Truitt Savell <tsavell@apple.com> > > Unreviewed, rolling out r238947. >diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >index 56988c68e24658cc2059402ec1f821e1c8684212..443cdbb5e5363c8b3e23fb47b95e1d62730583da 100644 >--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h >+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >@@ -1049,8 +1049,8 @@ typedef NSInteger UICompositingMode; > - (void)_adjustForAutomaticKeyboardInfo:(NSDictionary *)info animated:(BOOL)animated lastAdjustment:(CGFloat*)lastAdjustment; > - (BOOL)_isScrollingToTop; > - (CGPoint)_animatedTargetOffset; >-- (BOOL)_canScrollX; >-- (BOOL)_canScrollY; >+- (BOOL)_canScrollWithoutBouncingX; >+- (BOOL)_canScrollWithoutBouncingY; > - (void)_setContentOffsetWithDecelerationAnimation:(CGPoint)contentOffset; > - (CGPoint)_adjustedContentOffsetForContentOffset:(CGPoint)contentOffset; > - (void)_flashScrollIndicatorsPersistingPreviousFlashes:(BOOL)persisting; >diff --git a/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm b/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm >index 98547c7269b70c9fa78c35b97a3a5c9c2365fd8f..9930ea1527eb35b965a82c0af5bc5377654cc7ca 100644 >--- a/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm >+++ b/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm >@@ -678,9 +678,9 @@ - (WebCore::RectEdges<bool>)rubberbandableDirections > > WebCore::RectEdges<bool> edges; > >- edges.setTop(scrollView._canScrollY); >+ edges.setTop(scrollView._canScrollWithoutBouncingY); > edges.setBottom(edges.top()); >- edges.setLeft(scrollView._canScrollX); >+ edges.setLeft(scrollView._canScrollWithoutBouncingX); > edges.setRight(edges.left()); > > return edges;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192521
: 356846