Attachment 356834 Details for Bug 192361 – Patch

[patch] Patch

bug-192361-20181207140143.patch (text/plain), 2.38 KB, created by Chris Dumez on 2018-12-07 14:01:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-12-07 14:01:43 PST

Size: 2.38 KB

patch

obsolete

>Subversion Revision: 238911
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 129bc043dbb9f99f147e20d1fbe24b4757f4b05d..36e3bba44e665f69e171cd56a8e2a6e0073d2cec 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-07  Chris Dumez  <cdumez@apple.com>
>+
>+        REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=192361
>+        <rdar://problem/46524903>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
>+        fixes the failures for me locally.
>+
>+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
>+
> 2018-12-06  Chris Dumez  <cdumez@apple.com>
> 
>         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
>diff --git a/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj b/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>index 6d7fa37d9ccef498e32838c0cd63715862b0449d..beb782894bb3d42df14b46bdbadc6155bcf179ac 100644
>--- a/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>+++ b/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>@@ -393,7 +393,7 @@
> 		7C83DF321D0A590C00FEBCF3 /* StringBuilder.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 81B50192140F232300D9EB58 /* StringBuilder.cpp */; };
> 		7C83DF361D0A590C00FEBCF3 /* StringHasher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93ABA80816DDAB91002DB2FA /* StringHasher.cpp */; };
> 		7C83DF371D0A590C00FEBCF3 /* StringImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26F1B44315CA434F00D1E4BF /* StringImpl.cpp */; };
>-		7C83DF381D0A590C00FEBCF3 /* StringOperators.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C01363C713C3997300EF3964 /* StringOperators.cpp */; };
>+		7C83DF381D0A590C00FEBCF3 /* StringOperators.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C01363C713C3997300EF3964 /* StringOperators.cpp */; settings = {COMPILER_FLAGS = "-O1"; }; };
> 		7C83DF3A1D0A590C00FEBCF3 /* StringView.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C74D42D188228F300E5ED57 /* StringView.cpp */; };
> 		7C83DF3D1D0A590C00FEBCF3 /* SetForScope.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0BCD85691485C98B00EA2003 /* SetForScope.cpp */; };
> 		7C83DF401D0A590C00FEBCF3 /* TestsController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC131AA8117131FC00B69727 /* TestsController.cpp */; };

Actions: View | Formatted Diff | Diff

Attachments on bug 192361: 356834 | 356964 | 356965