Attachment 356830 Details for Bug 192510 – Proposed patch

[patch] Proposed patch

ews-build-check-relevance-skipped.patch (text/plain), 1.16 KB, created by Aakash Jain on 2018-12-07 12:37:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-12-07 12:37:41 PST

Size: 1.16 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 238963)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-12-07  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] check-patch-relevance failure should not mark the overall build as failure
>+        https://bugs.webkit.org/show_bug.cgi?id=192510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CheckPatchRelevance.start):
>+
> 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-app] Send bug id as a build property
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 238963)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -187,6 +187,8 @@ class CheckPatchRelevance(buildstep.Buil
> 
>         self._addToLog('stdio', 'This patch does not have relevant changes.')
>         self.finished(FAILURE)
>+        self.build.results = SKIPPED
>+        self.build.buildFinished(['Patch doesn\'t have relevant changes'], SKIPPED)
>         return None
> 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192510: 356830