Attachment 356820 Details for Bug 192362 – Patch

[patch] Patch

bug-192362-20181207102821.patch (text/plain), 2.40 KB, created by Chris Dumez on 2018-12-07 10:28:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-12-07 10:28:22 PST

Size: 2.40 KB

patch

obsolete

>Subversion Revision: 238911
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 129bc043dbb9f99f147e20d1fbe24b4757f4b05d..5f6c77ae21bb696986c5f8951876a425cda05b72 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-07  Chris Dumez  <cdumez@apple.com>
>+
>+        ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=192362
>+        <rdar://problem/46460360>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
>+        *after* we know for sure we have a network process to communicate the policy to.
>+        This should address the failures on iOS.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2018-12-06  Chris Dumez  <cdumez@apple.com>
> 
>         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index db0909ee672a4a2c83759292f335ae3a7e570c23..2b2e7c82fbefd27cadcf471854c33b547e1937ad 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -3063,7 +3063,6 @@ TEST(ProcessSwap, UseSessionCookiesAfterProcessSwapInPrivateBrowsing)
>     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
>     processPoolConfiguration.get().processSwapsOnNavigation = YES;
>     auto processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
>-    [processPool _setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyAlways];
>     RetainPtr<WKWebsiteDataStore> ephemeralStore = [WKWebsiteDataStore nonPersistentDataStore];
> 
>     auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
>@@ -3080,6 +3079,8 @@ TEST(ProcessSwap, UseSessionCookiesAfterProcessSwapInPrivateBrowsing)
>     auto delegate = adoptNS([[PSONNavigationDelegate alloc] init]);
>     [webView setNavigationDelegate:delegate.get()];
> 
>+    [processPool _setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyAlways];
>+
>     NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"SetSessionCookie" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
>     [webView loadRequest:request];
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192362: 356515 | 356734 | 356820