Attachment 356813 Details for Bug 192498 – Patch

[patch] Patch

bug-192498-20181207084908.patch (text/plain), 2.86 KB, created by Andy Estes on 2018-12-07 08:49:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2018-12-07 08:49:09 PST

Size: 2.86 KB

patch

obsolete

>Subversion Revision: 238933
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 2591746e6e71820537f6f9d49bea0f23bb1673a5..160bc52d4eed31d2d1feacdc1a0b2d311ab81f31 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-07  Andy Estes  <aestes@apple.com>
>+
>+        [Cocoa] Add optional variants of SOFT_LINK_CLASS_FOR_SOURCE
>+        https://bugs.webkit.org/show_bug.cgi?id=192498
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL and SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT,
>+        which behave like their non-optional variants but do not require their classes to exist.
>+
>+        * wtf/cocoa/SoftLinking.h:
>+
> 2018-12-04  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [SOUP] Move URLSoup back to WebCore after r238771
>diff --git a/Source/WTF/wtf/cocoa/SoftLinking.h b/Source/WTF/wtf/cocoa/SoftLinking.h
>index 6434cbde36a801109bc7b782d4fc3809e6016379..1afab5bf51f1d1900119da3ec6fae716af711900 100644
>--- a/Source/WTF/wtf/cocoa/SoftLinking.h
>+++ b/Source/WTF/wtf/cocoa/SoftLinking.h
>@@ -389,7 +389,7 @@
>     } \
>     }
> 
>-#define SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, className, export) \
>+#define SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION(functionNamespace, framework, className, export, assertion) \
>     @class className; \
>     namespace functionNamespace { \
>     static Class init##className(); \
>@@ -407,15 +407,26 @@
>         dispatch_once(&once, ^{ \
>             framework##Library(); \
>             class##className = objc_getClass(#className); \
>-            RELEASE_ASSERT(class##className); \
>+            assertion(class##className); \
>             get##className##Class = className##Function; \
>         }); \
>         return class##className; \
>     } \
>     }
> 
>+#define NO_ASSERT(assertion) (void(0))
>+
>+#define SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, className, export) \
>+    SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION(functionNamespace, framework, className, export, RELEASE_ASSERT)
>+
>+#define SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT(functionNamespace, framework, className, export) \
>+    SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION(functionNamespace, framework, className, export, NO_ASSERT)
>+
> #define SOFT_LINK_CLASS_FOR_SOURCE(functionNamespace, framework, className) \
>-    SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, className, )
>+    SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION(functionNamespace, framework, className, , RELEASE_ASSERT)
>+
>+#define SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL(functionNamespace, framework, className) \
>+    SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION(functionNamespace, framework, className, , NO_ASSERT)
> 
> #define SOFT_LINK_CONSTANT_FOR_HEADER(functionNamespace, framework, variableName, variableType) \
>     WTF_EXTERN_C_BEGIN \

Actions: View | Formatted Diff | Diff

Attachments on bug 192498: 356813