Attachment 356791 Details for Bug 192492 – Proposed patch

[patch] Proposed patch

ews-build-add-url.patch (text/plain), 2.46 KB, created by Aakash Jain on 2018-12-07 02:37:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-12-07 02:37:36 PST

Size: 2.46 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 238950)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-12-07  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Builds should have a link to patch and bug
>+        https://bugs.webkit.org/show_bug.cgi?id=192492
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
>+        (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
>+        (ConfigureBuild.getPatchURL): Method to get Patch URL.
>+        (ConfigureBuild.getBugURL): Method to get Bug URL.
>+
> 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
> 
>         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 238950)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -28,6 +28,7 @@ from twisted.internet import defer
> 
> import re
> 
>+BUG_SERVER_URL = 'https://bugs.webkit.org/'
> EWS_URL = 'http://ews-build.webkit-uat.org/'
> WithProperties = properties.WithProperties
> Interpolate = properties.Interpolate
>@@ -62,9 +63,32 @@ class ConfigureBuild(buildstep.BuildStep
>             self.setProperty("buildOnly", self.buildOnly, 'config.json')
>         if self.additionalArguments:
>             self.setProperty("additionalArguments", self.additionalArguments, 'config.json')
>+
>+        self.add_patch_id_url()
>+        self.add_bug_id_url()
>         self.finished(SUCCESS)
>         return defer.succeed(None)
> 
>+    def add_patch_id_url(self):
>+        patch_id = self.getProperty('patch_id', '')
>+        if patch_id:
>+            self.addURL('Patch {}'.format(patch_id), self.getPatchURL(patch_id))
>+
>+    def add_bug_id_url(self):
>+        bug_id = self.getProperty('bug_id', '')
>+        if bug_id:
>+            self.addURL('Bug {}'.format(bug_id), self.getBugURL(bug_id))
>+
>+    def getPatchURL(self, patch_id):
>+        if not patch_id:
>+            return None
>+        return '{}attachment.cgi?id={}'.format(BUG_SERVER_URL, patch_id)
>+       
>+    def getBugURL(self, bug_id):
>+        if not bug_id:
>+            return None
>+        return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
>+ 
> 
> class CheckOutSource(svn.SVN):
>     CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR = (0, 2)

Actions: View | Formatted Diff | Diff

Attachments on bug 192492: 356791 | 356792 | 356801