Attachment 356789 Details for Bug 192491 – Patch

[patch] Patch

bug-192491-20181207121440.patch (text/plain), 1.35 KB, created by Adrian Perez on 2018-12-07 02:14:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2018-12-07 02:14:41 PST

Size: 1.35 KB

patch

obsolete

>Subversion Revision: 238950
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index d493a4e9beb2d1a08aa1f3685c740302ba16b965..8ee1ad67d248243360aea5c4fd74fb6b1bb65233 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-07  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [WTF] Debug build fails due conflicting abort() method
>+        https://bugs.webkit.org/show_bug.cgi?id=192491
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Assertions.h: Use namespaced std::abort() insted of plain
>+        abort() to avoid clashes inside classes which have an ::abort()
>+        method.
>+
> 2018-12-06  Alexey Proskuryakov  <ap@apple.com>
> 
>         Move USE_NEW_THEME out of WebCore's config.h
>diff --git a/Source/WTF/wtf/Assertions.h b/Source/WTF/wtf/Assertions.h
>index ebaaa056d563c7078b1d1be190fc9139e65ce4e0..4fdc676513030282bc69aea277f16092f158d1ac 100644
>--- a/Source/WTF/wtf/Assertions.h
>+++ b/Source/WTF/wtf/Assertions.h
>@@ -241,8 +241,8 @@ WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached(void);
>     __builtin_unreachable(); \
> } while (0)
> #elif !ENABLE(DEVELOPER_MODE) && !OS(DARWIN)
>-#define CRASH() abort()
>-#define CRASH_UNDER_CONSTEXPR_CONTEXT() abort()
>+#define CRASH() std::abort()
>+#define CRASH_UNDER_CONSTEXPR_CONTEXT() std::abort()
> #else
> #define CRASH() WTFCrash()
> #define CRASH_UNDER_CONSTEXPR_CONTEXT() WTFCrash()

Actions: View | Formatted Diff | Diff

Attachments on bug 192491: 356789 | 356878