Attachment 356788 Details for Bug 190793 – Proposed patch

[patch] Proposed patch

security_bug_exception.patch (text/plain), 1.38 KB, created by Aakash Jain on 2018-12-07 01:28:28 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-12-07 01:28:28 PST

Size: 1.38 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 238950)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-12-07  Aakash Jain  <aakash_jain@apple.com>
>+
>+        Style queue exception on some security bugs
>+        https://bugs.webkit.org/show_bug.cgi?id=190793
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/tool/steps/applywatchlist.py:
>+        (ApplyWatchList.run):
>+
> 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
> 
>         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
>Index: Tools/Scripts/webkitpy/tool/steps/applywatchlist.py
>===================================================================
>--- Tools/Scripts/webkitpy/tool/steps/applywatchlist.py	(revision 238950)
>+++ Tools/Scripts/webkitpy/tool/steps/applywatchlist.py	(working copy)
>@@ -51,6 +51,9 @@ class ApplyWatchList(AbstractStep):
>         if bug_id:
>             # Remove emails and cc's which are already in the bug or the reporter.
>             bug = self._tool.bugs.fetch_bug(bug_id)
>+            if not bug:
>+                _log.info('Unable to fetch bug {}. Skipped applying watchlist.'.format(bug_id))
>+                return
> 
>             messages = filter(lambda message: not bug.is_in_comments(message), messages)
>             cc_emails = set(cc_emails).difference(bug.cc_emails())

Actions: View | Formatted Diff | Diff

Attachments on bug 190793: 356788 | 356795