WebKit Bugzilla
Attachment 356759 Details for
Bug 192478
: Web Inspector: remove DOM.BackendNodeId and associated commands/events
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192478-20181206154649.patch (text/plain), 39.38 KB, created by
Devin Rousso
on 2018-12-06 15:46:50 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2018-12-06 15:46:50 PST
Size:
39.38 KB
patch
obsolete
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index ac53c4cf7c1eb23870742f6de68a16f3b43f3bbd..5a0ebf44c17b60bbfd2add1fc02ff98ab052e668 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,12 @@ >+2018-12-06 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: remove DOM.BackendNodeId and associated commands/events >+ https://bugs.webkit.org/show_bug.cgi?id=192478 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * inspector/protocol/DOM.json: >+ > 2018-12-05 Mark Lam <mark.lam@apple.com> > > speculationFromCell() should speculate non-Identifier strings as SpecString instead of SpecStringVar. >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index d3e4d463aae9ad658212c0272f99687a3d77b2f3..fa5a15839d9fc0d5efb8b715fc9eed7cbcc84121 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,19 @@ >+2018-12-06 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: remove DOM.BackendNodeId and associated commands/events >+ https://bugs.webkit.org/show_bug.cgi?id=192478 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Removing unused code, so no change in functionality. >+ >+ * inspector/agents/InspectorDOMAgent.h: >+ * inspector/agents/InspectorDOMAgent.cpp: >+ (WebCore::InspectorDOMAgent::discardBindings): >+ (WebCore::InspectorDOMAgent::backendNodeIdForNode): Deleted. >+ (WebCore::InspectorDOMAgent::releaseBackendNodeIds): Deleted. >+ (WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend): Deleted. >+ > 2018-12-05 Don Olmstead <don.olmstead@sony.com> > > [PlayStation] Enable WebCore >diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 41d966966dc87acf4eb0e969356ef3876f8144fa..52f1147b2bb4e63307cb358ad0b0e4e20916ae5f 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,27 @@ >+2018-12-06 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: remove DOM.BackendNodeId and associated commands/events >+ https://bugs.webkit.org/show_bug.cgi?id=192478 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Versions/Inspector-iOS-8.0.json: >+ * Versions/Inspector-iOS-9.0.json: >+ * Versions/Inspector-iOS-9.3.json: >+ * Versions/Inspector-iOS-10.0.json: >+ * Versions/Inspector-iOS-10.3.json: >+ * Versions/Inspector-iOS-11.0.json: >+ * Versions/Inspector-iOS-11.3.json: >+ * Versions/Inspector-iOS-12.0.json: >+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js: >+ * UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js: >+ > 2018-12-05 Matt Baker <mattbaker@apple.com> > > Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false >diff --git a/Source/JavaScriptCore/inspector/protocol/DOM.json b/Source/JavaScriptCore/inspector/protocol/DOM.json >index 0597d5f0d247c62907e49a97ef3ebbe5fc92bc54..781609d1de96b06f45cafb6e341647b563392283 100644 >--- a/Source/JavaScriptCore/inspector/protocol/DOM.json >+++ b/Source/JavaScriptCore/inspector/protocol/DOM.json >@@ -8,11 +8,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "EventListenerId", > "type": "integer", >@@ -452,23 +447,6 @@ > { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node for given path." } > ] > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "description": "Requests that the node is sent to the caller given its backend node id.", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ] >- }, >- { >- "name": "releaseBackendNodeIds", >- "description": "Requests that group of <code>BackendNodeIds</code> is released.", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ] >- }, > { > "name": "resolveNode", > "description": "Resolves JavaScript node object for given node id.", >diff --git a/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp b/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp >index 4f6297bc6208ac1ae31cd8513acf3b39f6fbce92..8797661f234181f6a414bcb93bcb187662525a79 100644 >--- a/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp >+++ b/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp >@@ -546,8 +546,6 @@ void InspectorDOMAgent::discardBindings() > m_eventListenerEntries.clear(); > releaseDanglingNodes(); > m_childrenRequested.clear(); >- m_backendIdToNode.clear(); >- m_nodeGroupToBackendIdMap.clear(); > } > > int InspectorDOMAgent::pushNodeToFrontend(ErrorString& errorString, int documentNodeId, Node* nodeToPush) >@@ -684,37 +682,6 @@ int InspectorDOMAgent::boundNodeId(const Node* node) > return m_documentNodeToIdMap.get(const_cast<Node*>(node)); > } > >-BackendNodeId InspectorDOMAgent::backendNodeIdForNode(Node* node, const String& nodeGroup) >-{ >- if (!node) >- return 0; >- >- if (!m_nodeGroupToBackendIdMap.contains(nodeGroup)) >- m_nodeGroupToBackendIdMap.set(nodeGroup, NodeToBackendIdMap()); >- >- NodeToBackendIdMap& map = m_nodeGroupToBackendIdMap.find(nodeGroup)->value; >- BackendNodeId id = map.get(node); >- if (!id) { >- id = --m_lastBackendNodeId; >- map.set(node, id); >- m_backendIdToNode.set(id, std::make_pair(node, nodeGroup)); >- } >- >- return id; >-} >- >-void InspectorDOMAgent::releaseBackendNodeIds(ErrorString& errorString, const String& nodeGroup) >-{ >- if (m_nodeGroupToBackendIdMap.contains(nodeGroup)) { >- NodeToBackendIdMap& map = m_nodeGroupToBackendIdMap.find(nodeGroup)->value; >- for (auto& backendId : map.values()) >- m_backendIdToNode.remove(backendId); >- m_nodeGroupToBackendIdMap.remove(nodeGroup); >- return; >- } >- errorString = "Group name not found"_s; >-} >- > void InspectorDOMAgent::setAttributeValue(ErrorString& errorString, int elementId, const String& name, const String& value) > { > Element* element = assertEditableElement(errorString, elementId); >@@ -2557,27 +2524,6 @@ void InspectorDOMAgent::pushNodeByPathToFrontend(ErrorString& errorString, const > errorString = "No node with given path found"_s; > } > >-void InspectorDOMAgent::pushNodeByBackendIdToFrontend(ErrorString& errorString, BackendNodeId backendNodeId, int* nodeId) >-{ >- auto iterator = m_backendIdToNode.find(backendNodeId); >- if (iterator == m_backendIdToNode.end()) { >- errorString = "No node with given backend id found"_s; >- return; >- } >- >- Node* node = iterator->value.first; >- String nodeGroup = iterator->value.second; >- >- *nodeId = pushNodePathToFrontend(node); >- >- if (nodeGroup.isEmpty()) { >- m_backendIdToNode.remove(iterator); >- // FIXME: We really do the following only when nodeGroup is the empty string? Seems wrong. >- ASSERT(m_nodeGroupToBackendIdMap.contains(nodeGroup)); >- m_nodeGroupToBackendIdMap.find(nodeGroup)->value.remove(node); >- } >-} >- > RefPtr<Inspector::Protocol::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(Node* node, const String& objectGroup) > { > auto* frame = node->document().frame(); >diff --git a/Source/WebCore/inspector/agents/InspectorDOMAgent.h b/Source/WebCore/inspector/agents/InspectorDOMAgent.h >index 65e6fadc7496dce9d97d4c9016cfb6f46ab5e4fd..20ab3d506a6b093729549d6d9c681f5375481fd7 100644 >--- a/Source/WebCore/inspector/agents/InspectorDOMAgent.h >+++ b/Source/WebCore/inspector/agents/InspectorDOMAgent.h >@@ -76,7 +76,6 @@ class ShadowRoot; > struct HighlightConfig; > > typedef String ErrorString; >-typedef int BackendNodeId; > > struct EventListenerInfo { > EventListenerInfo(Node* node, const AtomicString& eventType, EventListenerVector&& eventListenerVector) >@@ -141,8 +140,6 @@ public: > void setInspectModeEnabled(ErrorString&, bool enabled, const JSON::Object* highlightConfig) override; > void requestNode(ErrorString&, const String& objectId, int* nodeId) override; > void pushNodeByPathToFrontend(ErrorString&, const String& path, int* nodeId) override; >- void pushNodeByBackendIdToFrontend(ErrorString&, BackendNodeId, int* nodeId) override; >- void releaseBackendNodeIds(ErrorString&, const String& nodeGroup) override; > void hideHighlight(ErrorString&) override; > void highlightRect(ErrorString&, int x, int y, int width, int height, const JSON::Object* color, const JSON::Object* outlineColor, const bool* usePageCoordinates) override; > void highlightQuad(ErrorString&, const JSON::Array& quad, const JSON::Object* color, const JSON::Object* outlineColor, const bool* usePageCoordinates) override; >@@ -193,7 +190,6 @@ public: > Node* nodeForId(int nodeId); > int boundNodeId(const Node*); > void setDOMListener(DOMListener*); >- BackendNodeId backendNodeIdForNode(Node*, const String& nodeGroup); > > static String documentURLString(Document*); > >@@ -269,16 +265,12 @@ private: > InspectorOverlay* m_overlay { nullptr }; > DOMListener* m_domListener { nullptr }; > NodeToIdMap m_documentNodeToIdMap; >- typedef HashMap<RefPtr<Node>, BackendNodeId> NodeToBackendIdMap; >- HashMap<String, NodeToBackendIdMap> m_nodeGroupToBackendIdMap; > // Owns node mappings for dangling nodes. > Vector<std::unique_ptr<NodeToIdMap>> m_danglingNodeToIdMaps; > HashMap<int, Node*> m_idToNode; > HashMap<int, NodeToIdMap*> m_idToNodesMap; > HashSet<int> m_childrenRequested; >- HashMap<BackendNodeId, std::pair<Node*, String>> m_backendIdToNode; > int m_lastNodeId { 1 }; >- BackendNodeId m_lastBackendNodeId { -1 }; > RefPtr<Document> m_document; > typedef HashMap<String, Vector<RefPtr<Node>>> SearchResults; > SearchResults m_searchResults; >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js >index a1856c7077595d9efd7194cf8eddde18c0269379..90504d002566ce7e386e18798d7c0697495b25ee 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js >@@ -136,8 +136,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js >index 11097bbd0a4e661807f6b601809ae49c0bd7c223..c361e69edb402710e01e000267457719615926ac 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js >@@ -138,8 +138,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js >index de258193be506bcd0c44dbe8e077b2d23d6bc083..6a15738bcf498aba2576df0a890f231bb88d4fad 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js >@@ -138,8 +138,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js >index 42728854d09767a9c50806544ffc3812a3fa119f..ccdabb30d9e3238f53132b9de94d94c968fd8e1a 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js >@@ -164,8 +164,6 @@ InspectorBackend.registerCommand("DOM.highlightNodeList", [{"name": "nodeIds", " > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js >index 683373eb859931e2d19b61ccefd6c320d849159f..3337f2dd6edba3c85bf1935801f897de4627786f 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js >@@ -165,8 +165,6 @@ InspectorBackend.registerCommand("DOM.highlightNodeList", [{"name": "nodeIds", " > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js >index 59437debf0614ac080b4304a4a8f1bf0da8a33ce..598f58dd8c6a660bdebf4b61213d4dd4efbe8f50 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js >@@ -200,8 +200,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js >index efdab6cd2d5c59ecf5f9d2c9e5b16787062673cc..bec4b80ac37d19c1210a56f88c796d114eaf8c71 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js >@@ -126,8 +126,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js >index 9d357910baa6da2910358ad0260ecb8e3d6b057e..eed207d11e1a10853d74793ac1d704ad239f84ee 100644 >--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js >+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js >@@ -133,8 +133,6 @@ InspectorBackend.registerCommand("DOM.highlightNode", [{"name": "highlightConfig > InspectorBackend.registerCommand("DOM.hideHighlight", [], []); > InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []); > InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]); >-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []); > InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]); > InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]); > InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]); >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json b/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json >index 67f0dcc18c8ecbbe28e574d1444d16cad21aadec..153920a1fff795cb87879c6d26fc9c5b3701e82e 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json >@@ -655,11 +655,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "PseudoType", > "type": "string", >@@ -1035,23 +1030,6 @@ > ], > "description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath" > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ], >- "description": "Requests that the node is sent to the caller given its backend node id." >- }, >- { >- "name": "releaseBackendNodeIds", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ], >- "description": "Requests that group of <code>BackendNodeIds</code> is released." >- }, > { > "name": "resolveNode", > "parameters": [ >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json b/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json >index 8ac0a13a708447bd6fe116e7bfa801c8ce4bfad6..5b47f079689c6c8ec7e346115fd949c6b4427d6f 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json >@@ -660,11 +660,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "PseudoType", > "type": "string", >@@ -1049,23 +1044,6 @@ > ], > "description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath" > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ], >- "description": "Requests that the node is sent to the caller given its backend node id." >- }, >- { >- "name": "releaseBackendNodeIds", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ], >- "description": "Requests that group of <code>BackendNodeIds</code> is released." >- }, > { > "name": "resolveNode", > "parameters": [ >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json b/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json >index 5d2b1eb099afb1cb34f3a597b205b5e7c515e979..7fd3acf8fca6b723d379ef0d049faf65d68a7572 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json >@@ -660,11 +660,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "PseudoType", > "type": "string", >@@ -1051,23 +1046,6 @@ > { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node for given path." } > ] > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "description": "Requests that the node is sent to the caller given its backend node id.", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ] >- }, >- { >- "name": "releaseBackendNodeIds", >- "description": "Requests that group of <code>BackendNodeIds</code> is released.", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ] >- }, > { > "name": "resolveNode", > "description": "Resolves JavaScript node object for given node id.", >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json b/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json >index 096ed97abc036874f85f4a46ee13185f25248e43..3e692bba4b28e047ead34170b55d97befd531868 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json >@@ -825,11 +825,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "EventListenerId", > "type": "integer", >@@ -1247,23 +1242,6 @@ > { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node for given path." } > ] > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "description": "Requests that the node is sent to the caller given its backend node id.", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ] >- }, >- { >- "name": "releaseBackendNodeIds", >- "description": "Requests that group of <code>BackendNodeIds</code> is released.", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ] >- }, > { > "name": "resolveNode", > "description": "Resolves JavaScript node object for given node id.", >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json b/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json >index 8fcb286a6f33da374074b942858008f286cf39c0..9892776a7c9eded65d43ae9ca02eb8c909ca48ba 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json >@@ -833,11 +833,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "EventListenerId", > "type": "integer", >@@ -1255,23 +1250,6 @@ > { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node for given path." } > ] > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "description": "Requests that the node is sent to the caller given its backend node id.", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ] >- }, >- { >- "name": "releaseBackendNodeIds", >- "description": "Requests that group of <code>BackendNodeIds</code> is released.", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ] >- }, > { > "name": "resolveNode", > "description": "Resolves JavaScript node object for given node id.", >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json b/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json >index 3268b07392b2e34ddc0a4ac1fd5264914b85e1e7..74af1e91517419cdc047925e226b259678e87c3d 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json >@@ -1271,11 +1271,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "LiveRegionRelevant", > "type": "string", >@@ -1625,23 +1620,6 @@ > ], > "description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath" > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ], >- "description": "Requests that the node is sent to the caller given its backend node id." >- }, >- { >- "name": "releaseBackendNodeIds", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ], >- "description": "Requests that group of <code>BackendNodeIds</code> is released." >- }, > { > "name": "resolveNode", > "parameters": [ >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json b/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json >index 79b3ab5231dddaedaa9828ae35516a74ffa6bffb..c3ef70aa726f0af6fe9df32f5a4a3e25a2932f23 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json >@@ -611,11 +611,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "LiveRegionRelevant", > "type": "string", >@@ -974,23 +969,6 @@ > ], > "description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath" > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ], >- "description": "Requests that the node is sent to the caller given its backend node id." >- }, >- { >- "name": "releaseBackendNodeIds", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ], >- "description": "Requests that group of <code>BackendNodeIds</code> is released." >- }, > { > "name": "resolveNode", > "parameters": [ >diff --git a/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json b/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json >index 82f6d7fe5bb5edf6d7078b4b1c46a192eb5000b7..fc7cb00942bcbf3bcad7ff09884293d05d438888 100644 >--- a/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json >+++ b/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json >@@ -645,11 +645,6 @@ > "type": "integer", > "description": "Unique DOM node identifier." > }, >- { >- "id": "BackendNodeId", >- "type": "integer", >- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end." >- }, > { > "id": "PseudoType", > "type": "string", >@@ -1016,23 +1011,6 @@ > ], > "description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath" > }, >- { >- "name": "pushNodeByBackendIdToFrontend", >- "parameters": [ >- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." } >- ], >- "returns": [ >- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." } >- ], >- "description": "Requests that the node is sent to the caller given its backend node id." >- }, >- { >- "name": "releaseBackendNodeIds", >- "parameters": [ >- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." } >- ], >- "description": "Requests that group of <code>BackendNodeIds</code> is released." >- }, > { > "name": "resolveNode", > "parameters": [
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=356759">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192478
: 356759