Attachment 356747 Details for Bug 192427 – ...and include CoreGraphics.h

[patch] ...and include CoreGraphics.h

VersionMacro8.txt (text/plain), 19.75 KB, created by Alexey Proskuryakov on 2018-12-06 13:30:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2018-12-06 13:30:06 PST

Size: 19.75 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 238939)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,46 @@
>+2018-12-06  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * config.h: Removed the redefinition.
>+
>+        * WebCorePrefix.h: Added an included of CoreGraphics here instead.
>+
>+        * html/canvas/CanvasStyle.cpp:
>+        * page/cocoa/ResourceUsageOverlayCocoa.mm:
>+        * platform/graphics/FontPlatformData.cpp:
>+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
>+        * platform/graphics/cg/FloatPointCG.cpp:
>+        * platform/graphics/cg/FloatRectCG.cpp:
>+        * platform/graphics/cg/FloatSizeCG.cpp:
>+        * platform/graphics/cg/GradientCG.cpp:
>+        * platform/graphics/cg/GraphicsContext3DCG.cpp:
>+        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
>+        * platform/graphics/cg/IOSurfacePool.cpp:
>+        * platform/graphics/cg/ImageBufferCG.cpp:
>+        * platform/graphics/cg/ImageBufferDataCG.cpp:
>+        * platform/graphics/cg/IntPointCG.cpp:
>+        * platform/graphics/cg/IntRectCG.cpp:
>+        * platform/graphics/cg/IntSizeCG.cpp:
>+        * platform/graphics/cg/PDFDocumentImage.cpp:
>+        * platform/graphics/cg/PathCG.cpp:
>+        * platform/graphics/cg/PatternCG.cpp:
>+        * platform/graphics/cg/SubimageCacheWithTimer.h:
>+        * platform/graphics/cg/TransformationMatrixCG.cpp:
>+        * platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
>+        * platform/graphics/mac/FontCustomPlatformData.cpp:
>+        * platform/graphics/mac/ImageMac.mm:
>+        * platform/graphics/opentype/OpenTypeCG.h:
>+        * platform/ios/DragImageIOS.mm:
>+        * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
>+        * platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
>+        * rendering/RenderThemeIOS.mm:
>+        Removed CG includes from source files and from project headers, keeping them
>+        in private headers because I don't want to look into where those end up being used.
>+
> 2018-12-06  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
>Index: Source/WebCore/WebCorePrefix.h
>===================================================================
>--- Source/WebCore/WebCorePrefix.h	(revision 238800)
>+++ Source/WebCore/WebCorePrefix.h	(working copy)
>@@ -86,6 +86,10 @@
> #include <CoreFoundation/CoreFoundation.h>
> #endif
> 
>+#if USE(CG)
>+#include <CoreGraphics/CoreGraphics.h>
>+#endif
>+
> #if OS(WINDOWS)
> #ifndef CF_IMPLICIT_BRIDGING_ENABLED
> #define CF_IMPLICIT_BRIDGING_ENABLED
>Index: Source/WebCore/config.h
>===================================================================
>--- Source/WebCore/config.h	(revision 238800)
>+++ Source/WebCore/config.h	(working copy)
>@@ -59,14 +59,3 @@
> #if PLATFORM(MAC) || PLATFORM(WPE)
> #define USE_NEW_THEME 1
> #endif
>-
>-#if USE(CG)
>-#ifndef CGFLOAT_DEFINED
>-#if (defined(__LP64__) && __LP64__) || (defined(__x86_64__) && __x86_64__) || defined(_M_X64) || defined(__amd64__)
>-typedef double CGFloat;
>-#else
>-typedef float CGFloat;
>-#endif
>-#define CGFLOAT_DEFINED 1
>-#endif
>-#endif /* USE(CG) */
>Index: Source/WebCore/html/canvas/CanvasStyle.cpp
>===================================================================
>--- Source/WebCore/html/canvas/CanvasStyle.cpp	(revision 238800)
>+++ Source/WebCore/html/canvas/CanvasStyle.cpp	(working copy)
>@@ -37,10 +37,6 @@
> #include "HTMLCanvasElement.h"
> #include "StyleProperties.h"
> 
>-#if USE(CG)
>-#include <CoreGraphics/CGContext.h>
>-#endif
>-
> namespace WebCore {
> 
> static bool isCurrentColorString(const String& colorString)
>Index: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm
>===================================================================
>--- Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm	(revision 238800)
>+++ Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm	(working copy)
>@@ -34,7 +34,6 @@
> #include "JSDOMWindow.h"
> #include "PlatformCALayer.h"
> #include "ResourceUsageThread.h"
>-#include <CoreGraphics/CGContext.h>
> #include <QuartzCore/CALayer.h>
> #include <QuartzCore/CATransaction.h>
> #include <wtf/MainThread.h>
>Index: Source/WebCore/platform/graphics/FontPlatformData.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/FontPlatformData.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/FontPlatformData.cpp	(working copy)
>@@ -28,7 +28,6 @@
> 
> #if OS(DARWIN) && USE(CG)
> #include "SharedBuffer.h"
>-#include <CoreGraphics/CGFont.h>
> #endif
> 
> #if USE(DIRECT2D)
>Index: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
>===================================================================
>--- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h	(revision 238800)
>+++ Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h	(working copy)
>@@ -31,7 +31,6 @@
> #include "MediaPlayerPrivate.h"
> #include "MediaSample.h"
> #include "MediaStreamPrivate.h"
>-#include <CoreGraphics/CGAffineTransform.h>
> #include <wtf/Function.h>
> #include <wtf/LoggerHelper.h>
> #include <wtf/MediaTime.h>
>Index: Source/WebCore/platform/graphics/cg/FloatPointCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/FloatPointCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/FloatPointCG.cpp	(working copy)
>@@ -29,8 +29,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> FloatPoint::FloatPoint(const CGPoint& p) : m_x(p.x), m_y(p.y)
>Index: Source/WebCore/platform/graphics/cg/FloatRectCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/FloatRectCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/FloatRectCG.cpp	(working copy)
>@@ -29,8 +29,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> FloatRect::FloatRect(const CGRect& r) : m_location(r.origin), m_size(r.size)
>Index: Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp	(working copy)
>@@ -29,8 +29,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> FloatSize::FloatSize(const CGSize& s) : m_width(s.width), m_height(s.height)
>Index: Source/WebCore/platform/graphics/cg/GradientCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/GradientCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/GradientCG.cpp	(working copy)
>@@ -30,7 +30,6 @@
> #if USE(CG)
> 
> #include "GraphicsContextCG.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <wtf/RetainPtr.h>
> 
> namespace WebCore {
>Index: Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp	(working copy)
>@@ -39,11 +39,6 @@
> #include "GraphicsContext3DNEON.h"
> #endif
> 
>-#include <CoreGraphics/CGBitmapContext.h>
>-#include <CoreGraphics/CGContext.h>
>-#include <CoreGraphics/CGDataProvider.h>
>-#include <CoreGraphics/CGImage.h>
>-
> #include <wtf/RetainPtr.h>
> #include <wtf/StdLibExtras.h>
> 
>Index: Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h
>===================================================================
>--- Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h	(working copy)
>@@ -27,7 +27,6 @@
> #define GraphicsContextPlatformPrivateCG_h
> 
> #include <wtf/RetainPtr.h>
>-#include <CoreGraphics/CGContext.h>
> 
> namespace WebCore {
> 
>Index: Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp	(working copy)
>@@ -29,7 +29,6 @@
> #if HAVE(IOSURFACE)
> 
> #include "GraphicsContextCG.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <wtf/NeverDestroyed.h>
> 
> static const Seconds collectionInterval { 500_ms };
>Index: Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp	(working copy)
>@@ -38,7 +38,6 @@
> #include "IntRect.h"
> #include "MIMETypeRegistry.h"
> #include <math.h>
>-#include <CoreGraphics/CoreGraphics.h>
> #include <ImageIO/ImageIO.h>
> #include <wtf/Assertions.h>
> #include <wtf/CheckedArithmetic.h>
>Index: Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp	(working copy)
>@@ -30,7 +30,6 @@
> 
> #include "GraphicsContext.h"
> #include "IntRect.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <JavaScriptCore/JSCInlines.h>
> #include <JavaScriptCore/TypedArrayInlines.h>
> #include <JavaScriptCore/Uint8ClampedArray.h>
>Index: Source/WebCore/platform/graphics/cg/IntPointCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/IntPointCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/IntPointCG.cpp	(working copy)
>@@ -28,8 +28,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> IntPoint::IntPoint(const CGPoint& p) : m_x(static_cast<int>(p.x)), m_y(static_cast<int>(p.y))
>Index: Source/WebCore/platform/graphics/cg/IntRectCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/IntRectCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/IntRectCG.cpp	(working copy)
>@@ -28,8 +28,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> IntRect::operator CGRect() const
>Index: Source/WebCore/platform/graphics/cg/IntSizeCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/IntSizeCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/IntSizeCG.cpp	(working copy)
>@@ -28,8 +28,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CoreGraphics.h>
>-
> namespace WebCore {
> 
> IntSize::IntSize(const CGSize& s) : m_width(static_cast<int>(s.width)), m_height(static_cast<int>(s.height))
>Index: Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp	(working copy)
>@@ -29,7 +29,6 @@
> #if USE(CG)
> 
> #if PLATFORM(IOS_FAMILY)
>-#include <CoreGraphics/CoreGraphics.h>
> #include <ImageIO/ImageIO.h>
> #endif
> 
>@@ -40,8 +39,6 @@
> #include "Length.h"
> #include "NotImplemented.h"
> #include "SharedBuffer.h"
>-#include <CoreGraphics/CGContext.h>
>-#include <CoreGraphics/CGPDFDocument.h>
> #include <wtf/MathExtras.h>
> #include <wtf/RAMSize.h>
> #include <wtf/RetainPtr.h>
>Index: Source/WebCore/platform/graphics/cg/PathCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/PathCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/PathCG.cpp	(working copy)
>@@ -34,7 +34,6 @@
> #include "GraphicsContext.h"
> #include "IntRect.h"
> #include "StrokeStyleApplier.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <wtf/MathExtras.h>
> #include <wtf/RetainPtr.h>
> #include <wtf/text/WTFString.h>
>Index: Source/WebCore/platform/graphics/cg/PatternCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/PatternCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/PatternCG.cpp	(working copy)
>@@ -31,7 +31,6 @@
> 
> #include "AffineTransform.h"
> #include "GraphicsContext.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <pal/spi/cg/CoreGraphicsSPI.h>
> #include <wtf/MainThread.h>
> 
>Index: Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h
>===================================================================
>--- Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h	(working copy)
>@@ -29,7 +29,6 @@
> #include "FloatRect.h"
> #include "Timer.h"
> 
>-#include <CoreGraphics/CoreGraphics.h>
> #include <wtf/HashCountedSet.h>
> #include <wtf/HashSet.h>
> #include <wtf/HashTraits.h>
>Index: Source/WebCore/platform/graphics/cg/TransformationMatrixCG.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/cg/TransformationMatrixCG.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/cg/TransformationMatrixCG.cpp	(working copy)
>@@ -29,7 +29,6 @@
> 
> #if USE(CG)
> 
>-#include <CoreGraphics/CGAffineTransform.h>
> #include "FloatConversion.h"
> 
> namespace WebCore {
>Index: Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm
>===================================================================
>--- Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm	(revision 238800)
>+++ Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm	(working copy)
>@@ -43,7 +43,6 @@
> #import "WebGLLayer.h"
> #import "WebGLObject.h"
> #import "WebGLRenderingContextBase.h"
>-#import <CoreGraphics/CGBitmapContext.h>
> #import <sys/sysctl.h>
> #import <sysexits.h>
> #import <wtf/BlockObjCExceptions.h>
>Index: Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp	(revision 238800)
>+++ Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp	(working copy)
>@@ -26,8 +26,6 @@
> #include "FontDescription.h"
> #include "FontPlatformData.h"
> #include "SharedBuffer.h"
>-#include <CoreFoundation/CoreFoundation.h>
>-#include <CoreGraphics/CoreGraphics.h>
> #include <CoreText/CoreText.h>
> #include <pal/spi/cocoa/CoreTextSPI.h>
> 
>Index: Source/WebCore/platform/graphics/mac/ImageMac.mm
>===================================================================
>--- Source/WebCore/platform/graphics/mac/ImageMac.mm	(revision 238800)
>+++ Source/WebCore/platform/graphics/mac/ImageMac.mm	(working copy)
>@@ -32,7 +32,6 @@
> #import <wtf/text/WTFString.h>
> 
> #if PLATFORM(IOS_FAMILY)
>-#import <CoreGraphics/CoreGraphics.h>
> #import <ImageIO/ImageIO.h>
> #import <MobileCoreServices/MobileCoreServices.h>
> #endif
>Index: Source/WebCore/platform/graphics/opentype/OpenTypeCG.h
>===================================================================
>--- Source/WebCore/platform/graphics/opentype/OpenTypeCG.h	(revision 238800)
>+++ Source/WebCore/platform/graphics/opentype/OpenTypeCG.h	(working copy)
>@@ -26,7 +26,6 @@
> #ifndef OpenTypeCG_h
> #define OpenTypeCG_h
> 
>-#include <CoreGraphics/CoreGraphics.h>
> #include <CoreText/CoreText.h>
> 
> #if PLATFORM(WIN)
>Index: Source/WebCore/platform/ios/DragImageIOS.mm
>===================================================================
>--- Source/WebCore/platform/ios/DragImageIOS.mm	(revision 238800)
>+++ Source/WebCore/platform/ios/DragImageIOS.mm	(working copy)
>@@ -43,7 +43,6 @@
> #import "StringTruncator.h"
> #import "TextIndicator.h"
> #import "TextRun.h"
>-#import <CoreGraphics/CoreGraphics.h>
> #import <CoreText/CoreText.h>
> #import <UIKit/UIColor.h>
> #import <UIKit/UIFont.h>
>Index: Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp
>===================================================================
>--- Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp	(revision 238800)
>+++ Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp	(working copy)
>@@ -35,7 +35,6 @@
> #if PLATFORM(MAC)
> #include "ScreenDisplayCaptureSourceMac.h"
> #include "WindowDisplayCaptureSourceMac.h"
>-#include <CoreGraphics/CGDirectDisplay.h>
> #endif
> 
> #include "CoreVideoSoftLink.h"
>Index: Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h
>===================================================================
>--- Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h	(revision 238800)
>+++ Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h	(working copy)
>@@ -29,8 +29,6 @@
> 
> #include "DisplayCaptureSourceCocoa.h"
> #include "IOSurface.h"
>-#include <CoreGraphics/CGDisplayConfiguration.h>
>-#include <CoreGraphics/CGDisplayStream.h>
> #include <wtf/Lock.h>
> #include <wtf/OSObjectPtr.h>
> 
>Index: Source/WebCore/rendering/RenderThemeIOS.mm
>===================================================================
>--- Source/WebCore/rendering/RenderThemeIOS.mm	(revision 238800)
>+++ Source/WebCore/rendering/RenderThemeIOS.mm	(working copy)
>@@ -67,7 +67,6 @@
> #import "UserAgentScripts.h"
> #import "UserAgentStyleSheets.h"
> #import "WebCoreThreadRun.h"
>-#import <CoreGraphics/CoreGraphics.h>
> #import <CoreImage/CoreImage.h>
> #import <objc/runtime.h>
> #import <pal/spi/cocoa/CoreTextSPI.h>
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 238938)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-06  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/WebPage.cpp: Removed the unneeded include of CoreGraphics.h
>+
> 2018-12-06  David Quesada  <david_quesada@apple.com>
> 
>         -[WKProcessPool _resumeDownloadFromData:path:] should allow specifying the originating web view
>Index: Source/WebKit/WebProcess/WebPage/WebPage.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.cpp	(revision 238800)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.cpp	(working copy)
>@@ -259,7 +259,6 @@
> 
> #if PLATFORM(IOS_FAMILY)
> #include "RemoteLayerTreeDrawingArea.h"
>-#include <CoreGraphics/CoreGraphics.h>
> #include <WebCore/Icon.h>
> #include <pal/spi/cocoa/CoreTextSPI.h>
> #endif
>Index: Source/WebKitLegacy/mac/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/mac/ChangeLog	(revision 238908)
>+++ Source/WebKitLegacy/mac/ChangeLog	(working copy)
>@@ -1,3 +1,22 @@
>+2018-12-06  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitPrefix.h: WebKitPrefix already includes CoreGraphics.h, so the redefinition
>+        was completely unneeded already.
>+
>+2018-12-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitPrefix.h:
>+
> 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Turn WritingDirection into an enum class
>Index: Source/WebKitLegacy/mac/WebKitPrefix.h
>===================================================================
>--- Source/WebKitLegacy/mac/WebKitPrefix.h	(revision 238800)
>+++ Source/WebKitLegacy/mac/WebKitPrefix.h	(working copy)
>@@ -62,15 +62,6 @@
> 
> #if !TARGET_OS_IPHONE
> #import <Carbon/Carbon.h>
>-
>-#ifndef CGFLOAT_DEFINED
>-#ifdef __LP64__
>-typedef double CGFloat;
>-#else
>-typedef float CGFloat;
>-#endif
>-#define CGFLOAT_DEFINED 1
>-#endif
> #endif
> 
> #ifdef __OBJC__

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192427: 356656 | 356747