Attachment 356734 Details for Bug 192362 – Patch

[patch] Patch

bug-192362-20181206083827.patch (text/plain), 1.95 KB, created by Chris Dumez on 2018-12-06 08:38:29 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-12-06 08:38:29 PST

Size: 1.95 KB

patch

obsolete

>Subversion Revision: 238931
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d4a32b204c6858cfe73f35472c9eb21317a609eb..6451f565d5127964d5d8c4bf980f9421c79eafe1 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-06  Chris Dumez  <cdumez@apple.com>
>+
>+        ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=192362
>+        <rdar://problem/46460360>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Temporarily disable the test on iOS until I can investigate why it is failing on the iOS bots.
>+        It is consistently passing on my iOS simulator for some reason.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index a2b6af23bf8e1b9b661eb2f7c8d12633d49f049c..47fd11acd5d100e71725e5cba4f1743c9ffb84d4 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -2988,6 +2988,9 @@ TEST(ProcessSwap, UsePrewarmedProcessAfterTerminatingNetworkProcess)
>     done = false;
> }
> 
>+#if PLATFORM(MAC)
>+
>+// FIXME: Figure out why this test does not pass consistently on iOS.
> TEST(ProcessSwap, UseSessionCookiesAfterProcessSwapInPrivateBrowsing)
> {
>     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
>@@ -3045,8 +3048,6 @@ TEST(ProcessSwap, UseSessionCookiesAfterProcessSwapInPrivateBrowsing)
>     EXPECT_WK_STREQ(@"foo=bar", receivedMessages.get()[0]);
> }
> 
>-#if PLATFORM(MAC)
>-
> TEST(ProcessSwap, TerminateProcessAfterProcessSwap)
> {
>     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);

Actions: View | Formatted Diff | Diff

Attachments on bug 192362: 356515 | 356734 | 356820