Attachment 356710 Details for Bug 192454 – Patch

[patch] Patch

bug-192454-20181205213500.patch (text/plain), 3.35 KB, created by Devin Rousso on 2018-12-05 21:35:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-05 21:35:01 PST

Size: 3.35 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b4fdaa2972780d0cabc2f4640cac09fb81bd77ec..2b68035434e1be3efaa557cd335bd2a9d0fd188c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-05  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
>+        https://bugs.webkit.org/show_bug.cgi?id=192454
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/CanvasOverviewContentView.js:
>+        (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
>+        (WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):
>+
> 2018-12-04  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Add style editing debug mode
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js b/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
>index 671786604f329656c3d6a8b6a47324b5c48087d4..942b44f2f7152af683b20b50447c18e03fa82958 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
>@@ -209,6 +209,7 @@ WI.CanvasOverviewContentView = class CanvasOverviewContentView extends WI.Collec
> 
>         let label = frameCount === 1 ? WI.UIString("Record first %s frame") : WI.UIString("Record first %s frames");
> 
>+        let active = document.activeElement === this._recordingAutoCaptureFrameCountInputElement;
>         let selectionStart = this._recordingAutoCaptureFrameCountInputElement.selectionStart;
>         let selectionEnd = this._recordingAutoCaptureFrameCountInputElement.selectionEnd;
>         let direction = this._recordingAutoCaptureFrameCountInputElement.direction;
>@@ -221,9 +222,11 @@ WI.CanvasOverviewContentView = class CanvasOverviewContentView extends WI.Collec
> 
>         this._recordingAutoCaptureNavigationItem.label = fragment;
> 
>-        this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
>-        this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
>-        this._recordingAutoCaptureFrameCountInputElement.direction = direction;
>+        if (active) {
>+            this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
>+            this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
>+            this._recordingAutoCaptureFrameCountInputElement.direction = direction;
>+        }
>     }
> 
>     _updateRecordingAutoCaptureInputElementSize()
>@@ -270,7 +273,9 @@ WI.CanvasOverviewContentView = class CanvasOverviewContentView extends WI.Collec
> 
>     _handleCanvasRecordingAutoCaptureFrameCountChanged(event)
>     {
>-        this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
>+        // Only update the value if it is different to prevent mangling the selection.
>+        if (parseInt(this._recordingAutoCaptureFrameCountInputElement.value) !== WI.settings.canvasRecordingAutoCaptureFrameCount.value)
>+            this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
> 
>         this._updateRecordingAutoCaptureCheckboxLabel(WI.settings.canvasRecordingAutoCaptureFrameCount.value);
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 192454: 356710 | 356717