Attachment 356706 Details for Bug 192452 – Patch

[patch] Patch

bug-192452-20181205212011.patch (text/plain), 21.82 KB, created by Alex Christensen on 2018-12-05 21:20:12 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-12-05 21:20:12 PST

Size: 21.82 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 238899)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,25 @@
>+2018-12-05  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
>+        https://bugs.webkit.org/show_bug.cgi?id=192452
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * loader/LoaderStrategy.h:
>+        * loader/ResourceLoader.cpp:
>+        (WebCore::ResourceLoader::didRetrieveDerivedDataFromCache): Deleted.
>+        * loader/ResourceLoader.h:
>+        * loader/ResourceLoaderOptions.h:
>+        * loader/SubresourceLoader.cpp:
>+        (WebCore::SubresourceLoader::didRetrieveDerivedDataFromCache): Deleted.
>+        * loader/SubresourceLoader.h:
>+        * loader/ThreadableLoader.cpp:
>+        (WebCore::ThreadableLoaderOptions::isolatedCopy const):
>+        * loader/cache/CachedResource.h:
>+        (WebCore::CachedResource::didRetrieveDerivedDataFromCache): Deleted.
>+
> 2018-12-05  Frederic Wang  <fwang@igalia.com>
> 
>         Minor refactoring of the scrolling code
>Index: Source/WebCore/loader/LoaderStrategy.h
>===================================================================
>--- Source/WebCore/loader/LoaderStrategy.h	(revision 238899)
>+++ Source/WebCore/loader/LoaderStrategy.h	(working copy)
>@@ -31,7 +31,6 @@
> #include "StoredCredentialsPolicy.h"
> #include <pal/SessionID.h>
> #include <wtf/Forward.h>
>-#include <wtf/SHA1.h>
> 
> namespace WebCore {
> 
>@@ -74,8 +73,6 @@ public:
>     using PreconnectCompletionHandler = WTF::Function<void(const ResourceError&)>;
>     virtual void preconnectTo(FrameLoader&, const URL&, StoredCredentialsPolicy, PreconnectCompletionHandler&&) = 0;
> 
>-    virtual void storeDerivedDataToCache(const SHA1::Digest& bodyKey, const String& type, const String& partition, WebCore::SharedBuffer&) = 0;
>-
>     virtual void setCaptureExtraNetworkLoadMetricsEnabled(bool) = 0;
> 
>     virtual bool isOnLine() const = 0;
>Index: Source/WebCore/loader/ResourceLoader.cpp
>===================================================================
>--- Source/WebCore/loader/ResourceLoader.cpp	(revision 238899)
>+++ Source/WebCore/loader/ResourceLoader.cpp	(working copy)
>@@ -802,8 +802,4 @@ bool ResourceLoader::isAlwaysOnLoggingAl
>     return frameLoader() && frameLoader()->isAlwaysOnLoggingAllowed();
> }
> 
>-void ResourceLoader::didRetrieveDerivedDataFromCache(const String&, SharedBuffer&)
>-{
>-}
>-
> }
>Index: Source/WebCore/loader/ResourceLoader.h
>===================================================================
>--- Source/WebCore/loader/ResourceLoader.h	(revision 238899)
>+++ Source/WebCore/loader/ResourceLoader.h	(working copy)
>@@ -105,7 +105,6 @@ public:
>     virtual void didReceiveBuffer(Ref<SharedBuffer>&&, long long encodedDataLength, DataPayloadType);
>     virtual void didFinishLoading(const NetworkLoadMetrics&);
>     virtual void didFail(const ResourceError&);
>-    virtual void didRetrieveDerivedDataFromCache(const String& type, SharedBuffer&);
> 
>     WEBCORE_EXPORT void didBlockAuthenticationChallenge();
> 
>Index: Source/WebCore/loader/ResourceLoaderOptions.h
>===================================================================
>--- Source/WebCore/loader/ResourceLoaderOptions.h	(revision 238899)
>+++ Source/WebCore/loader/ResourceLoaderOptions.h	(working copy)
>@@ -152,7 +152,6 @@ struct ResourceLoaderOptions : public Fe
>     std::optional<ServiceWorkerRegistrationIdentifier> serviceWorkerRegistrationIdentifier;
> #endif
>     HashSet<HTTPHeaderName, WTF::IntHash<HTTPHeaderName>, WTF::StrongEnumHashTraits<HTTPHeaderName>> httpHeadersToKeep;
>-    Vector<String> derivedCachedDataTypesToRetrieve;
>     std::optional<ContentSecurityPolicyResponseHeaders> cspResponseHeaders;
>     unsigned maxRedirectCount { 20 };
> 
>Index: Source/WebCore/loader/SubresourceLoader.cpp
>===================================================================
>--- Source/WebCore/loader/SubresourceLoader.cpp	(revision 238899)
>+++ Source/WebCore/loader/SubresourceLoader.cpp	(working copy)
>@@ -721,13 +721,6 @@ void SubresourceLoader::didCancel(const 
>     notifyDone(LoadCompletionType::Cancel);
> }
> 
>-void SubresourceLoader::didRetrieveDerivedDataFromCache(const String& type, SharedBuffer& buffer)
>-{
>-    if (m_state != Initialized)
>-        return;
>-    m_resource->didRetrieveDerivedDataFromCache(type, buffer);
>-}
>-
> void SubresourceLoader::notifyDone(LoadCompletionType type)
> {
>     if (reachedTerminalState())
>Index: Source/WebCore/loader/SubresourceLoader.h
>===================================================================
>--- Source/WebCore/loader/SubresourceLoader.h	(revision 238899)
>+++ Source/WebCore/loader/SubresourceLoader.h	(working copy)
>@@ -79,7 +79,6 @@ private:
>     void didFail(const ResourceError&) override;
>     void willCancel(const ResourceError&) override;
>     void didCancel(const ResourceError&) override;
>-    void didRetrieveDerivedDataFromCache(const String& type, SharedBuffer&) override;
>     
>     void updateReferrerPolicy(const String&);
> 
>Index: Source/WebCore/loader/ThreadableLoader.cpp
>===================================================================
>--- Source/WebCore/loader/ThreadableLoader.cpp	(revision 238899)
>+++ Source/WebCore/loader/ThreadableLoader.cpp	(working copy)
>@@ -89,9 +89,6 @@ ThreadableLoaderOptions ThreadableLoader
>     copy.initiatorContext = this->initiatorContext;
>     copy.clientCredentialPolicy = this->clientCredentialPolicy;
>     copy.maxRedirectCount = this->maxRedirectCount;
>-    copy.derivedCachedDataTypesToRetrieve.reserveInitialCapacity(this->derivedCachedDataTypesToRetrieve.size());
>-    for (auto& derivedCachedDataType : this->derivedCachedDataTypesToRetrieve)
>-        copy.derivedCachedDataTypesToRetrieve.uncheckedAppend(derivedCachedDataType.isolatedCopy());
>     copy.preflightPolicy = this->preflightPolicy;
> 
>     // ThreadableLoaderOptions
>Index: Source/WebCore/loader/cache/CachedResource.h
>===================================================================
>--- Source/WebCore/loader/cache/CachedResource.h	(revision 238899)
>+++ Source/WebCore/loader/cache/CachedResource.h	(working copy)
>@@ -267,8 +267,6 @@ public:
> 
>     virtual void didSendData(unsigned long long /* bytesSent */, unsigned long long /* totalBytesToBeSent */) { }
> 
>-    virtual void didRetrieveDerivedDataFromCache(const String& /* type */, SharedBuffer&) { }
>-
> #if USE(FOUNDATION) || USE(SOUP)
>     WEBCORE_EXPORT void tryReplaceEncodedData(SharedBuffer&);
> #endif
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 238926)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,34 @@
>+2018-12-05  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
>+        https://bugs.webkit.org/show_bug.cgi?id=192452
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This was introduced in r210835 but never used.
>+        It's preventing me from making the disk cache associated with a SessionID/NetworkSession.
>+
>+        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
>+        (WebKit::NetworkConnectionToWebProcess::storeDerivedDataToCache): Deleted.
>+        * NetworkProcess/NetworkConnectionToWebProcess.h:
>+        * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
>+        * NetworkProcess/NetworkResourceLoadParameters.cpp:
>+        (WebKit::NetworkResourceLoadParameters::encode const):
>+        (WebKit::NetworkResourceLoadParameters::decode):
>+        * NetworkProcess/NetworkResourceLoadParameters.h:
>+        * NetworkProcess/NetworkResourceLoader.cpp:
>+        (WebKit::NetworkResourceLoader::continueDidReceiveResponse):
>+        (WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
>+        (WebKit::NetworkResourceLoader::continueProcessingCachedEntryAfterDidReceiveResponse): Deleted.
>+        * NetworkProcess/NetworkResourceLoader.h:
>+        * WebProcess/Network/WebLoaderStrategy.cpp:
>+        (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
>+        (WebKit::WebLoaderStrategy::storeDerivedDataToCache): Deleted.
>+        * WebProcess/Network/WebLoaderStrategy.h:
>+        * WebProcess/Network/WebResourceLoader.cpp:
>+        (WebKit::WebResourceLoader::didRetrieveDerivedData): Deleted.
>+        * WebProcess/Network/WebResourceLoader.messages.in:
>+
> 2018-12-05  Youenn Fablet  <youenn@apple.com>
> 
>         Remove a document entry from NetworkMDNSRegister::m_services when document goes away
>Index: Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	(working copy)
>@@ -548,12 +548,6 @@ void NetworkConnectionToWebProcess::writ
>     });
> }
> 
>-void NetworkConnectionToWebProcess::storeDerivedDataToCache(const WebKit::NetworkCache::DataKey& dataKey, const IPC::DataReference& data)
>-{
>-    if (auto* cache = NetworkProcess::singleton().cache())
>-        cache->storeData(dataKey, data.data(), data.size());
>-}
>-
> void NetworkConnectionToWebProcess::setCaptureExtraNetworkLoadMetricsEnabled(bool enabled)
> {
>     m_captureExtraNetworkLoadMetricsEnabled = enabled;
>Index: Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h	(working copy)
>@@ -170,8 +170,6 @@ private:
>     void unregisterBlobURL(const URL&);
>     void writeBlobsToTemporaryFiles(const Vector<String>& blobURLs, CompletionHandler<void(Vector<String>&&)>&&);
> 
>-    void storeDerivedDataToCache(const WebKit::NetworkCache::DataKey&, const IPC::DataReference&);
>-
>     void setCaptureExtraNetworkLoadMetricsEnabled(bool);
> 
>     void createSocketStream(URL&&, PAL::SessionID, String cachePartition, uint64_t);
>Index: Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in	(working copy)
>@@ -50,8 +50,6 @@ messages -> NetworkConnectionToWebProces
>     BlobSize(URL url) -> (uint64_t resultSize) LegacySync
>     WriteBlobsToTemporaryFiles(Vector<String> blobURLs) -> (Vector<String> fileNames) Async
> 
>-    StoreDerivedDataToCache(WebKit::NetworkCache::DataKey key, IPC::SharedBufferDataReference data)
>-
>     SetCaptureExtraNetworkLoadMetricsEnabled(bool enabled)
> 
>     CreateSocketStream(URL url, PAL::SessionID sessionID, String cachePartition, uint64_t identifier)
>Index: Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp	(working copy)
>@@ -83,7 +83,6 @@ void NetworkResourceLoadParameters::enco
>     encoder << needsCertificateInfo;
>     encoder << isMainFrameNavigation;
>     encoder << maximumBufferingTime;
>-    encoder << derivedCachedDataTypesToRetrieve;
> 
>     encoder << static_cast<bool>(sourceOrigin);
>     if (sourceOrigin)
>@@ -173,8 +172,6 @@ bool NetworkResourceLoadParameters::deco
>         return false;
>     if (!decoder.decode(result.maximumBufferingTime))
>         return false;
>-    if (!decoder.decode(result.derivedCachedDataTypesToRetrieve))
>-        return false;
> 
>     bool hasSourceOrigin;
>     if (!decoder.decode(hasSourceOrigin))
>Index: Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h	(working copy)
>@@ -54,7 +54,6 @@ public:
>     Vector<RefPtr<SandboxExtension>> requestBodySandboxExtensions; // Created automatically for the sender.
>     RefPtr<SandboxExtension> resourceSandboxExtension; // Created automatically for the sender.
>     Seconds maximumBufferingTime;
>-    Vector<String> derivedCachedDataTypesToRetrieve;
>     RefPtr<WebCore::SecurityOrigin> sourceOrigin;
>     WebCore::FetchOptions options;
>     std::optional<WebCore::ContentSecurityPolicyResponseHeaders> cspResponseHeaders;
>Index: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	(working copy)
>@@ -749,7 +749,8 @@ void NetworkResourceLoader::continueWill
> void NetworkResourceLoader::continueDidReceiveResponse()
> {
>     if (m_cacheEntryWaitingForContinueDidReceiveResponse) {
>-        continueProcessingCachedEntryAfterDidReceiveResponse(WTFMove(m_cacheEntryWaitingForContinueDidReceiveResponse));
>+        sendResultForCacheEntry(WTFMove(m_cacheEntryWaitingForContinueDidReceiveResponse));
>+        cleanup(LoadResult::Success);
>         return;
>     }
> 
>@@ -840,41 +841,10 @@ void NetworkResourceLoader::didRetrieveC
> 
>     if (needsContinueDidReceiveResponseMessage)
>         m_cacheEntryWaitingForContinueDidReceiveResponse = WTFMove(entry);
>-    else
>-        continueProcessingCachedEntryAfterDidReceiveResponse(WTFMove(entry));
>-}
>-
>-void NetworkResourceLoader::continueProcessingCachedEntryAfterDidReceiveResponse(std::unique_ptr<NetworkCache::Entry> entry)
>-{
>-    if (entry->sourceStorageRecord().bodyHash && !m_parameters.derivedCachedDataTypesToRetrieve.isEmpty()) {
>-        auto bodyHash = *entry->sourceStorageRecord().bodyHash;
>-        auto* entryPtr = entry.release();
>-        auto retrieveCount = m_parameters.derivedCachedDataTypesToRetrieve.size();
>-
>-        for (auto& type : m_parameters.derivedCachedDataTypesToRetrieve) {
>-            NetworkCache::DataKey key { originalRequest().cachePartition(), type, bodyHash };
>-            m_cache->retrieveData(key, [loader = makeRef(*this), entryPtr, type, retrieveCount] (const uint8_t* data, size_t size) mutable {
>-                loader->m_retrievedDerivedDataCount++;
>-                bool retrievedAll = loader->m_retrievedDerivedDataCount == retrieveCount;
>-                std::unique_ptr<NetworkCache::Entry> entry(retrievedAll ? entryPtr : nullptr);
>-                if (loader->hasOneRef())
>-                    return;
>-                if (data) {
>-                    IPC::DataReference dataReference(data, size);
>-                    loader->send(Messages::WebResourceLoader::DidRetrieveDerivedData(type, dataReference));
>-                }
>-                if (retrievedAll) {
>-                    loader->sendResultForCacheEntry(WTFMove(entry));
>-                    loader->cleanup(LoadResult::Success);
>-                }
>-            });
>-        }
>-        return;
>+    else {
>+        sendResultForCacheEntry(WTFMove(entry));
>+        cleanup(LoadResult::Success);
>     }
>-
>-    sendResultForCacheEntry(WTFMove(entry));
>-
>-    cleanup(LoadResult::Success);
> }
> 
> void NetworkResourceLoader::sendResultForCacheEntry(std::unique_ptr<NetworkCache::Entry> entry)
>Index: Source/WebKit/NetworkProcess/NetworkResourceLoader.h
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkResourceLoader.h	(revision 238899)
>+++ Source/WebKit/NetworkProcess/NetworkResourceLoader.h	(working copy)
>@@ -23,11 +23,11 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>-#ifndef NetworkResourceLoader_h
>-#define NetworkResourceLoader_h
>+#pragma once
> 
> #include "DownloadID.h"
> #include "MessageSender.h"
>+#include "NetworkCache.h"
> #include "NetworkConnectionToWebProcessMessages.h"
> #include "NetworkLoadClient.h"
> #include "NetworkResourceLoadParameters.h"
>@@ -132,7 +132,6 @@ private:
>     void sendResultForCacheEntry(std::unique_ptr<NetworkCache::Entry>);
>     void validateCacheEntry(std::unique_ptr<NetworkCache::Entry>);
>     void dispatchWillSendRequestForCacheEntry(WebCore::ResourceRequest&&, std::unique_ptr<NetworkCache::Entry>&&);
>-    void continueProcessingCachedEntryAfterDidReceiveResponse(std::unique_ptr<NetworkCache::Entry>);
> 
>     bool shouldInterruptLoadForXFrameOptions(const String&, const URL&);
>     bool shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions(const WebCore::ResourceResponse&);
>@@ -215,5 +214,3 @@ private:
> };
> 
> } // namespace WebKit
>-
>-#endif // NetworkResourceLoader_h
>Index: Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
>===================================================================
>--- Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	(revision 238899)
>+++ Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	(working copy)
>@@ -273,7 +273,6 @@ void WebLoaderStrategy::scheduleLoadFrom
>     loadParameters.defersLoading = resourceLoader.defersLoading();
>     loadParameters.needsCertificateInfo = resourceLoader.shouldIncludeCertificateInfo();
>     loadParameters.maximumBufferingTime = maximumBufferingTime;
>-    loadParameters.derivedCachedDataTypesToRetrieve = resourceLoader.options().derivedCachedDataTypesToRetrieve;
>     loadParameters.options = resourceLoader.options();
>     loadParameters.preflightPolicy = resourceLoader.options().preflightPolicy;
> 
>@@ -647,12 +646,6 @@ void WebLoaderStrategy::didFinishPreconn
>         completionHandler(WTFMove(error));
> }
> 
>-void WebLoaderStrategy::storeDerivedDataToCache(const SHA1::Digest& bodyHash, const String& type, const String& partition, WebCore::SharedBuffer& data)
>-{
>-    NetworkCache::DataKey key { partition, type, bodyHash };
>-    WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::StoreDerivedDataToCache(key, { data }), 0);
>-}
>-
> bool WebLoaderStrategy::isOnLine() const
> {
>     return m_isOnLine;
>Index: Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
>===================================================================
>--- Source/WebKit/WebProcess/Network/WebLoaderStrategy.h	(revision 238899)
>+++ Source/WebKit/WebProcess/Network/WebLoaderStrategy.h	(working copy)
>@@ -68,8 +68,6 @@ public:
>     void preconnectTo(WebCore::FrameLoader&, const URL&, WebCore::StoredCredentialsPolicy, PreconnectCompletionHandler&&) final;
>     void didFinishPreconnection(uint64_t preconnectionIdentifier, WebCore::ResourceError&&);
> 
>-    void storeDerivedDataToCache(const SHA1::Digest& bodyHash, const String& type, const String& partition, WebCore::SharedBuffer&) final;
>-
>     void setCaptureExtraNetworkLoadMetricsEnabled(bool) final;
> 
>     WebResourceLoader* webResourceLoaderForIdentifier(ResourceLoadIdentifier identifier) const { return m_webResourceLoaders.get(identifier); }
>Index: Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
>===================================================================
>--- Source/WebKit/WebProcess/Network/WebResourceLoader.cpp	(revision 238899)
>+++ Source/WebKit/WebProcess/Network/WebResourceLoader.cpp	(working copy)
>@@ -145,14 +145,6 @@ void WebResourceLoader::didReceiveData(c
>     m_coreLoader->didReceiveData(reinterpret_cast<const char*>(data.data()), data.size(), encodedDataLength, DataPayloadBytes);
> }
> 
>-void WebResourceLoader::didRetrieveDerivedData(const String& type, const IPC::DataReference& data)
>-{
>-    LOG(Network, "(WebProcess) WebResourceLoader::didRetrieveDerivedData of size %lu for '%s'", data.size(), m_coreLoader->url().string().latin1().data());
>-
>-    auto buffer = SharedBuffer::create(data.data(), data.size());
>-    m_coreLoader->didRetrieveDerivedDataFromCache(type, buffer.get());
>-}
>-
> void WebResourceLoader::didFinishResourceLoad(const NetworkLoadMetrics& networkLoadMetrics)
> {
>     LOG(Network, "(WebProcess) WebResourceLoader::didFinishResourceLoad for '%s'", m_coreLoader->url().string().latin1().data());
>Index: Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in
>===================================================================
>--- Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in	(revision 238899)
>+++ Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in	(working copy)
>@@ -26,7 +26,6 @@ messages -> WebResourceLoader LegacyRece
>     DidReceiveResponse(WebCore::ResourceResponse response, bool needsContinueDidReceiveResponseMessage)
>     DidReceiveData(IPC::SharedBufferDataReference data, int64_t encodedDataLength)
>     DidFinishResourceLoad(WebCore::NetworkLoadMetrics networkLoadMetrics)
>-    DidRetrieveDerivedData(String type, IPC::DataReference data)
>     DidFailResourceLoad(WebCore::ResourceError error)
>     DidBlockAuthenticationChallenge()
> 
>Index: Source/WebKitLegacy/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/ChangeLog	(revision 238899)
>+++ Source/WebKitLegacy/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-05  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
>+        https://bugs.webkit.org/show_bug.cgi?id=192452
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebResourceLoadScheduler.h:
>+
> 2018-12-03  Jer Noble  <jer.noble@apple.com>
> 
>         Get rid of old, dead Mac video fullscreen code.
>Index: Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
>===================================================================
>--- Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h	(revision 238899)
>+++ Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h	(working copy)
>@@ -65,8 +65,6 @@ public:
> 
>     void preconnectTo(WebCore::FrameLoader&, const URL&, WebCore::StoredCredentialsPolicy, PreconnectCompletionHandler&&) final;
> 
>-    void storeDerivedDataToCache(const SHA1::Digest&, const String&, const String&, WebCore::SharedBuffer&) final { }
>-
>     void setCaptureExtraNetworkLoadMetricsEnabled(bool) final { }
> 
>     bool isSerialLoadingEnabled() const { return m_isSerialLoadingEnabled; }

Flags:

andersca: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192452: 356706