Attachment 356689 Details for Bug 181957 – Patch

[patch] Patch

bug-181957-20181205175926.patch (text/plain), 4.01 KB, created by Jiewen Tan on 2018-12-05 17:59:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-05 17:59:27 PST

Size: 4.01 KB

patch

obsolete

>Subversion Revision: 238877
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b9c902bcf41b5f730cc441dd2d7f658b10c4f6e1..8bcadca34f057a34f262dd5f312dfece0557ec40 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-05  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=181957
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since the timing information is a multiplier of a small delta, it is likely that
>+        two timing information are the same as they are so close that fall into the same
>+        bucket. Therefore, this patch releases the check of 't0 !== t1'.
>+
>+        * http/tests/misc/resource-timing-resolution-expected.txt:
>+        * http/tests/misc/resource-timing-resolution.html:
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2018-11-30  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Don't report resource timing to parent frame for history items
>diff --git a/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt b/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt
>index b91561d14fc15f1e25c540632fdbaedda5501412..2b213f2a468b92d56014bd001c30fa07b0942269 100644
>--- a/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt
>+++ b/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt
>@@ -3,7 +3,6 @@ Verifies the minimum resolution is 5 microseconds.
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-PASS t0 !== t1 is true
> PASS shouldBeNearZeroOrOne < 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) < 1e-10 is true
> PASS successfullyParsed is true
> 
>diff --git a/LayoutTests/http/tests/misc/resource-timing-resolution.html b/LayoutTests/http/tests/misc/resource-timing-resolution.html
>index d1995df8b9eb822c0aee5632e4c4dbaad7a7601f..a47b28373e31f10766fb149be9d78f0687dfae8c 100644
>--- a/LayoutTests/http/tests/misc/resource-timing-resolution.html
>+++ b/LayoutTests/http/tests/misc/resource-timing-resolution.html
>@@ -18,7 +18,6 @@ window.addEventListener("load", function() {
>     var entries = performance.getEntries();
>     t0 = entries[0].fetchStart;
>     t1 = entries[1].fetchStart;
>-    shouldBe("t0 !== t1", "true");
> 
>     var expectedResolutionMilliseconds = 0.005;
>     var integerMultipleOfResolution = (t1 - t0) / expectedResolutionMilliseconds;
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index 53bac478465471265acf9d5baacf3436aa90e902..05135f54db68746f5248b21047d81f7320e1a07d 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -1260,8 +1260,6 @@ webkit.org/b/181167 imported/w3c/web-platform-tests/service-workers/service-work
> 
> webkit.org/b/181392 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html [ Pass Failure ]
> 
>-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
>-
> webkit.org/b/181821 fast/visual-viewport/ios/caret-after-focus-in-fixed.html [ Pass Failure ]
> 
> webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ]
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index be0636030a1dfc342cbe082883fc8da3cb5a9688..ff9b37fac456ae52bb159c669fe0c34cc607c353 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -820,8 +820,6 @@ webkit.org/b/181750 imported/w3c/web-platform-tests/service-workers/service-work
> 
> webkit.org/b/181839 [ Debug ] inspector/debugger/breakpoint-action-log.html [ Pass Timeout ]
> 
>-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
>-
> webkit.org/b/181835 webrtc/captureCanvas-webrtc.html [ Pass Timeout ]
> 
> webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 181957: 356689