Attachment 356676 Details for Bug 192353 – Patch for landing

[patch] Patch for landing

bug-192353-20181205162812.patch (text/plain), 1.81 KB, created by Matt Baker on 2018-12-05 16:28:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-12-05 16:28:20 PST

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 238874
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9271caa8a2edab6b000f0e46c3c0d9f4824a98a0..c8228012b60246d3fa319a3f0e336885b32c841c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-05  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
>+        https://bugs.webkit.org/show_bug.cgi?id=192353
>+        <rdar://problem/46455019>
>+
>+        Reviewed by Devin Rousso.
>+
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.prototype.deselect):
>+        Don't early return when the element is not the selected tree element.
>+        This condition no longer holds now that TreeOutline supports multiple selection.
>+
> 2018-12-04  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index 5555209a1b4c084ee3c3293114b482a808e2ead9..6d79a9ec89b76eb599c0b4af64fb537bc9421637 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -532,9 +532,11 @@ WI.TreeElement = class TreeElement extends WI.Object
> 
>     deselect(suppressNotification)
>     {
>-        if (!this.treeOutline || this.treeOutline.selectedTreeElement !== this || !this.selected)
>+        if (!this.treeOutline || !this.selected)
>             return false;
> 
>+        console.assert(this.treeOutline.selectedTreeElements.includes(this));
>+
>         this.selected = false;
>         this.treeOutline.selectTreeElementInternal(null, suppressNotification);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192353: 356466 | 356543 | 356560 | 356676 | 356683