Attachment 356674 Details for Bug 192290 – Fixes the bug

[patch] Fixes the bug

bug-192290-20181205161108.patch (text/plain), 2.73 KB, created by Ryosuke Niwa on 2018-12-05 16:11:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-12-05 16:11:09 PST

Size: 2.73 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 238900)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-12-05  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=192290
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added an assertion to make sure we have a valid DisplayID.
>+
>+        * platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
>+        (WebCore::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
>+
> 2018-12-05  Frederic Wang  <fwang@igalia.com>
> 
>         Minor refactoring of the scrolling code
>Index: Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp	(revision 238900)
>+++ Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp	(working copy)
>@@ -36,6 +36,7 @@ namespace WebCore {
> DisplayRefreshMonitorMac::DisplayRefreshMonitorMac(PlatformDisplayID displayID)
>     : DisplayRefreshMonitor(displayID)
> {
>+    ASSERT(displayID);
> }
> 
> DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac()
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 238916)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2018-12-05  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=192290
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixed the bug by updating the DisplayID upon attaching to a WebContent process
>+        after a process swap as well as after the previous WebContent process had crashed.
>+
>+        The behavior change is tested by existing tests by the newly added assertion in WebCore.
>+
>+        * UIProcess/Cocoa/WebViewImpl.mm:
>+        (WebKit::WebViewImpl::didRelaunchProcess):
>+
> 2018-12-05  Chris Dumez  <cdumez@apple.com>
> 
>         Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
>Index: Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>===================================================================
>--- Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	(revision 238900)
>+++ Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	(working copy)
>@@ -1498,6 +1498,7 @@ void WebViewImpl::didRelaunchProcess()
>         m_gestureController->connectToProcess();
> 
>     accessibilityRegisterUIProcessTokens();
>+    windowDidChangeScreen(); // Make sure DisplayID is set.
> }
> 
> void WebViewImpl::setDrawsBackground(bool drawsBackground)

Actions: View | Formatted Diff | Diff

Attachments on bug 192290: 356674 | 356681 | 356682 | 356700