Attachment 356665 Details for Bug 192061 – Part 1.

[patch] Part 1.

bug-192061-20181205150307.patch (text/plain), 2.33 KB, created by Jiewen Tan on 2018-12-05 15:03:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-05 15:03:08 PST

Size: 2.33 KB

patch

obsolete

>Subversion Revision: 238877
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3a305c838663319f167f0a0e9cb532f4d6e1c37e..f3f2bb84986b4394da7d1ab4204aca6a47c78e27 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-05  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=192061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part 1.
>+
>+        Add some loggings to determine possible causes for the flakiness.
>+
>+        * UIProcess/WebAuthentication/Cocoa/HidService.mm:
>+        (WebKit::HidService::continueAddDeviceAfterGetInfo):
>+        * UIProcess/WebAuthentication/Mock/MockHidService.cpp:
>+        (WebKit::MockHidService::platformStartDiscovery):
>+
> 2018-12-04  Youenn Fablet  <youenn@apple.com>
> 
>         Calling getUserMedia in a link that was opened with target="_blank" does not work the second time
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm b/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
>index 2b386e03d772e1d8cd8e6a9cc482931f15ffd44c..988e96b5727f890281f8fb829b20f552532210f5 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
>+++ b/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
>@@ -115,6 +115,7 @@ void HidService::continueAddDeviceAfterGetInfo(CtapHidDriver* ptr, Vector<uint8_
>         return;
>     }
>     // FIXME(191535): Support U2F authenticators.
>+    LOG_ERROR("Couldn't parse a ctap get info response.");
> }
> 
> } // namespace WebKit
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp
>index b35a87379b19eefdb2a977e8dcdd93b74a7d267e..958764f30d134c3500bf64e890ab22d69453deb3 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp
>+++ b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp
>@@ -43,6 +43,7 @@ void MockHidService::platformStartDiscovery()
> {
>     if (!!m_configuration.hid)
>         deviceAdded(nullptr);
>+    LOG_ERROR("No hid authenticators is available.");
> }
> 
> UniqueRef<HidConnection> MockHidService::createHidConnection(IOHIDDeviceRef device) const

Actions: View | Formatted Diff | Diff

Attachments on bug 192061: 356665 | 357284 | 357480 | 357622 | 357969 | 358635 | 358758 | 358844 | 358846 | 358851