Attachment 356662 Details for Bug 192430 – proposed patch

[patch] proposed patch

VersionMacro10.txt (text/plain), 3.57 KB, created by Alexey Proskuryakov on 2018-12-05 14:49:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2018-12-05 14:49:26 PST

Size: 3.57 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 238908)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Move more macros out of WebKit's config.h
>+        https://bugs.webkit.org/show_bug.cgi?id=192430
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Platform.h:
>+
> 2018-12-04  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [SOUP] Move URLSoup back to WebCore after r238771
>Index: Source/WTF/wtf/Platform.h
>===================================================================
>--- Source/WTF/wtf/Platform.h	(revision 238800)
>+++ Source/WTF/wtf/Platform.h	(working copy)
>@@ -1418,3 +1418,24 @@
> #define USE_CFNETWORK_AUTO_ADDED_HTTP_HEADER_SUPPRESSION 1
> #endif
> #endif
>+
>+#if PLATFORM(MAC)
>+#define HAVE_WINDOW_SERVER_OCCLUSION_NOTIFICATIONS 1
>+#endif
>+
>+#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC)
>+#define HAVE_SEC_ACCESS_CONTROL 1
>+#endif
>+
>+#if PLATFORM(IOS)
>+/* FIXME: SafariServices.framework exists on macOS. It is only used by WebKit on iOS, so the behavior is correct, but the name is misleading. */
>+#define HAVE_SAFARI_SERVICES_FRAMEWORK 1
>+#endif
>+
>+#if ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || PLATFORM(IOS)) && !defined(__i386__)
>+#define HAVE_SAFE_BROWSING 1
>+#endif
>+
>+#if PLATFORM(IOS)
>+#define HAVE_LINK_PREVIEW 1
>+#endif
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 238911)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Move more macros out of WebKit's config.h
>+        https://bugs.webkit.org/show_bug.cgi?id=192430
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * config.h:
>+
> 2018-12-05  Chris Dumez  <cdumez@apple.com>
> 
>         Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
>Index: Source/WebKit/config.h
>===================================================================
>--- Source/WebKit/config.h	(revision 238800)
>+++ Source/WebKit/config.h	(working copy)
>@@ -66,12 +66,6 @@
> #endif
> #endif
> 
>-#if PLATFORM(MAC)
>-#ifndef HAVE_WINDOW_SERVER_OCCLUSION_NOTIFICATIONS
>-#define HAVE_WINDOW_SERVER_OCCLUSION_NOTIFICATIONS 1
>-#endif
>-#endif
>-
> // FIXME: We should work towards not using CredentialStorage in WebKit to not have problems with digest authentication.
> #ifndef USE_CREDENTIAL_STORAGE_WITH_NETWORK_SESSION
> #define USE_CREDENTIAL_STORAGE_WITH_NETWORK_SESSION 1
>@@ -83,12 +77,6 @@
> #endif
> #endif
> 
>-#ifndef HAVE_SEC_ACCESS_CONTROL
>-#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC)
>-#define HAVE_SEC_ACCESS_CONTROL 1
>-#endif
>-#endif
>-
> #ifndef ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION
> #if (PLATFORM(COCOA) || PLATFORM(GTK))
> #define ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION 1
>@@ -97,28 +85,6 @@
> #endif
> #endif
> 
>-#ifndef HAVE_SAFARI_SERVICES_FRAMEWORK
>-#if PLATFORM(IOS_FAMILY) && (!defined TARGET_OS_IOS || TARGET_OS_IOS) && !PLATFORM(IOSMAC)
>-#define HAVE_SAFARI_SERVICES_FRAMEWORK 1
>-#else
>-#define HAVE_SAFARI_SERVICES_FRAMEWORK 0
>-#endif
>-#endif
>-
>-#ifndef HAVE_LINK_PREVIEW
>-#if defined TARGET_OS_IOS && TARGET_OS_IOS
>-#define HAVE_LINK_PREVIEW 1
>-#else
>-#define HAVE_LINK_PREVIEW 0
>-#endif
>-#endif
>-
>-#if ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)) && !defined(__i386__) && !PLATFORM(IOSMAC)
>-#define HAVE_SAFE_BROWSING 1
>-#else
>-#define HAVE_SAFE_BROWSING 0
>-#endif
>-
> #ifndef ENABLE_HTTPS_UPGRADE
> #define ENABLE_HTTPS_UPGRADE 0
> #endif

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192430: 356662