Attachment 356656 Details for Bug 192427 – proposed patch

[patch] proposed patch

VersionMacro8.txt (text/plain), 2.15 KB, created by Alexey Proskuryakov on 2018-12-05 14:15:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2018-12-05 14:15:53 PST

Size: 2.15 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 238800)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * config.h:
>+
> 2018-12-03  Eric Carlson  <eric.carlson@apple.com>
> 
>         [MediaStream] 'devicechange' event when more capture device information are revealed.
>Index: Source/WebCore/config.h
>===================================================================
>--- Source/WebCore/config.h	(revision 238800)
>+++ Source/WebCore/config.h	(working copy)
>@@ -59,14 +59,3 @@
> #if PLATFORM(MAC) || PLATFORM(WPE)
> #define USE_NEW_THEME 1
> #endif
>-
>-#if USE(CG)
>-#ifndef CGFLOAT_DEFINED
>-#if (defined(__LP64__) && __LP64__) || (defined(__x86_64__) && __x86_64__) || defined(_M_X64) || defined(__amd64__)
>-typedef double CGFloat;
>-#else
>-typedef float CGFloat;
>-#endif
>-#define CGFLOAT_DEFINED 1
>-#endif
>-#endif /* USE(CG) */
>Index: Source/WebKitLegacy/mac/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/mac/ChangeLog	(revision 238908)
>+++ Source/WebKitLegacy/mac/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-12-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        Stop defining CGFloat in WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=192427
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitPrefix.h:
>+
> 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Turn WritingDirection into an enum class
>Index: Source/WebKitLegacy/mac/WebKitPrefix.h
>===================================================================
>--- Source/WebKitLegacy/mac/WebKitPrefix.h	(revision 238800)
>+++ Source/WebKitLegacy/mac/WebKitPrefix.h	(working copy)
>@@ -63,16 +63,6 @@
> #if !TARGET_OS_IPHONE
> #import <Carbon/Carbon.h>
> 
>-#ifndef CGFLOAT_DEFINED
>-#ifdef __LP64__
>-typedef double CGFloat;
>-#else
>-typedef float CGFloat;
>-#endif
>-#define CGFLOAT_DEFINED 1
>-#endif
>-#endif
>-
> #ifdef __OBJC__
> #if !TARGET_OS_IPHONE
> #import <Cocoa/Cocoa.h>

Flags:

ap: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 192427: 356656 | 356747