Attachment 356626 Details for Bug 192413 – Patch

[patch] Patch

bug-192413-20181205112449.patch (text/plain), 2.14 KB, created by Jonathan Bedard on 2018-12-05 11:24:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2018-12-05 11:24:49 PST

Size: 2.14 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 238900)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-12-05  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Clean-up apple_additions
>+        https://bugs.webkit.org/show_bug.cgi?id=192413
>+        <rdar://problem/46493491>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        After the addition of watchOS, some functions which were originally iOS specific were
>+        generalized to include all devices.
>+
>+        * Scripts/webkitpy/port/ios_device.py:
>+        (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
>+        (IOSDevicePort.path_to_crash_logs): Ditto.
>+        (IOSDevicePort.clean_up_test_run): Ditto.
>+
> 2018-12-05  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         [MSE][GStreamer] Remove the AppendPipeline state machine
>Index: Tools/Scripts/webkitpy/port/ios_device.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/ios_device.py	(revision 238900)
>+++ Tools/Scripts/webkitpy/port/ios_device.py	(working copy)
>@@ -52,7 +52,7 @@ class IOSDevicePort(IOSPort):
> 
>     def _driver_class(self):
>         if apple_additions():
>-            return apple_additions().ios_device_driver()
>+            return apple_additions().device_driver()
>         return super(IOSDevicePort, self)._driver_class()
> 
>     @classmethod
>@@ -67,7 +67,7 @@ class IOSDevicePort(IOSPort):
>     def path_to_crash_logs(self):
>         if not apple_additions():
>             raise RuntimeError(self.NO_ON_DEVICE_TESTING)
>-        return apple_additions().ios_crash_log_path()
>+        return apple_additions().device_crash_log_path()
> 
>     def _look_for_all_crash_logs_in_log_dir(self, newer_than):
>         log_list = {}
>@@ -115,4 +115,4 @@ class IOSDevicePort(IOSPort):
> 
>     def clean_up_test_run(self):
>         super(IOSDevicePort, self).clean_up_test_run()
>-        apple_additions().ios_device_clean_up_test_run(self, self._path_to_driver(), self._build_path())
>+        apple_additions().device_clean_up_test_run(self, self._path_to_driver(), self._build_path())

Actions: View | Formatted Diff | Diff

Attachments on bug 192413: 356626