WebKit Bugzilla
Attachment 356572 Details for
Bug 192391
: Use directory local sequential numbers for Unified Sources filenames instead of global sequential numbers for CMake
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Test the bots
bug-192391-20181205045651.patch (text/plain), 2.22 KB, created by
Carlos Bentzen
on 2018-12-04 19:56:52 PST
(
hide
)
Description:
Test the bots
Filename:
MIME Type:
Creator:
Carlos Bentzen
Created:
2018-12-04 19:56:52 PST
Size:
2.22 KB
patch
obsolete
>Subversion Revision: 238874 >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index 2591746e6e71820537f6f9d49bea0f23bb1673a5..f14ba6cdb07f7821503625932e1d7c20ce105172 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,19 @@ >+2018-12-04 Carlos Eduardo Ramalho <cadubentzen@gmail.com> >+ >+ Use hash in Unified Sources filename instead of ascending integers >+ https://bugs.webkit.org/show_bug.cgi?id=192391 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Change Unified Sources naming convention from UnifiedSourceXYZ.cpp with XYZ being an integer to >+ UnifiedSource-hash.cpp. With ascending integer, every new bundle added would shift the next ones and >+ prevent compiler caches from speeding up consecutive builds e.g. in git-bisect sessions. >+ >+ The hash is calculated based on the text content of the UnifiedSource, so only bundles which have their >+ content modified will be rebuilt in consecutive builds. >+ >+ * Scripts/generate-unified-source-bundles.rb: Use a 13-characters SHA1 digest in filename instead of ascending integers. >+ > 2018-12-04 Carlos Garcia Campos <cgarcia@igalia.com> > > [SOUP] Move URLSoup back to WebCore after r238771 >diff --git a/Source/WTF/Scripts/generate-unified-source-bundles.rb b/Source/WTF/Scripts/generate-unified-source-bundles.rb >index 8880e6f7488f11b7f4f9b597b0b9b2cba15713bc..e523f9edd9f515f71eac1c2283da50a169bb0ea2 100644 >--- a/Source/WTF/Scripts/generate-unified-source-bundles.rb >+++ b/Source/WTF/Scripts/generate-unified-source-bundles.rb >@@ -21,6 +21,7 @@ > # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF > # THE POSSIBILITY OF SUCH DAMAGE. > >+require 'digest' > require 'fileutils' > require 'pathname' > require 'getoptlong' >@@ -202,7 +203,9 @@ class BundleManager > end > > def bundleFileName(number) >- @extension == "cpp" ? "UnifiedSource#{number}.#{extension}" : "UnifiedSource#{number}-#{extension}.#{extension}" >+ # Using only a shortened hash for filename readability. >+ digest = Digest::SHA1.hexdigest(@currentBundleText)[0..12] >+ @extension == "cpp" ? "UnifiedSource-#{digest}.#{extension}" : "UnifiedSource-#{digest}-#{extension}.#{extension}" > end > > def flush
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192391
:
356571
|
356572
|
356658
|
356715
|
358073
|
358091
|
358576