Attachment 356534 Details for Bug 192378 – Patch

[patch] Patch

bug-192378-20181204142813.patch (text/plain), 2.25 KB, created by Suresh Koppisetty on 2018-12-04 14:28:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Suresh Koppisetty

Created: 2018-12-04 14:28:14 PST

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 238874
>diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog
>index 5d89525740e97c16feb154087968a42952d1a14c..c8c5bbdeabf86f73fefae0abc687f0cb89f42881 100644
>--- a/PerformanceTests/ChangeLog
>+++ b/PerformanceTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-04  Suresh Koppisetty  <skoppisetty@apple.com>
>+
>+        Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
>+        https://bugs.webkit.org/show_bug.cgi?id=192378
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        FeedbackServer currently depends on Tornado-5.1, which further adds
>+        dependency of "singledispatch", "backports-abc" and "futures" python libraries.
>+        Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
>+        will let us run the benchmark scripts without installing any new python libraries.
>+
>+        * LaunchTime/launch_time.py:
>+        * LaunchTime/new_tab.py:
>+
> 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
> 
>         [BigInt] Add support to BigInt into ValueAdd
>diff --git a/PerformanceTests/LaunchTime/launch_time.py b/PerformanceTests/LaunchTime/launch_time.py
>index 53a5a3b728364955c0565816916332999c9643ed..be8467873fea867f8f6172ddc818bcf82d01f60b 100644
>--- a/PerformanceTests/LaunchTime/launch_time.py
>+++ b/PerformanceTests/LaunchTime/launch_time.py
>@@ -10,7 +10,6 @@ import sys
> import threading
> import time
> 
>-from feedback_server import FeedbackServer
> 
> 
> # Supress logs from feedback server
>@@ -146,6 +145,7 @@ class LaunchTimeBenchmark:
>         self._server_ready.acquire()
> 
>         if self._feedback_in_browser:
>+            from feedback_server import FeedbackServer
>             self._feedback_server = FeedbackServer()
>             self._feedback_port = self._feedback_server.start()
> 
>diff --git a/PerformanceTests/LaunchTime/new_tab.py b/PerformanceTests/LaunchTime/new_tab.py
>index d5c5d19133f9613e7b4eabfb0b3c3749635b8b2c..161b665f992623951c69fc497df0d96da7439582 100755
>--- a/PerformanceTests/LaunchTime/new_tab.py
>+++ b/PerformanceTests/LaunchTime/new_tab.py
>@@ -4,8 +4,6 @@ import time
> from threading import Event
> 
> from launch_time import LaunchTimeBenchmark, DefaultLaunchTimeHandler
>-import feedback_server
>-
> 
> class NewTabBenchmark(LaunchTimeBenchmark):
>     def _parse_wait_time(self, string):

Actions: View | Formatted Diff | Diff

Attachments on bug 192378: 356534