Attachment 356515 Details for Bug 192362 – Patch

[patch] Patch

bug-192362-20181204104320.patch (text/plain), 1.70 KB, created by Chris Dumez on 2018-12-04 10:43:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-12-04 10:43:20 PST

Size: 1.70 KB

patch

obsolete

>Subversion Revision: 238842
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index fc3bf0fedea43c9d47bb4039d661b712f57f171d..6807aa73f5ea72ebf5e5e352f9d53bba3e8989fc 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-04  Chris Dumez  <cdumez@apple.com>
>+
>+        ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=192362
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Set the cookie policy to Accept to make sure the cookies are saved.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2018-12-03  Chris Dumez  <cdumez@apple.com>
> 
>         Regression(PSON) Google OAuth is broken in private sessions
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index fd00363eee22a5d318adcdf77571192f5e295df0..a2b6af23bf8e1b9b661eb2f7c8d12633d49f049c 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -2993,7 +2993,7 @@ TEST(ProcessSwap, UseSessionCookiesAfterProcessSwapInPrivateBrowsing)
>     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
>     processPoolConfiguration.get().processSwapsOnNavigation = YES;
>     auto processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
>-
>+    [processPool _setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyAlways];
>     RetainPtr<WKWebsiteDataStore> ephemeralStore = [WKWebsiteDataStore nonPersistentDataStore];
> 
>     auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);

Actions: View | Formatted Diff | Diff

Attachments on bug 192362: 356515 | 356734 | 356820