Attachment 356494 Details for Bug 192360 – Patch

[patch] Patch

bug-192360-20181204091641.patch (text/plain), 1.78 KB, created by Michael Catanzaro on 2018-12-04 07:16:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-12-04 07:16:42 PST

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 238817
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 96dd57f28fbeadf276f74190bff7a88f55e39a5e..25e61617de30a56eba869fde3701970006789252 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-04  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [GTK] Don't use the slice allocator
>+        https://bugs.webkit.org/show_bug.cgi?id=192360
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * MiniBrowser/gtk/main.c:
>+        (aboutDataRequestFree):
>+        (aboutDataRequestNew):
>+
> 2018-12-03  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
>diff --git a/Tools/MiniBrowser/gtk/main.c b/Tools/MiniBrowser/gtk/main.c
>index 6eff950e3a59c02ecccba32315c72dc583192320..afbe555ea5283bbb7c8743f4a3767f6e5cd1ee41 100644
>--- a/Tools/MiniBrowser/gtk/main.c
>+++ b/Tools/MiniBrowser/gtk/main.c
>@@ -268,7 +268,7 @@ static void aboutDataRequestFree(AboutDataRequest *request)
>     if (request->dataMap)
>         g_hash_table_destroy(request->dataMap);
> 
>-    g_slice_free(AboutDataRequest, request);
>+    g_free(request);
> }
> 
> static AboutDataRequest* aboutDataRequestNew(WebKitURISchemeRequest *uriRequest)
>@@ -276,7 +276,7 @@ static AboutDataRequest* aboutDataRequestNew(WebKitURISchemeRequest *uriRequest)
>     if (!aboutDataRequestMap)
>         aboutDataRequestMap = g_hash_table_new_full(g_direct_hash, g_direct_equal, NULL, (GDestroyNotify)aboutDataRequestFree);
> 
>-    AboutDataRequest *request = g_slice_new0(AboutDataRequest);
>+    AboutDataRequest *request = g_new0(AboutDataRequest, 1);
>     request->request = g_object_ref(uriRequest);
>     g_hash_table_insert(aboutDataRequestMap, GUINT_TO_POINTER(webkit_web_view_get_page_id(webkit_uri_scheme_request_get_web_view(request->request))), request);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192360: 356494